From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0053.outbound.protection.outlook.com [104.47.38.53]) by dpdk.org (Postfix) with ESMTP id C161E108D for ; Tue, 24 Jan 2017 10:07:28 +0100 (CET) Received: from BY2PR03CA050.namprd03.prod.outlook.com (10.141.249.23) by BN1PR0301MB0739.namprd03.prod.outlook.com (10.160.78.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Tue, 24 Jan 2017 09:07:27 +0000 Received: from BL2FFO11OLC008.protection.gbl (2a01:111:f400:7c09::115) by BY2PR03CA050.outlook.office365.com (2a01:111:e400:2c5d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Tue, 24 Jan 2017 09:07:27 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC008.mail.protection.outlook.com (10.173.160.143) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Tue, 24 Jan 2017 09:07:26 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0O97Mf9016643; Tue, 24 Jan 2017 02:07:23 -0700 To: Ferruh Yigit References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-17-git-send-email-hemant.agrawal@nxp.com> <7c521c9c-e868-81c1-39ec-ae26db8fbf69@intel.com> CC: Hemant Agrawal , , , , , From: Shreyansh Jain Message-ID: <33f05835-47aa-39d3-0338-01ab165be6d9@nxp.com> Date: Tue, 24 Jan 2017 14:42:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <7c521c9c-e868-81c1-39ec-ae26db8fbf69@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131297224471423903; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39410400002)(39400400002)(39850400002)(39840400002)(39450400003)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(377454003)(24454002)(199003)(189002)(50986999)(6916009)(86362001)(47776003)(54356999)(65806001)(6666003)(76176999)(230700001)(2906002)(23746002)(31696002)(38730400001)(2950100002)(93886004)(229853002)(4326007)(77096006)(104016004)(92566002)(110136003)(33646002)(356003)(189998001)(65956001)(54906002)(8656002)(83506001)(68736007)(31686004)(64126003)(65826007)(50466002)(626004)(305945005)(81166006)(8676002)(106466001)(36756003)(81156014)(105606002)(53936002)(8936002)(85426001)(97736004)(5660300001)(4001350100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0739; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC008; 1:13dwRMWpXhNpOEvBlxOAbl77NVQIN9GhHKinx5bZAXMB8NJa5DSBSA2mN/OT7O72c55cTGhPv5yvy/kjoMiH5VB/q9dFVLHSQrFkRmO+mYldns00Hgm6xqhz2YOb/ByFvkndwgJVNVLDi42oVRkkPBOdyWD9dN5QicYSo5A2aMGGKav58WtQsup1HqFZFyk24rCSx1a8GRdK5V6Tp3lCIgkVwHHrcJFvF+/3WTlOF7CG19g2ZGp9EM3Btm4poi1aYp7Niu8ZQVVLoWXghErt8uK2pNBPObJysQg+IQVBzJ4pYqDYpvrD0NZC0UE2CPbouQug2wUUnnhZQV4IH7YMRzF4b4KqQoBv6x9uXjW7Pypq3PNa/bSmbXmcsasM1r9RNy4Fiuk1t6jwabqEQs2UuY8jlOQhX0v1/yIGrBeVzP3Xu14/SOuA9MMwGKOk/H635zfEByQAh2cbmIDCA8EFMg0MULpwifSffpWITF375SahveRwciWPLuafT7IzNfrWjuoZkwtyDDjPMkXRCAS+bUMKqMwCtI+wKTITfH1ZOnL1VX08sVpi8EU87fG24HipajyUu0SevKT8Izp3URqWG89NiNmzstZzZZhVSFIgco1ZFtb9HIyYtw9Tt8Hfy3Hy X-MS-Office365-Filtering-Correlation-Id: e62a4500-4a06-4027-bf5a-08d444386afe X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN1PR0301MB0739; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 3:jYt54jIJknOJbmka5wHambl+2fN69oWlXMw2jg2edNiVGmxfFqz6yB3Ithsq8TiOJH7UaqDjlFILWADo8kiJZqA4LAImB8+IbmafpLFK0e9VtMVSMY73GcVyBmAeVhs/AZD66Grwq1F13WqBKuX8TVKPZdgIrrArR9WyOTZ0GbO39ogAdfjiZeb4guZjVp40Ij5z96P4Fh+rbil+Z+wH8qkRb4e6nmJYJDD20v2KOtNsZM/nmGAYBWYovSTZ7bThcsLB36FAoBcaT77MOjAUmjQyvopGXDfQr83heH2MCmJOxWDkhWbbgs+5Y1L0jWkk0uhEVVl4TNDNnPcsPHGV6QA3Yo3M7/c3X0jVGROIQCElImW4rqPpfL67FgKW/aFb X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 25:yl2J7HuIC04Vc6INlGgHXXMYsENvX7aSaY75CDDPUWg61zdukelX/inCzomR82GtP/MBf5FJjjxDFA8heAsg1YEEb18x64FF1nksW4rlBV/yssnIxTOOMCbZp6TMo1piFOPwCMRt/KRKxREg9xRdeGiakYlg7JWzOgw71ESf++h1aqFx1CGOR4t7Xz31B/zfAqitoaGp79ttzpX0/AEkeXegX15TcywcC/N7x7kUfHV4zRlg9RNajoBKQcMzOSJnboFfFLDro4rlhrLKHdelfsh0TstuenapU6QSedf97SNRWlYNqIQWy0CZwfAKgipIVP6+v73THNusNWnp9F2PV4G77qjO4cz0zWq/Bl7FzX5kae4/373k5fsKx8iUSw4/z/xoJgmLPRLW7uFll1Trvm9oDgoViZaQmTrJXqw4KGDjzuDqmDuem9KkuG12nI5e6rAztTj20gl5TAmahNHGssal5AXNA1b7bUS0NVdM5pK4DbjMz7TrpgKBQQRcMRZKQ0FeGml0YOjj9fTI5ZlTaD2OzIDxIMwnV1TF+EUyeXrrjx9XoMMslG8sr4f8QROPdQGPiMTPG2+gtXTSva08jXAXfuWvzntRzwjIkqmb3mgio0JrrPnymt3YPkx36HpuCQ5sGbybQEUKWvl0R0kDGd5vydv6D32T+XRg48Mh6wQ4OgA3sujEm5hlObAVau6AKzwTqtlLHITD56r2Emq1pB/NtmUKRTAz+bO3vvupl6i78sA+9vw5umCtr71Tk4LNPGk7iczOSIqpeK0t1uZ7+w== X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 31:E4dqXBZS30hQ2VUaC77LlXQfVr0KoYjOfdS6Y1s7isU91t4uub/D8YnXLQ4TAYgtp2bkPMi9GUuruO5JcP0SYkjL2Z+wFTkNUdJV1BZ4iwddU1G7GpY2TwnhswjlNwe0ZVRrG+XoafuZ4OJ51EG7xjr4svAa50jbopoGW52Xmg3EXoCqyzhv4VaYAtdWy4gUs4F7iRDNgS9ihwUAGHCoIXat09mum3HumxMjaXxRJJp3TnMzNO6jVHejhDxHreScdZiU8o8JXJcghmq6Ms8pCQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13017025)(13015025)(13024025)(13023025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(20161123559025); SRVR:BN1PR0301MB0739; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0739; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 4:/rw1cFpPamCJiZWyfRqvt6+Zi4sOLf2x9P+bgo4xo7knxOOWaR67obfSIiHTQc/RBnnTBwtT+TMi7XmHQIYSGxG6hDOPgyPKkUPuOBJ6zFxYKSuompisUE/51FtuGVmR6gtjU2gJgGf7BYZD8vJd7zjRPRtoTn3DJsOw3C2PhFSwIYQGrzcUz/TmQtLcftLvZz424c4jMn9k7rOXToZqiVKAQelpLKtZ8LJdhRMFz/91UWHvupXh+s2yeTCH04iiN/QaVs2xodAqNMcqxfkBCbl8DihEvdeNMVNlBwkv87V7nPzH4tri/UxQGR/V4calclKx2C6U3BObDGMrjFGnakGO9Mt4c9Qf3Er9HP+r/dKH3D9Aekm4/ViZ9dII0iA7DVRN7YbyKJdtsVIAlDCAatEJLNRN9FPbOxUgcvgwGiprqIXChGpa1p3zKeIQNhlPBIJGs4Ph7pTPuoKHFkkNpQI50uFNK1SBbIZE1DSmqVFsGqrevXKUEFwuOFx6umUNKzmrw885c5IVT55NAMhCjHYZLHNmnc9o4c1/q2sQwDI0Y67xbaxjByXacEI7sgQjG1/JYOVdFBPxTzZha5iy2HH9pm9Hbuh2plZPzOAd8ueQc5ryZ0xwEHyNWDTZH7rpI83ApGUSBimmyvrQzDF/Q8OvEcId/HS7fnkyJ3r2rtK05JCdaQf3aXS95vsKAH5RTRpKgOJcV2sERM62QMsgQXctZCIOjyeFyjACIbQc0gDEwME+FMBqZShqz6rAcrSM X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR0301MB0739; 23:CD2zJbpvRTIA4Uh1uvCjggNk+DwvW++xmZ9?= =?Windows-1252?Q?S0/NXipOyxGHwn3PNteENoStXSE90lM9u6xnCXW97v/poCNkG3k0Uta3?= =?Windows-1252?Q?PIR32Y0ExtUkOJPibanrLZsVG0uLKvFFEXzS+t1OIAbi0CRwujJFKbTy?= =?Windows-1252?Q?tuKKKlmoq8ZlrRm8nfsHI0k6ZCZMPd/tvGnsHiMnexpZJ7PoG6oaSvmm?= =?Windows-1252?Q?J0LrlFoY/jxQVellyhcF7JCrOCFyGbMmnnOIxIjHZh/0Uj8B0DK+Mq/X?= =?Windows-1252?Q?RmXtDbsBvSzAO7LSCXfvFHsd9onC3FVCZV6codccFmRtJ397HNUfkell?= =?Windows-1252?Q?DS2pMyel0IZfW0KPlOY6I4pimf8+JvcafyNRtq+7gG5goK6+N7nQeaI9?= =?Windows-1252?Q?8KSe2w8gdGCQ4S2bqw5c0boWerGuMo8+G3KZjBJikfaVDV+1D4VV35J3?= =?Windows-1252?Q?EOrTMnyWUSh1UC0eBtpmyzMRKB+2Bwvg1ySVI0zzdcWHH601Oj+IKgEp?= =?Windows-1252?Q?ZUmGgmZNofT0mGZ7w1HmTth3+pvhrFQfnJA1AjX4YslUMrf8ttFseAnr?= =?Windows-1252?Q?QFj14R5lxTeaHg1la1D0+MZMDW7SHVE8G3tLVto+npqWzj/511eJweDu?= =?Windows-1252?Q?E4LUjzAnj6BqH30fnfZE/5oYovqtw5wykfXY0xaRDnA/y3w5kn7VwvKC?= =?Windows-1252?Q?iLNKlY/jRUD64F+q8+uKWBPeVtZa/8k3DnN8cPktZevFuRWCQ9ltzll5?= =?Windows-1252?Q?mr3Ij+PwiS/2UeA2B68sJ0OlyD/1VX1QJkfvILkXa5btespvFvFbb+vW?= =?Windows-1252?Q?7ycXVLlfvt6y9U2aAZy8USh8rsPAb1+WpJ4TJsOwlqkE5gQKlOkpDqCl?= =?Windows-1252?Q?ZZWRbAMo6mv2JMyQdGxF2xYBwu8j1I2hN78jRqumMRo167UWZehgXbg6?= =?Windows-1252?Q?QDZrEilz/CFDaAhHZIIQG5JfQNoe+x1wPJ6YEA2SsT21ePCqqYtoLotF?= =?Windows-1252?Q?ybzzx5Fu31Pq0u9e38d34sCqFlBDDbrUAcMRwUw3b7BNPsoqcpzptddi?= =?Windows-1252?Q?Y7wLnYgiPjLegLMlWHyLp7h1gWrLWjwVDQntgKCxKu3yJ/tgGsVnXbar?= =?Windows-1252?Q?t6EROG1AkhOP0uw27ffDH/aCbWR32IKrc77vp6BemdEXslT8LHk5Ye15?= =?Windows-1252?Q?MAPT6Xb0uu0YCmp7+HG0Y8mlTy2DCx0Nx+AEP+X+1kSPh1eWWOvunjqn?= =?Windows-1252?Q?+ncBEAdvuFLg5uZA5b0YEcgSYKRUkiCtGbT3Hs4nfQdfUXqFS1nkHTck?= =?Windows-1252?Q?iour+ojkIs7J4C1MBCOuc9uFqKKo7oGahRCTInTjvTfnavatLVH2oRQd?= =?Windows-1252?Q?7fQ2TW+0FqmVonshbK85DTij6RT67qbXxXsl1ATzJPkz2YVAcOwJaqGi?= =?Windows-1252?Q?Kg6NBbLecXohmhgTiucgZMeKGVEBRtKSwWEKBXOdwrNmbGiapmyFa7lE?= =?Windows-1252?Q?FkyQrjDq+//dpa+/Eg6mASxbEP5HZzesn0Po4iCGgUlDIReQJd/kqTXj?= =?Windows-1252?Q?8tmAKhncteA/2B4LmKugaNpDiuiVdxnEkqr/0jWsjAnMN6XxYbX27Qdi?= =?Windows-1252?Q?mtGcSvLnyAzdhdfkhsklWOdgq7020CpumEZRnKFAoIiPTLjYhec09I3O?= =?Windows-1252?Q?WGcnqBm5GIbBKbQat0yGhvctDnHJhRFM=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 6:oyqXfeiwGIojar8evyb2KjMmB0rTlY+RmdWGGfD2zVhPLTneJhAHHTwMNrtCrXoBr4QCdJnqk7qAqwJt3HlnISagQiPHw7YSwV072vha8muKTI5/jp5H4X3LBwWIeUfQKIzKa1OWcuzX0v/tSXQWUjoGZ2Snio9cY4c+2DmfkhgUHTNXr1TjVzYy3Is2S0GMs814BZHTssSG0ClrwDIAoUIlbhnC0broKFUbq0Kc+NVntrb75dMOVKcj67TkMpaBA9D7KyztX/uBQTCN5CW/EJYQCndOzAO4Gb6Ko6pxjy5UXXCj7BV2qrVd3XIoxgvTO2HFoUr+0LfxLUUWYxnizfeFQTpO3r5zs5oEad58oPMAPvFyo9DVBSFLakveG4u8sdvRY4P8ouyztrVnttBuhOjgXkz4SC8eQch4KY9KZV1odCtSBZEnR/53dkwDZWRU; 5:yZzvCk0CutPvTpynOseQQ21S69xHY+bahKP/+Jrs9G3gAWq+oXaS1saOJtRx5XjUObImZ327OQk+m8dOCX+BTxH3EZPOFA5EwrLszvag7HcLXP76Hdb3hh543uQti6wDGaX4xml6rcLgluA0Rpdlf5/oe2qlqfyQqRuxbieY2LpFQfFCUA8QG52CDWuRpUe1; 24:hOYOI5K1k+IK3eD6aKO7NDUVuMPmW0JfdlwMuim2hWPDPtRpjn6qo5YjMvnylYzsxbWgucJw4lnn8i78446NYdiK7SzLbRjvW+Ei/xgI6RI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 7:HgRYwI+ncqfHr/OJ0W9/zGMk5omyMGARL+s6/3JQRfHWwPSA8MCXmPfCCfft2eSjOr0E0YagrcvzFm9ff4vAAd4ZQaKAEgGIs39TaWXZPc1ZERLWChw6lLOAnueD7B9Gu7CCcstz9TQAbVVPdbO6gzod0NLTrtxOQjacNcexqGx5iW/INf7ZfrRGkOGgIHFie/w5/eRXrGFGXT0QK5jvT4udA9/ktLPRUAL9gVU1YKQt3GIixweNX9mUhC4x1QRcn2GpjV54hBeiHN5fhdlzq9952t6am6e2KGiw+zo7YoDH6zPxvdJsmPSqOkCFdHw/CnVtL6dYs9HKofhFUIc662mGARO1D7BDncvL+dt+uoynuy2AYlQekNQulIhRSOFpdit0ZxX9s+zG2D6BOc9J09LU2xNynnJDQxQB7WS9U3is3PUlJhYv89nBkFWdQLqwdhMR4SWRSGaQwtBj8CU3dg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2017 09:07:26.7991 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0739 Subject: Re: [dpdk-dev] [PATCHv6 16/33] drivers/pool/dpaa2: adding hw offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 09:07:29 -0000 On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote: > On 1/23/2017 11:59 AM, Hemant Agrawal wrote: >> Adding NXP DPAA2 architecture specific mempool support >> Each mempool instance is represented by a DPBP object >> from the FSL-MC bus. >> >> This patch also registers a dpaa2 type MEMPOOL OPS >> >> Signed-off-by: Hemant Agrawal >> --- > <...> > >> diff --git a/drivers/common/Makefile b/drivers/common/Makefile >> index b52931c..0bb75b5 100644 >> --- a/drivers/common/Makefile >> +++ b/drivers/common/Makefile >> @@ -35,7 +35,11 @@ ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_PMD),y) >> CONFIG_RTE_LIBRTE_DPAA2_COMMON = $(CONFIG_RTE_LIBRTE_DPAA2_PMD) >> endif >> >> -ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_POOL),y) >> +CONFIG_RTE_LIBRTE_DPAA2_COMMON = $(CONFIG_RTE_LIBRTE_DPAA2_POOL) >> +endif >> + >> +ifneq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) > > I guess this is a typo, but this prevents DPAA2_COMMON to be compiled !! It should be 'ifeq' rather than 'ifneq'. And it will prevent COMMON compilation only if CONFIG_RTE_LIBRTE_FSLMC_BUS=n which is not the case right now. We will fix it. > >> CONFIG_RTE_LIBRTE_DPAA2_COMMON = $(CONFIG_RTE_LIBRTE_FSLMC_BUS) >> endif >> > > <...> >> +# library dependencies >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_eal >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_mempool >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_common_dpaa2_qbman > > This dependeny doesn not looks correct, there is no folder like that. This is something even I need to understand. From the DEPDIRS what I understood was that though it refers to a directory, it essentially links libraries in build/lib/*. Further, somehow the development is deploying drivers/bus, drivers/common and drivers/pool in lib/* under the name specified as LIB in Makefile. My understanding was that it is expected behavior and not special because of drivers folder. Thus, above line only links lib/librte_common_dpaa2_qbman generated by drivers/common/dpaa2/qbman code. In fact, I think, this might also one of the issues why a parallel shared build fails for DPAA2 PMD (added in Cover letter). The dependency graph cannot create a graph for drivers/common as dependency for drivers/net or drivers/bus and hence parallel build fails because of missing libraries which are being parallely compiled. > >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_bus_fslmc >> + >> +include $(RTE_SDK)/mk/rte.lib.mk > > <...> >