From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 79813C41C for ; Wed, 29 Jul 2015 18:06:46 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so33331615wib.1 for ; Wed, 29 Jul 2015 09:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VqAw1WSXMwhIOSIdA8Y+tCSOywJo8onlA4huE5LlMvY=; b=DYA84/kAR3PqF6cOHiKt7MtQqz/CmkPf6CvnywmV8UwwS04NxsR8ATPgg7TVQWaUsD aAlXErKbxArKHcKmlOwQM27G7dztrjqCaQx0vPFr+sqXcwaJKgTMOSmjCaL0xZCA7rIQ Bkc1ppoO4fj5yclu/zQwD4avWKuYebcvn4FoHNpjDBxwY8nYzBrFOXRgNjENuFslndTg hg08UWppp5OHu483XVDDezXyz/O+yDSWKaUnGeXBRUJ5N+DUHN78aecxwlej4W2BJ2KJ nOy+ErdMoUCY7Xe7+hz2CdHu1QBZzZKPahcYs8o3BsRby4cE4IHPn0suU9AlsqxJFlF4 cE4g== X-Gm-Message-State: ALoCoQmFSb9TSA7xt5e1TlbaxQTybBZrS3h/JJwWwTLxqi2koudW8Oan729th1JTQkpUR2ZfC68O X-Received: by 10.180.86.73 with SMTP id n9mr7231750wiz.78.1438186006319; Wed, 29 Jul 2015 09:06:46 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id fo1sm25008997wib.24.2015.07.29.09.06.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 09:06:45 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 29 Jul 2015 18:05:31 +0200 Message-ID: <3400596.gUZi4e9jS4@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com> <55B8EBD1.5090104@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 16:06:46 -0000 2015-07-29 15:09, Zhang, Helin: > From: Gonzalez Monroy, Sergio > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and bsd") > > > > The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set, > > was moved to eal_common_pci.c, but pci_config_space_set was left in eal_pci.c > > with static specifier. > > Yes, that's the root cause. > I am just have a thought that we may need to move all of those three functions > together into eal_common_pci.c, which can avoid exporting that function. No it is specific to Linux (implemented in igb_uio only). But it may be moved to eal_common if you remove the igb_uio patch and use the new functions to access to PCI config with UIO or VFIO: http://dpdk.org/browse/dpdk/commit/?id=632b2d1deeed This build fix will be applied for 2.1. It is expected the above rework will be done for 2.2. Thanks