From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 42FC32BB1 for <dev@dpdk.org>; Fri, 3 May 2019 10:34:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E01882221C; Fri, 3 May 2019 04:34:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 03 May 2019 04:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wgk18VB8zYmoy+YC3ui8wCPMeiPgu2tnWL2i7rLOj1I=; b=ofsTN3oOO2br L/Aqrv4DAYj3GMFIdUfh4y7SBseUrXrXwCYhnVlaIvL4+pFNS6Pze+uKeE+wY/uq QmNt5OhmKXdfhAbSFIwtQ0zF4XisusOFVuqbKg7oyK8C0onsJpV+KhERu5cGJEkv tKzib91w2C+K3gHXdBt+yHc1Oc+rTHk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Wgk18VB8zYmoy+YC3ui8wCPMeiPgu2tnWL2i7rLOj 1I=; b=x6t2Y9zYTuBdfhPAkAVOBsSorxryfHFTu4xTG+8VKi3NY4eOsanHVBH51 4Ruo6UPgnPLqmlvSIHj41Gah1K57TGk6Xn0fxHTjWjk1zTzF4WpQWL+HUQeV5RwC CpL+Ax15apT3cS4AYS45JbwFT7WYSNUffSfGOPLtP6fS55QMPCfXTbC0DnLRjzsz PEyL26KSjeZMRCUrlQpEjhu33RbCjOJ6d2HWmNgnjf3YWvhzQgVqiyVw//zjLP9Y KlJzYGyznKFXu2lz/gVQ7sqvtbmzTR3AZ5FWlhcV/+Gaxd007voZfetjepEEAH1E IQUEQ6WdcgELW/uBrwlTRrnVgpbgA== X-ME-Sender: <xms:Cv3LXKErKrckv3OY1ym_ckIpFttWFcFoHNUqZ7pxgXVR2WLV7ZmjIw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:Cv3LXHT41_-2afQVXhdorZdTYrnSetrDjKC0YqoeMvipEgIea8l9nw> <xmx:Cv3LXKSd_l2D7-N4Bnz6myiB6rFafxHGJKPEO-dNoN7PFXzgDVbKZw> <xmx:Cv3LXKdP4HSizwfWBfUV53xETpblMS3a81gfkvtm7TpBiVZDpEFbYw> <xmx:Cv3LXG-hvz8H4NkO7ijbmDsYAzY8uso-kQPot43ZSxa9lQTjSmMa7Q> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CD99110369; Fri, 3 May 2019 04:34:17 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Herakliusz Lipiec <herakliusz.lipiec@intel.com> Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Fri, 03 May 2019 10:34:16 +0200 Message-ID: <3401531.dNvLWj16ye@xps> In-Reply-To: <20190425124817.28409-1-herakliusz.lipiec@intel.com> References: <20190425114324.611-1-herakliusz.lipiec@intel.com> <20190425124817.28409-1-herakliusz.lipiec@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 03 May 2019 08:34:19 -0000 25/04/2019 14:48, Herakliusz Lipiec: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL and calling free everytime rte_mp_request_sync > is used. > > v2: > - resending as patchset to make it easier to review it. Heraliusz, it's a total mess. There were 8 patches in v2. Why they disappeared? The title prefixes are often wrong, so it's harder to classify them. Should I merge all these patches? ipc: fix rte_mp_request_sync memleak ipc: fix hotplug memleak ipc: fix vdev memleak ipc: fix vfio memleak ipc: fix pdump memleak ipc: fix tap pmd memleak ipc: fix net/mlx4 memleak ipc: fix net/mlx5 memleak From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2D4B5A0AC5 for <public@inbox.dpdk.org>; Fri, 3 May 2019 10:34:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BAD92BCE; Fri, 3 May 2019 10:34:21 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 42FC32BB1 for <dev@dpdk.org>; Fri, 3 May 2019 10:34:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E01882221C; Fri, 3 May 2019 04:34:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 03 May 2019 04:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wgk18VB8zYmoy+YC3ui8wCPMeiPgu2tnWL2i7rLOj1I=; b=ofsTN3oOO2br L/Aqrv4DAYj3GMFIdUfh4y7SBseUrXrXwCYhnVlaIvL4+pFNS6Pze+uKeE+wY/uq QmNt5OhmKXdfhAbSFIwtQ0zF4XisusOFVuqbKg7oyK8C0onsJpV+KhERu5cGJEkv tKzib91w2C+K3gHXdBt+yHc1Oc+rTHk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Wgk18VB8zYmoy+YC3ui8wCPMeiPgu2tnWL2i7rLOj 1I=; b=x6t2Y9zYTuBdfhPAkAVOBsSorxryfHFTu4xTG+8VKi3NY4eOsanHVBH51 4Ruo6UPgnPLqmlvSIHj41Gah1K57TGk6Xn0fxHTjWjk1zTzF4WpQWL+HUQeV5RwC CpL+Ax15apT3cS4AYS45JbwFT7WYSNUffSfGOPLtP6fS55QMPCfXTbC0DnLRjzsz PEyL26KSjeZMRCUrlQpEjhu33RbCjOJ6d2HWmNgnjf3YWvhzQgVqiyVw//zjLP9Y KlJzYGyznKFXu2lz/gVQ7sqvtbmzTR3AZ5FWlhcV/+Gaxd007voZfetjepEEAH1E IQUEQ6WdcgELW/uBrwlTRrnVgpbgA== X-ME-Sender: <xms:Cv3LXKErKrckv3OY1ym_ckIpFttWFcFoHNUqZ7pxgXVR2WLV7ZmjIw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:Cv3LXHT41_-2afQVXhdorZdTYrnSetrDjKC0YqoeMvipEgIea8l9nw> <xmx:Cv3LXKSd_l2D7-N4Bnz6myiB6rFafxHGJKPEO-dNoN7PFXzgDVbKZw> <xmx:Cv3LXKdP4HSizwfWBfUV53xETpblMS3a81gfkvtm7TpBiVZDpEFbYw> <xmx:Cv3LXG-hvz8H4NkO7ijbmDsYAzY8uso-kQPot43ZSxa9lQTjSmMa7Q> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CD99110369; Fri, 3 May 2019 04:34:17 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Herakliusz Lipiec <herakliusz.lipiec@intel.com> Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Fri, 03 May 2019 10:34:16 +0200 Message-ID: <3401531.dNvLWj16ye@xps> In-Reply-To: <20190425124817.28409-1-herakliusz.lipiec@intel.com> References: <20190425114324.611-1-herakliusz.lipiec@intel.com> <20190425124817.28409-1-herakliusz.lipiec@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190503083416.U4kl8-nVnLWRFKJPOgPOghHvX2xj2ve41fFo6QKApFI@z> 25/04/2019 14:48, Herakliusz Lipiec: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL and calling free everytime rte_mp_request_sync > is used. > > v2: > - resending as patchset to make it easier to review it. Heraliusz, it's a total mess. There were 8 patches in v2. Why they disappeared? The title prefixes are often wrong, so it's harder to classify them. Should I merge all these patches? ipc: fix rte_mp_request_sync memleak ipc: fix hotplug memleak ipc: fix vdev memleak ipc: fix vfio memleak ipc: fix pdump memleak ipc: fix tap pmd memleak ipc: fix net/mlx4 memleak ipc: fix net/mlx5 memleak