From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 057D4A034C;
	Fri, 25 Feb 2022 19:38:54 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CBDF04113D;
	Fri, 25 Feb 2022 19:38:53 +0100 (CET)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id F2F16410FD
 for <dev@dpdk.org>; Fri, 25 Feb 2022 19:38:52 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A42CE5C0125;
 Fri, 25 Feb 2022 13:38:52 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 25 Feb 2022 13:38:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; bh=gQ8VBvXJYyiLF8
 PIf/KGd0MmHzU6f2fW7tUxX3g/N1c=; b=qHSOi6FxgraZnlg6DlDOoHvV/fhlTj
 WxU7jf+9oqayjYMNUu0+gLjFsOjshCB1fsVP75MEK2Zfq21WGTSDPVL1bzFh50KC
 6g4ohySZusqAn9O+1AVHLIsy3Cqp4BUMBAt4zeWMaqh4diDWPd6NdceisAycvfZ7
 4tXTSzy5jfbWNesm1i99kYKUzaDaa2GOVbDzFFIoErMxUhRpRtV9BqFXysKtGCZK
 UkgtpJ+UJh5CEghiY9I97mRaCU/5u4oC2FPad0oO3kzUFh9qCsFTdHvSynSW6ARi
 +ymaEQV0ZiSJkh4jBZn8mt1eJRuRGy+I/ehHbR7Xxro/Q3bxNfOOa4Nw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=gQ8VBvXJYyiLF8PIf/KGd0MmHzU6f2fW7tUxX3g/N
 1c=; b=EQbnqZZvqlENFTMEJcrFqW/Qpwq3FlySWWjEmi7B8cBLwdl3WvcV1lH+l
 qidKG6ph6enuLEAeidx25c/XP4iC+X51Rq2jgKJQOct7jYRLWcJ4UiHBLllR/pgD
 +59AmCivQRP8RWRP9GpUEl4ilAPS5qOGJBTj+Cm24ZYkCovwaugTqRFd6o35lOFJ
 NdSVd1noQo9b/O2oZmUl4n20QnxbU8HtchZZaoCzPiWE5QDNnjlp7yHKMmSdGpRi
 /X3yw13OLKi/TvsjoVvGCu/1GtjawDTnInhDvIDKF2lZHicqnnj2lM3uuGuiZQdH
 L1XwVVAwZ7xwTrOolp+F2u1YKswvw==
X-ME-Sender: <xms:PCIZYmyvxuO1_jVRl0mA0VKmgq4E1b1q8_n9cGUbL5BR5jvu0T3V4A>
 <xme:PCIZYiTVuSTv17rJpjSLHGaFKJ7ZX4pCGBE2EcXMLHAlGPDx4882JXxh7Ic6EnkAu
 EQETHFMluiIoRTBng>
X-ME-Received: <xmr:PCIZYoVwLkV-l_m1mPJUotdKvm71rBYoxoaGxWyPeikgTUG1KTffQwOdA2I7wJTLxhLMuPqqza12ZXr17Anj9gG6kw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeggdduudeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:PCIZYsjSXINkMNy90DGOoDYbD3w6oNqG40NdhW0Ns_s72IKsl1uKSw>
 <xmx:PCIZYoAziVDO9UddHJpnHmuGyt8Mp9u3Fwpki7q0yg-B9tIr_r8t0A>
 <xmx:PCIZYtKJlok_KGgPZNQwU8qDkPtyPqok_tnthdRmE-lfFeKM0gDmlQ>
 <xmx:PCIZYq3HLgvoaNs43-KUOMc9rB1cDM3IyicwFDhV9xthIL0FCXN2Ww>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 25 Feb 2022 13:38:51 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Michael Baum <michaelba@nvidia.com>, dev@dpdk.org,
 Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 David Marchand <david.marchand@redhat.com>, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal
Date: Fri, 25 Feb 2022 19:38:50 +0100
Message-ID: <3402514.V25eIC5XRa@thomas>
In-Reply-To: <e67830ca-d7e2-4705-61bd-fee49a93e1b2@intel.com>
References: <20220223184835.3061161-1-michaelba@nvidia.com>
 <20220224232511.3238707-2-michaelba@nvidia.com>
 <e67830ca-d7e2-4705-61bd-fee49a93e1b2@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

25/02/2022 19:01, Ferruh Yigit:
> On 2/24/2022 11:25 PM, Michael Baum wrote:
> > The functions which are not explicitly marked as internal
> > were exported because the local catch-all rule was missing in the
> > version script.
> > After adding the missing rule, all local functions are hidden.
> > The function mlx5_get_device_guid is used in another library,
> > so it needs to be exported (as internal).
> > 
> > Because the local functions were exported as non-internal
> > in DPDK 21.11, any change in these functions would break the ABI.
> > An ABI exception is added for this library, considering that all
> > functions are either local or internal.
> > 
> 
> When a function is not listed explicitly in .map file, it shouldn't
> be exported at all.

It seems we need local:* to achieve this behaviour.
Few other libs are missing it. I plan to send a patch for them.

> So I am not sure if this exception is required, did you get
> warning for tool, or is this theoretical?

It is not theoritical, you can check with objdump:
objdump -T build/lib/librte_common_mlx5.so | sed -rn 's,^[[:xdigit:]]* g *(D[^0]*)[^ ]* *,\1,p'

I did not check the ABI tool without the exception.