From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCF9AA053A; Wed, 5 Aug 2020 22:27:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 130651BFFE; Wed, 5 Aug 2020 22:27:18 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 22B5D2C23 for ; Wed, 5 Aug 2020 22:27:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id DEA4B30D; Wed, 5 Aug 2020 16:27:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 16:27:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= u2Dk1gXpE1h587vQJpkQORHYRqXpesMEnmdl8VDMfIA=; b=e4A57nG6M3vTlvfK 3FgrCghhS6ke+K+fKL0ZGdefpmxHWxDZaLamuIvZqpw4Sl+I8692CbveAr7DOIc7 3+TTKc+CdnflVeg6uHRiRCHN+9WeoX1IpfFSqn7CcnzRmtmPcHVPQkXEckJk2Wss WoVAcKkjMLaAHwZuwaWs72x0yNHTXkcVeUPWr/2kJPjkgetnzW4hvM5wOuDSWrfu 2OyD7I0Cd7xXwu+7DetIY9HfSIdr26umvAOVBOabhOa0B2TjwW5zyw/QejRc8mrd 5q1EEHFkJivR0zcIE1MVYDDlKOlkgZINFsy736i+yK/YZd3gOl7nPnwEVz9BpeRX K2hhIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=u2Dk1gXpE1h587vQJpkQORHYRqXpesMEnmdl8VDMf IA=; b=KB7ZkbJJQz23AqeZo3iIKSyiRJc6zHEHJ5T8XnPRj+MuZEAsTAfylp2lZ X7SL+l8Y+VbvqkxZxovirU2/+3cyIXOKIn384SxJKc7hxB/Ivt7j9EU/fwBzZz0O 05v8rbnO9kHAa6ThviVjG4Ftzn8Uhgur4yDDfrjQazwHNdl//m1iA14JxMBtVnxi UnsvlcSmKf9ETMESsn482/vykvsV8qhq4aDcYAMwLMhHeguaFNlOGas/vf6m2fv5 6IzRkdYFlUIP5eD6F+LfEvuj8xmbtnGWQD+VPwnXvjaM6rh5eAqgW3+CqO62Xiu6 0iPa2cmju/of1S6HrfdvREf9yPPdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 908FE30600A6; Wed, 5 Aug 2020 16:27:12 -0400 (EDT) From: Thomas Monjalon To: Somnath Kotur Cc: dev@dpdk.org, ferruh.yigit@intel.com, Venkat Duvvuru , Ajit Khaparde Date: Wed, 05 Aug 2020 22:27:11 +0200 Message-ID: <3405053.XWxjWNVelI@thomas> In-Reply-To: <20200731172302.5292-4-ajit.khaparde@broadcom.com> References: <20200731172302.5292-1-ajit.khaparde@broadcom.com> <20200731172302.5292-4-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/bnxt: fix cleanup and check for ulp context alloc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/07/2020 19:23, Ajit Khaparde: > From: Somnath Kotur > > Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor > init is aborted if parent ulp context is not initialized. > Also check for the same before creation of port default rules. > Additional checks in VF rep dev ops for proper parent dev initialization Looks like it should be separate patche. I don't know what is "ulp", but if it an acronym, it should be in capital letters. > Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") > Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init") Not clear it is a fix. Looks like adding more checks. > Reviewed-by: Venkat Duvvuru Reviewed-by should be below Signed-off-by. > Signed-off-by: Somnath Kotur