From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DEA9A034F; Tue, 11 Jan 2022 13:48:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29863426F8; Tue, 11 Jan 2022 13:48:13 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 157EB411AE for ; Tue, 11 Jan 2022 13:48:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 894203201DA0; Tue, 11 Jan 2022 07:48:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 11 Jan 2022 07:48:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= lzc10GmUErcfTre7E+ldTr5M19LXYnYPV0pzC4ntwCE=; b=FkHurZH5X+Vy1r/V RcSNgi1ZPbmV7QKFZxfGH2fT3e5cjpWxCms4T2WNzJK+RlWxNeyPLf6K6HvKKwFQ K2KGNtEy8pkVrwIGqaqG6hrfjTq33nHKQWuYvkffiKfq1eNCznxGMk6VCAOHXbjX Q3B8qBn3TL5+PL1Dh1oQFkWXBpfuvyu5B7UVm0l9biDXo8arvA6mnrAMVSDK/N8N jw8dvC7QSJd43T2Dl9L1J/JwOuFGIHnSPCS00rqvTTtUNSvPiZIcSixpEbWWYuY8 coaiNf3yH/W24VIBk0W5stKDGZCtFexSTQrfWwv4FqI1VyP0WG731GSyVzKhK56y 5SoZvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lzc10GmUErcfTre7E+ldTr5M19LXYnYPV0pzC4ntw CE=; b=BCnadMANWRW31qGS52FTIBGw6U8XpLjOCLEBUDoYQiPW5mr8vlGrE/gcA AwTrMqLTEOhLu45YvX8tcCpZvjajV7UW1MQ+0+LmCzmE7OZ0oD2nm7nC8ChuL1Ds fTo7SWdEhVkZk8gn7FYtWzigigQzmn/easHDUobBp122axSXr7whKiJmVJnwblh9 1ewCF2hbuX/hWSVpFL23fja3yErHAtuRMcYEj1bj3RLAYH3Wwh/OtW+KkUGqT9LD KmcjG72DoQHD2+J1RpOk6W+Pk3KvCHG8Ja3Un9rI39AF9GLTyVWu4Le3b+UjMpmE iwd6dUqX68vQoMvmk++w7YP9mgf8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudehfedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jan 2022 07:48:08 -0500 (EST) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Subject: Re: [RFC] ethdev: introduce ethdev dump API Date: Tue, 11 Jan 2022 13:48:07 +0100 Message-ID: <3408456.iIbC2pHGDl@thomas> In-Reply-To: <20220111115437.32855-1-humin29@huawei.com> References: <20220111115437.32855-1-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please use --cc-cmd devtools/get-maintainer.sh so all maintainers are Cc'ed. 11/01/2022 12:54, Min Hu (Connor): > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -55,6 +55,12 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > + * **Added the ethdev dump API, for query private info of ethdev.** > + > + Added the ethdev dump API which provides functions for query private info > + from device. There exists many private properties in different PMD > + drivers. The information of these properties is important for debug. As > + the information is private, the new API is introduced. > A blank line is missing. Also please check the comment above asking to start the actual text at the margin. [...] > +typedef int (*eth_dev_dump_t)(struct rte_eth_dev *dev, FILE *file); There is a dump function for rte_flow: rte_flow_dev_dump(). This one should have a clear scope: private device infos?