From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2CD73FA8F for ; Thu, 9 Feb 2017 18:37:43 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP; 09 Feb 2017 09:37:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,137,1484035200"; d="scan'208";a="63170520" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga005.fm.intel.com with ESMTP; 09 Feb 2017 09:37:42 -0800 To: Ben Walker , dev@dpdk.org References: <20170209164006.72040-1-benjamin.walker@intel.com> From: Ferruh Yigit Message-ID: <340ab2a6-8065-7413-2a28-38fb383f7bd9@intel.com> Date: Thu, 9 Feb 2017 17:37:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170209164006.72040-1-benjamin.walker@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] Fix overwriting of dev_flags in rte_eth_dev after initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 17:37:44 -0000 On 2/9/2017 4:40 PM, Ben Walker wrote: > rte_eth_copy_pci_info no longer sets RTE_ETH_DEV_DETACHABLE > as per my previous patch, but it still does initialize > the dev_flags. In a number of cases, a later assignment to > dev_flags to set RTE_ETH_DEV_DETACHABLE was overwriting > the previously initialized value. > > Pointed out by Michael Larsen. > > Signed-off-by: Ben Walker Thanks Ben, A patch already sent for this: http://dpdk.org/dev/patchwork/patch/20248/ (indeed two: http://dpdk.org/dev/patchwork/patch/20163/) and applied to next-net: http://dpdk.org/browse/next/dpdk-next-net/commit/?id=ae94e2a23b5 Thanks, ferruh