From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 447DB41D3C; Wed, 22 Feb 2023 13:41:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 260B840693; Wed, 22 Feb 2023 13:41:03 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id D748F40689 for ; Wed, 22 Feb 2023 13:41:00 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id F3F73320097C; Wed, 22 Feb 2023 07:40:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 22 Feb 2023 07:40:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677069657; x= 1677156057; bh=W9yfCjDnmmKsyxEmpiqz8scJI4Lz5NpVj8frVsA3jPg=; b=f QVzCNsA0PdVXFR/2KQWAMDeHldiEQxv6BLyelv+jnzDgw60n3UzsdfGauB0cWaWC 5cI3rnMAPvh7526HXcn8C87cQ9fAvTeFAp8hrOrZXt4i3SIEhTeHv+k7OZfcN7A8 t0OsbxOSzNOFohaYzpJnJxRNfzZljvN4XkOQS+7aCvB0BavifU/771UAaThpm5dl BI/mGTzPTp1M2nDh3IuJCLfIqYlfOyhVUeB4yzGH5ihvb5ByEk+ZObxPXlfBDfvs cH43NChy/6XXXFnhQrZYAFJLYv+ezgQbjsOH1VrAJHFROydLwGdXxY6zOKBgL8hs 33BXHIGUn/LOzLsI/rMhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677069657; x= 1677156057; bh=W9yfCjDnmmKsyxEmpiqz8scJI4Lz5NpVj8frVsA3jPg=; b=Q gJdNxl2LiRkDsdI1aPRdwwawuYqWXkgCKZbclwTCtGqmvqJNQ0K2FBvO8uvoAx1R sfgI034ZytORDyc8RmYyG5cuosLuZq7GiO1PG1VHDbwIJ6+i5+BqhA1Hn/lL9BOX bsU+0A1+7DDGyS4nQe+SctlBgf4MYOr7F/0gRCCacZgnoOQMpC6ABxXq82Uw41OW LT3oXvTZa6rSNUodDLsDjUWG0MDSSnKngTYv+EsU6eecAnXVCn7FI25tM8+jALVe gE1aEZ5/jR2Xq0GgI2/v3/+ntYZDeGU0BrMOdMq7+Ygw2s5Cyp271dPJV5KUO5zI 0Z9K9M8HgIPpf/VsnOHmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejledggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Feb 2023 07:40:54 -0500 (EST) From: Thomas Monjalon To: olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, Kamalakshitha Aligeri , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: Yuying.Zhang@intel.com, beilei.xing@intel.com, bruce.richardson@intel.com, konstantin.ananyev@huawei.com, Honnappa Nagarahalli , Ruifeng Wang , Feifei Wang , david.marchand@redhat.com, dev@dpdk.org, nd Subject: Re: [PATCH v2 2/2] test/mempool: add zero-copy API's Date: Wed, 22 Feb 2023 13:40:53 +0100 Message-ID: <3410602.WBkqHH8m98@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87768@smartserver.smartshare.dk> References: <20230209062501.142828-1-kamalakshitha.aligeri@arm.com> <2080056.htQpZWrp2x@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87768@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/02/2023 09:24, Morten Br=F8rup: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, 22 February 2023 09.01 > >=20 > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > > Hi Thomas, > > > > > > Do you want me to squash the unit tests in the mempool lib patch or d= o I > > have to wait for the reviews from mempool maintainers > >=20 > > Yes I think you can do the squash if Morten agrees. >=20 > Yes, I agree. And if there are any more changes required before the code = is accepted by the maintainers, I will let Kamalakshitha make those changes. >=20 >=20 > How should the different acks/review tags be handled when squashing two p= atches into one? >=20 > The library patch has: >=20 > Signed-off-by: Morten Br=F8rup > Acked-by: Konstantin Ananyev > Acked-by: Chengwen Feng > Acked-by: Kamalakshitha Aligeri >=20 > And the test patch has: >=20 > Signed-off-by: Kamalakshitha Aligeri > Reviewed-by: Ruifeng Wang > Reviewed-by: Feifei Wang > Acked-by: Morten Br=F8rup The cleanest is to remove Reviewed and Acked-by and let reviewer check agai= n. About the sign-off, you keep both. About the authorship, you must choose one.