From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 545E9A0032; Tue, 12 Jul 2022 16:04:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 445284280D; Tue, 12 Jul 2022 16:04:13 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 336BA400D4 for ; Tue, 12 Jul 2022 16:04:12 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D654C5C018B; Tue, 12 Jul 2022 10:04:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 12 Jul 2022 10:04:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1657634650; x= 1657721050; bh=8dr43YC2BCUDmoPpZDsJsurnjXmQVoA54VWkhkzoDt4=; b=a cVH6CQaLXywMHhm9EzrOz4QNaYZxU7tXeZuk6HHfSf4jOtvx3HoKmLSbiYd8pMDY 5eTS1NBDZ4Tju7Cu8upj2LeXOftTgO0c/VQre/kC3YcfxEshbIQpJwLdEk/6+Jkr 1XPtvcJgnH/yQR0ZtnkdlhKAW7TJwM8d4ZnnEJ+7MITEjgm/P/gfgj/rNZAzYbWK 6geukhW3F+OsbFfXJeeeRh0/CFi2PTBBOViPH2Re4vzaxHj8mbGKgEv6DqMMoZqy Z3py3gLN647TYQLiyDFLtfYJfFjAdOEwdt5NyyrNEuIxr/RjBtyAgqKv5nkammly EY56BWEs91veIXlRc7MQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657634650; x= 1657721050; bh=8dr43YC2BCUDmoPpZDsJsurnjXmQVoA54VWkhkzoDt4=; b=W ZP4JkfNlQXwtEdSYKTps2GPgZ57l705NwK/xDNIICNKp+zNthquJbmRxJy/NX4VV pbskopQ5wGYB+ZTGW7igeasxtiqtQqv1O/sHeW05JiRutbM3IKPvhSOBTYruT+Bv YmZcIRbfZJBUMhJOTHui/aN+WoLbJ6jGManAKVP6exRyGB/61YsMa0PjdVtBOYs5 YjJ1gc5nL/++8zF9myT1WXlJOh7TgEoidcjPdHa9AtxMlAJ0Yu4p7FlSp87fhdVx +l17/4Pv6zXUgqVkzi4FFu7dbOl5ysaL1D2abdxUc1hM+CfZmRLqa6H2ORHclUi6 FNBkh/HmwJnu0Oq9xkGUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejhedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Jul 2022 10:04:08 -0400 (EDT) From: Thomas Monjalon To: Satha Koteswara Rao Kottidi Cc: Andrew Rybchenko , Ray Kinsella , dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, ajit.khaparde@broadcom.com, jerinj@marvell.com Subject: Re: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api Date: Tue, 12 Jul 2022 16:04:06 +0200 Message-ID: <3410736.z0yIoBN5P9@thomas> In-Reply-To: References: <1656689558-27482-1-git-send-email-skoteshwar@marvell.com> <74f0f801-46a9-c407-e6df-ccd48ac1d817@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/07/2022 15:38, Satha Koteswara Rao Kottidi: > From: Andrew Rybchenko > > On 7/1/22 18:32, skoteshwar@marvell.com wrote: > > > +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` > > > in Mbps. + This parameter declared as uint16_t, queue rate limited to > > > 64Gbps. +``rate`` > > > + parameter will be modified to uint64_t in DPDK 22.11 so that it can > > > +work for > > > + more than 64Gbps. > > > > I fully agree that uint16_t is not enough, but I'd like to understand the > > reason behind uint64_t vs uint32_t. It looks like uint32_t is more than > > enough. > yes uint32_t is enough, proposed uint64_t so that the rate in TM shaper profile is also uint64_t in bps I don't see how both are related. Why not stick to uint32_t for this parameter? Also I'm not sure it is breakage. If it was, it could have been handled with function versioning. But anyway it is a small change, I am OK with uint32_t.