From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 8A4D86CC3 for ; Mon, 20 Jun 2016 15:54:27 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id v199so70330237wmv.0 for ; Mon, 20 Jun 2016 06:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=f4DvTbz1pMmc4GcqSTnLFeI9BwExcnhwYpstaXWLPGc=; b=vpGjZfO/I+lASQD4WgsqbsmdY2QA0XpT4u75H7tvQbuB8Ze2T/CNn85DUMGuqRtGpP bqN40GCGLwBixySVToY8PPbrEMlXMmM6YBnG4l0rGA2I0HqZ7j/kBrYDDxVLes+swXfB 5tRdF7guHb0bnjjF0RM7dy0fKZfQTE2yQ2Q50Y029gyJjX4ombY2T2ZnuaZ5tNDfFTKs 64GpspP8GNcpt3hb91sNGNj5rWU/SkemYSJFFQp/k/pFavALWGfuGgisB0Wk4bVxOV8i UP+ODBa7T8ct+B5mSu/Z/i4ZY3sKseyIkvShmnmZInWu6sGEikZzMmXEPq6BL4e+U1u2 tgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=f4DvTbz1pMmc4GcqSTnLFeI9BwExcnhwYpstaXWLPGc=; b=VCn1Rnu0lhkeJOuGhAPcLupqf5RHzmWQG5204YxcXThhEPBJJILDPEW18V7XiBlQOj TpaFcQ7riFkZzYQPjTIF6GJJyH3vNqH2ae7x7bv2aDwnpcYT4l8i5lxOQ3bEziitfyH+ 6i2HPbDBFldB7PSv/OECk2n0jql18busxdp4Euv9t2AkoL0Nqntw3c+qjT4hfbvNStIh mnzc/znVl9K4GnGGwM94W3oHHTRAzyTITGSZS39c02uR/pLnFeaDFz8pCXBkCROEahdd FWit0rJWrKluuUshrA5IhZrwc1GSmNWRQEd50/zWopANz0mRpV+mj2EsCYcMyZ/H5L8W XIpw== X-Gm-Message-State: ALyK8tJAqmvmTXMS0Sv8du/dUJycCnHBooNoadqoDRSoYQvL3Mf01aWSPoxuhOqS+Ev8/DVP X-Received: by 10.28.197.132 with SMTP id v126mr10880537wmf.8.1466430867257; Mon, 20 Jun 2016 06:54:27 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v200sm13761413wmv.4.2016.06.20.06.54.21 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2016 06:54:24 -0700 (PDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, David Hunt , olivier.matz@6wind.com, viktorin@rehivetech.com, shreyansh.jain@nxp.com Date: Mon, 20 Jun 2016 15:54:20 +0200 Message-ID: <3416153.NDoMD8TpjF@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160620132506.GA3301@localhost.localdomain> References: <1463669335-30378-1-git-send-email-david.hunt@intel.com> <1466428091-115821-2-git-send-email-david.hunt@intel.com> <20160620132506.GA3301@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 13:54:27 -0000 2016-06-20 18:55, Jerin Jacob: > On Mon, Jun 20, 2016 at 02:08:10PM +0100, David Hunt wrote: > > This is a mempool handler that is useful for pipelining apps, where > > the mempool cache doesn't really work - example, where we have one > > core doing rx (and alloc), and another core doing Tx (and return). In > > such a case, the mempool ring simply cycles through all the mbufs, > > resulting in a LLC miss on every mbuf allocated when the number of > > mbufs is large. A stack recycles buffers more effectively in this > > case. > > > > Signed-off-by: David Hunt > > --- > > lib/librte_mempool/Makefile | 1 + > > lib/librte_mempool/rte_mempool_stack.c | 145 +++++++++++++++++++++++++++++++++ > > How about moving new mempool handlers to drivers/mempool? (or similar). > In future, adding HW specific handlers in lib/librte_mempool/ may be bad idea. You're probably right. However we need to check and understand what a HW mempool handler will be. I imagine the first of them will have to move handlers in drivers/ Jerin, are you volunteer?