From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 15D621BABE for ; Thu, 12 Apr 2018 10:36:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7A425219DC; Thu, 12 Apr 2018 04:36:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 12 Apr 2018 04:36:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=JGum/p8TV2DtTgu4e9owEmxfFA usnh2dYtwo1kgn+lM=; b=gY9PyU3uVCP79hX+crYuu2Og0zJQ4zF4tpzkwKSnmU iFUvCdkeBPWYqz3b85dyyyMoBRuFFLbYebcKzBWan1rTCvkJgaPXdYJ4DcDlFvoz zuVyibeUC7JQBpQjxyvVhblzrmqY3Ee/XboB95LlHChLgJwqP+KkBYyWfS8EAwOF A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JGum/p 8TV2DtTgu4e9owEmxfFAusnh2dYtwo1kgn+lM=; b=BPReMOvsdDz2TDoonMWyT/ 7zLaCQk6tj46S2IRofNJ2hV7WwVSooYTCEzgprcHO14uwnDrAg6rqkgZaenRt2Ru ccWaHuH++pbjlJpEjxOCGQZL61xiKRAFTFzRIJuv/x8111SWRZWa468u9WAYNkps Kt9gNl4jzLR1+OTMy5S8GTH9T1L2c/EK8V2v/TW6BtVmOun7kYnQ3HuwROiFdJIY uyxFZgUXTYsLrrjv8ATUTI2agOsTKPEmdgz5HBzV6ALQNWI121J3flL6e7bHLozo 22tmW55Vfgykt7elVRJHVhI6rmUG4dgW1LKOfqFjBVHgsoXlFGqv/NBx/5fOciCA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B4928E43BE; Thu, 12 Apr 2018 04:36:23 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, motih@mellanox.com, harry.van.haaren@intel.com, jianfeng.tan@intel.com, shreyansh.jain@nxp.com, helin.zhang@intel.com Date: Thu, 12 Apr 2018 10:36:22 +0200 Message-ID: <3416717.nsP6q0ReyN@xps> In-Reply-To: <1522986902-13059-3-git-send-email-jia.guo@intel.com> References: <1522944617-16601-5-git-send-email-jia.guo@intel.com> <1522986902-13059-1-git-send-email-jia.guo@intel.com> <1522986902-13059-3-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V21 2/4] eal: add device event monitor framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 08:36:26 -0000 06/04/2018 05:55, Jeff Guo: > v21->v20: This is a very high number of revisions. I cannot see them in my mail client because they are too much nested and indented in the thread representation. Tip: when sending a new revision, it is better to thread it with the first revision, so we do not have an infinite nesting. > --- a/doc/guides/rel_notes/release_18_05.rst > +++ b/doc/guides/rel_notes/release_18_05.rst > +* **Added device event monitor framework.** > + > + Added a general device event monitor framework at EAL, for device dynamic management. > + Such as device hotplug awareness and actions adopted accordingly. The list of new APIs: > + > + * ``rte_dev_event_monitor_start`` and ``rte_dev_event_monitor_stop`` are for > + the event monitor enable and disable. > + * ``rte_dev_event_callback_register`` and ``rte_dev_event_callback_unregister`` > + are for the user's callbacks register and unregister. > > API Changes Please keep 2 blank lines before the title. > +/* The device event callback list for all registered callbacks. */ > +static struct dev_event_cb_list dev_event_cbs; > + > +/** @internal Structure to keep track of registered callbacks */ > +TAILQ_HEAD(dev_event_cb_list, dev_event_callback); There is a compilation error with clang: lib/librte_eal/common/eal_common_dev.c:37:33: fatal error: tentative definition of variable with internal linkage has incomplete non-array type 'struct dev_event_cb_list' [-Wtentative-definition-incomplete-type] static struct dev_event_cb_list dev_event_cbs; ^ > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -258,5 +258,9 @@ EXPERIMENTAL { > rte_service_start_with_defaults; > rte_socket_count; > rte_socket_id_by_idx; > + rte_dev_event_monitor_start; > + rte_dev_event_monitor_stop; > + rte_dev_event_callback_register; > + rte_dev_event_callback_unregister; > > } DPDK_18.02; Please keep the alphabetical order.