From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7F0C31B192 for ; Thu, 21 Sep 2017 12:36:58 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 03:36:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,425,1500966000"; d="scan'208";a="902527673" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 21 Sep 2017 03:36:55 -0700 To: Zhiyong Yang , dev@dpdk.org Cc: thomas@monjalon.net References: <20170909144727.46388-1-zhiyong.yang@intel.com> <20170921083243.57991-1-zhiyong.yang@intel.com> <20170921083243.57991-2-zhiyong.yang@intel.com> From: Ferruh Yigit Message-ID: <341cb310-5446-62c4-ec3a-f6c914ae2471@intel.com> Date: Thu, 21 Sep 2017 11:36:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170921083243.57991-2-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI versioning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 10:36:58 -0000 On 9/21/2017 9:32 AM, Zhiyong Yang wrote: > There are two bonding APIs using ABI versioning, and both have > port_id as parameter. Since we are already breaking ABI, no need > to keep older versions of APIs. > > Signed-off-by: Zhiyong Yang <...> > -int > -rte_eth_bond_8023ad_conf_get_v1708(uint8_t port_id, > +rte_eth_bond_8023ad_conf_get(uint8_t port_id, > struct rte_eth_bond_8023ad_conf *conf) > { > struct rte_eth_dev *bond_dev; > @@ -1409,10 +1320,6 @@ rte_eth_bond_8023ad_conf_get_v1708(uint8_t port_id, > bond_mode_8023ad_conf_get_v1708(bond_dev, conf); I am aware this is not focus of the patchset, but it would be good to rename this function too and remove _v1708 suffix. It seems there is already a function named "bond_mode_8023ad_conf_get" and after removed code, "bond_mode_8023ad_conf_get" only called by "bond_mode_8023ad_conf_get_v1708": bond_mode_8023ad_conf_get_v1708() bond_mode_8023ad_conf_get() So it is possible to merge them into name "bond_mode_8023ad_conf_get()" Thanks, ferruh