From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19036A0509; Tue, 5 Apr 2022 17:51:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAB0F40F35; Tue, 5 Apr 2022 17:51:13 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 853A040DF6; Tue, 5 Apr 2022 17:51:12 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C1F6C32009DF; Tue, 5 Apr 2022 11:51:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 05 Apr 2022 11:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=SfFEPzkp70Rezc AIkIuMtC7991bJTna1lTzu4RMWDZY=; b=C4b5qF5P/n1qeNpxO2bkFOvTetPYNF TERM/N4OvgSl11n2HGSermxGZw+yJNucfik5KmBu3EE9lcO12pXhQvvJFjn56wu7 WuzyVK2npOT2zwtcWy+3tHhxK5bmLzUL+SJymJ5pphZ3vGX78CNU3cK49nN4CNTx J63QTK1fW7L0Fiu7uZ6h5V5dr4UD0SocLOdehWMh3kQDQLti187wQuzmWVc1yVi3 RmLZU1h1AyAF3mGIUIk58/EbkdspYnTwi4hB5nyAqz/7mM3RUPbhU17QWLE8LFA4 1iyzXV+0+QDPXAHe0MIP0GgM1nAsm7Z2CoA2douTzTx6whfaCuoDkHmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=SfFEPzkp70RezcAIkIuMtC7991bJTna1lTzu4RMWD ZY=; b=Tko+asCRpjm3YMEUuCG4Te89TrMIEJinEOFc77zJqMH5rLRM6rUd44nuB 4TZpMdRSEgUVHjBhkc1hafLXgdMv9sLt/cB/6HX4EHAIp021YhitwdtWiFpYKI77 3BcTucdgQB2DbTOuEjXryS95/fh4Pj+fSNvlxa/o/NhmppxOHuV45wqZSy/EfQkL GYFz75P64hHIkuZXvaAHZKqFfQ7o5YiO6PSdFHF5Z/PN7r86VDODvKvI7MrKtIaX WyfDWSDgI4kB9IOixkOZmnroB6OTYgEy/F4R4kg0FDFTxf8sctxEEqFE8GKZw/fm 1NRQDiK9G6KuvasHsJuQRaBdEFb2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejgedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Apr 2022 11:51:06 -0400 (EDT) From: Thomas Monjalon To: Ben Magistro Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= , dev@dpdk.org, ben.magistro@trinitycyber.com, stefan.baranoff@trinitycyber.com, stable@dpdk.org, Luca Boccassi , Christian Ehrhardt , "Xueming(Steven) Li" , Kevin Traynor Subject: Re: [PATCH] mbuf: expose outer vlan in mbuf dump Date: Tue, 05 Apr 2022 17:51:05 +0200 Message-ID: <3423184.iIbC2pHGDl@thomas> In-Reply-To: <95d923da-0216-9a66-2713-17f0a6442a0c@redhat.com> References: <20220404005634.2657-1-koncept1@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D86F9B@smartserver.smartshare.dk> <95d923da-0216-9a66-2713-17f0a6442a0c@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/04/2022 12:33, Kevin Traynor: > On 04/04/2022 07:15, Morten Br=F8rup wrote: > >> From: Ben Magistro [mailto:koncept1@gmail.com] > >> Sent: Monday, 4 April 2022 02.57 > >> > >> Enable printing of the outer vlan if flags indicate it is present. > >> > >> Signed-off-by: Ben Magistro > >> > >> --- > >> > >> While troubleshooting some QinQ offloads with various Intel i40e > >> firmware[1], it was > >> helpful to expose the outer vlan in the dump mbuf calls. This should > >> be straightforward > >> to backport and happy to do the work if accepted. I understand that > >> this may not be a > >> widely supported capability at this time, so we are okay if this is not > >> accepted and > >> we just maintain a local patch. > >=20 > > Features are usually not backported, only bug fixes. > >=20 > > However, since this patch proved helpful finding a bug, and it is very = simple, it could be considered by the LTS maintainers. >=20 >=20 > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is=20 > requested for stable branches. It will be caught by stable maintainer=20 > filters when it is time for backports and can be discussed further then. I think it is a bug. What was introduced first? the function or the field? Please find the commit where it should have been done and mark it with "Fixes:" syntax + Cc:stable.