From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16E8FA0032; Tue, 12 Jul 2022 14:26:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A891F41109; Tue, 12 Jul 2022 14:26:46 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D6394400D4 for ; Tue, 12 Jul 2022 14:26:44 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 534E95C00BF; Tue, 12 Jul 2022 08:26:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 12 Jul 2022 08:26:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1657628804; x= 1657715204; bh=2yBxVOElEbLNJrh41aCJmFauc6dCq3cP5KN9KaRGbFs=; b=T 3LidVrYonytO1DuZAUujb41Pfwz27a5Pn2sH6cwZYn4GDVoVAE8/n+yxFWVzhAZw R8F8PRIJw40PaQmjAwzeq80ZajreqTpMFFqRFRzZmAzBNUaVYNoLHEY6gxm9m1+5 PHTSaGaqDBzs5e2fgP+/4371XeVR7lv/wXg7itjLsSRrdYk2gSzxrP/hZnxfuee9 Rn61VzLPEYUIksKdnIJekSbEmkZvTNm1PKw9zvjVIk5uGiIFWqmIu9tETexFgBbd W4B+idzPgT3NQ/Ocu52zIpcjFgxPLFR0FHT/4R4CDZJsVyAUoyhGCiQgXYuU2vPv E81perilM7syOB8YjokvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657628804; x= 1657715204; bh=2yBxVOElEbLNJrh41aCJmFauc6dCq3cP5KN9KaRGbFs=; b=p kXXPE+T3jF4Y/2YX/Y65cSUELLKXDH0LHnS4tsw+WkO7fI8uBXOnjz7K/T3Wv9AY FNAnCMkypzurGyvXUjEOKEge52beFElqSdfyzJcQin4c72lbrkFy8mKwu2PLjQB/ YPrbA1kcl7JppKzQum/LDeQcl79HN0xmWbP+7EMP4JLIKrYHXEnmF52Eb/uRlvWo 6WtaP2zld4HoIex/gnFL2/mSY5+MNV1PIR/3zscagQnwpeKxfBjPLI0TSby2FMeA 85OJdFAKj7KGy2qcDwDG9dSDizEp/athJSwMLeTRu5crcIBaKxIAVDKdT3EmCXZu M4b6MvpYgQY0+JkklnG2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejhedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Jul 2022 08:26:42 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin Cc: dev@dpdk.org, ferruh.yigit@amd.com, david.marchand@redhat.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, chenbo.xia@intel.com, ktraynor@redhat.com, Ray Kinsella , xuemingl@nvidia.com, matan@nvidia.com Subject: Re: [PATCH] doc: announce transition to vDPA port close function Date: Tue, 12 Jul 2022 14:26:40 +0200 Message-ID: <3424161.GA8KThiCzi@thomas> In-Reply-To: <1022991b-c3e5-1b1f-f713-f4769e6ca4e5@redhat.com> References: <20210518073441.2749096-1-thomas@monjalon.net> <1022991b-c3e5-1b1f-f713-f4769e6ca4e5@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/07/2022 11:16, Maxime Coquelin: > > On 5/18/21 09:34, Thomas Monjalon wrote: > > There is a layer violation in the vDPA API which encourages to destroy > > a full device with rte_dev_remove() instead of just closing the port. > > The plan is to introduce a new function in 21.08, promote in 21.11, > > and deprecate rte_vdpa_get_rte_device() in 21.11. [...] > > +* vdpa: The vDPA API should not try to manipulate or export > > + any ``rte_device`` object, which belongs to the bus layer. > > + The function ``rte_vdpa_get_rte_device()`` will be deprecated in 21.11, > > + when its usage will be replaced with a function ``rte_vdpa_close()``. > > + The new function should enter in 21.08 and get promoted to stable in 21.11. > > + A port close function will allow to close a single port without destroying > > + the rest of the device. > > Maybe there was some changes since you posted the announce, but I don't > see why rte_vdpa_close() would be needed. It seems the only user of > rte_vdpa_get_rte_device() is the internal vDPA example, and it only use > it to get and print the device name. You're right, it was an oversight. So we need only to get the rte_device name. I propose to replace struct rte_device *rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev); with const char *rte_vdpa_get_name(void);