From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 754FEA0C41; Thu, 4 Nov 2021 14:58:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40023411C9; Thu, 4 Nov 2021 14:58:33 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 9C7A9411A4 for ; Thu, 4 Nov 2021 14:58:32 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4E2CE3200907; Thu, 4 Nov 2021 09:58:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 04 Nov 2021 09:58:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 8y4mERhNqYGHpEWhzH1Aq1x4w6TEFOSdhYkfUHroM9k=; b=ataa8Knd6mSxe6iK k5k5GjbMFiCDByeKY6lIzvELNWesjXelcNKHV7+Y3vjKWdBJxGbODtXP8EPxjEw2 f0ou2W5iCYbVDFdZTezV16a4S3/D3dHUjY5oqLdFLuRfvA4iEK4VQq06AFLlSbQX gFzuj0+GL2vfbKgL/Y7QJZdKEPqXAgF/f/NRbFXC8+gVMCo7Q9pB8Pbmd9c5B/7y yBIdCLkCmKmiiPIT+TZy1sSPtH5SNxO7HJqIxcLLfmU53LqMlavKGkz8SrTydSHi hzY1phluo0ZlXWnM5oAWkbVMBbRbwl8yfY4/1VXuf38Gkm+JsnYcEPv+gQ7CZyy0 kyixng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=8y4mERhNqYGHpEWhzH1Aq1x4w6TEFOSdhYkfUHroM 9k=; b=fop7PcY2U2xO7qhjZWQGyTJdFB0uKPaexQh3UeUyUyXN24m0iJB5PSaeB kERoYGLVBbv7Tj2vbx+beFlTeEXOPiPKNbAu//+UmPi5hm3+6DTMofv5kulvgELx ABBby0Wdh/AmAfejBqjMA2lpDiaRMYnCDOh+bWzKBfKwtsuQukp59JQ9kfA9JpwD 4WKJMT5m0glLrXz45BPZ9CvOr6QQgwcrZjWSmSOSUe3bF3XrATTptf7Xwc8XuFac 71ocviEyCQtSQWfprO+82UJlhRwvmZ6Y1fazljzrMgT7kC7ATgD3SZEjf4kcelMy 4cqeHoBUX+92UxVk+xWAUfPyxiI8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeggdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Nov 2021 09:58:29 -0400 (EDT) From: Thomas Monjalon To: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, Wojciech Liguzinski Cc: dev@dpdk.org, megha.ajmera@intel.com, "Liguzinski, WojciechX" Date: Thu, 04 Nov 2021 14:58:27 +0100 Message-ID: <3424746.7aQOyVHj5L@thomas> In-Reply-To: <20211104110335.491723-2-wojciechx.liguzinski@intel.com> References: <20211104104918.490051-1-wojciechx.liguzinski@intel.com> <20211104110335.491723-1-wojciechx.liguzinski@intel.com> <20211104110335.491723-2-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/11/2021 12:03, Liguzinski, WojciechX: > From: Wojciech Liguzinski > > Implement PIE based congestion management based on rfc8033. > > The Proportional Integral Controller Enhanced (PIE) algorithm works > by proactively dropping packets randomly. > PIE is implemented as more advanced queue management is required to > address the bufferbloat problem and provide desirable quality of > service to users. > > Tests for PIE code added to test application. > Added PIE related information to documentation. > > Signed-off-by: Wojciech Liguzinski > Acked-by: Cristian Dumitrescu > Acked-by: Jasvinder Singh > > -- It should be 3 dashes to make the below hidden in git. > Changes in V23: > - Coding style fixed > > Changes in V22: > - Coding style fixed > > Changes in V21: > - Coding style fixed > - Patches reorganized according to comments > > Changes in V20: > - Removed API conditional compilation > - Added flag to indicate cman enabled/disabled > - Fixed submitter data in patches > > Changes in V19: > - ACKs included in patches > > Changes in V18: > - Resolved merge conflict in lib/sched/meson.build after rebasing ontop of main > - Reverted whitespace change in app_thread.c - comment from Stephen Hemminger > > Changes in V17: > - Corrected paragraph link naming in qos_framework.rst to fix CI builds > > Changes in V16: > - Fixed 'title underline too short' error in qos_framework.rst > - Applied __rte_unused macro to parameters in rte_sched_port_pie_dequeue() > > --- > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 64 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > lib/sched/meson.build | 3 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 254 +++-- > lib/sched/rte_sched.h | 64 +- > lib/sched/version.map | 4 + > 12 files changed, 1860 insertions(+), 104 deletions(-) > create mode 100644 app/test/test_pie.c > create mode 100644 lib/sched/rte_pie.c > create mode 100644 lib/sched/rte_pie.h Adding this change to include the new test in sched library maintainership: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1428,6 +1428,7 @@ M: Cristian Dumitrescu M: Jasvinder Singh F: lib/sched/ F: doc/guides/prog_guide/qos_framework.rst +F: app/test/test_pie.c F: app/test/test_red.c F: app/test/test_sched.c F: examples/qos_sched/ Cristian, Jasvinder, I didn't see a lot of comments from you on this patch, so I assume you are OK with this change.