From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20F34A00BE; Thu, 10 Feb 2022 22:00:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9E87410E5; Thu, 10 Feb 2022 22:00:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 032324013F for ; Thu, 10 Feb 2022 22:00:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644526836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m/nkP1lUtUUiCrY5Gm0uHvsgGjCxrvgpyoydieVh2vY=; b=Jfac1zXVg4wKBV96fmwU5bSVO1MBBIFP14hzMiWeF8VasjACfM8zXtJUnED086lyFx7rRs DR0Zz5CsED4ruRMB61RDf6KaP07kR6MODVgAYLphbzu2jpZTjvGa0IF8mBgevyw8+I4uhO vtCQxcnHQTiwMm9ZcJs6Q7debelXURo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-k8doKVyNNua7C47a_b7mXA-1; Thu, 10 Feb 2022 16:00:31 -0500 X-MC-Unique: k8doKVyNNua7C47a_b7mXA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1A4546861; Thu, 10 Feb 2022 21:00:29 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5DFB4E2A3; Thu, 10 Feb 2022 21:00:25 +0000 (UTC) Message-ID: <342f8ca7-5370-d845-8eb3-5acdc0ca2545@redhat.com> Date: Thu, 10 Feb 2022 22:00:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path To: Ferruh Yigit , Jiayu Hu , dev@dpdk.org Cc: i.maximets@ovn.org, chenbo.xia@intel.com, xuan.ding@intel.com, cheng1.jiang@intel.com, liangma@liangbit.com, Sunil Pai G References: <20220208104031.1885640-2-jiayu.hu@intel.com> <20220209125145.1918050-1-jiayu.hu@intel.com> <20220209125145.1918050-2-jiayu.hu@intel.com> <6a43fe5a-a0d8-7723-c569-b64c2529b444@intel.com> From: Maxime Coquelin In-Reply-To: <6a43fe5a-a0d8-7723-c569-b64c2529b444@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, On 2/10/22 21:56, Ferruh Yigit wrote: > On 2/9/2022 12:51 PM, Jiayu Hu wrote: >> Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA >> abstraction layer and simplify application logics, this patch integrates >> dmadev in asynchronous data path. >> >> Signed-off-by: Jiayu Hu >> Signed-off-by: Sunil Pai G > > Patch gives a build error with './devtools/test-meson-builds.sh' [1], > for the minimum build test [2]. Sorry, I didn't run this script, and so didn't faced this issue. > This seems because new header file (rte_vhost_async.h) included by > 'buildtools/chkincs' and it is missing depended includes. > > > Fixed in next-net by adding the includes [3], > please confirm latest patch in next-net: > I agree with the changes you suggest. Thanks, Maxime > > > > [1] >        19 In file included from > buildtools/chkincs/chkincs.p/rte_vhost_async.c:1: >        18 > /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:18:19: error: > expected ‘;’ before ‘int’ >        17    18 | __rte_experimental >        16       |                   ^ >        15       |                   ; >        14    19 | int rte_vhost_async_channel_register(int vid, > uint16_t queue_id); >        13       | ~~~ >        12 > /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:19:47: error: > unknown type name ‘uint16_t’ >        11    19 | int rte_vhost_async_channel_register(int vid, > uint16_t queue_id); >        10       |                                               ^~~~~~~~ >        9 /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:1:1: > note: ‘uint16_t’ is defined in header ‘’; did you forget to > ‘#include ’? >        8   +++ |+#include >        7     1 | /* SPDX-License-Identifier: BSD-3-Clause >        6 > /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:31:19: error: > expected ‘;’ before ‘int’ >        5    31 | __rte_experimental >        4       |                   ^ >        3       |                   ; >        2    32 | int rte_vhost_async_channel_unregister(int vid, > uint16_t queue_id); >        1       | ~~~ > >        37 In file included from > buildtools/chkincs/chkincs.p/rte_vhost_async.c:1: >        36 > /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:95:24: error: > ‘struct rte_mbuf’ declared inside parameter list will not be visible > outside of this definition or declaration [-Werror] >        35    95 |                 struct rte_mbuf **pkts, uint16_t > count, int16_t dma_id, >        34       | > > [2] > meson  -Dexamples=all --buildtype=debugoptimized --werror > --default-library=shared -Ddisable_libs=* > -Denable_drivers=bus/vdev,mempool/ring,net/null > /opt/dpdk_maintain/self/dpdk/devtools/.. ./build-mini > > > [3] >  diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h >  index 11e6cfa7cb8d..b202c5540e5b 100644 >  --- a/lib/vhost/rte_vhost_async.h >  +++ b/lib/vhost/rte_vhost_async.h >  @@ -5,6 +5,11 @@ >   #ifndef _RTE_VHOST_ASYNC_H_ >   #define _RTE_VHOST_ASYNC_H_ >  +#include >  + >  +#include >  +#include >  + >   /** >    * Register an async channel for a vhost queue >    * >