From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5553A00C2; Fri, 11 Feb 2022 19:39:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D94194068E; Fri, 11 Feb 2022 19:39:24 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 8071540140 for ; Fri, 11 Feb 2022 19:39:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644604763; x=1676140763; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=OGE4uMpNL9rvfR8fElQ0971OT+kh2sD9xMXHa8UuB0c=; b=WhM2GaVpt0FiR8bzBDaPZjDXG0v3xNhiB6VFXRX2cyGyiftaC2pkg+m2 MmOU9WXbhQyCHj0l8Wu6ayNAZovj4+Ugi+uJVpaniZYIb8b3Q91RGAPu7 GsvnU9IzRD7hXYoaBlovvEbQomme42T6W0pL0MWAXTPdQhBcAjuM5s+QM Pt4skc0TuVTkF5iq663QfSbmevvqpoq3vl07F36e+cgbhFLXd9RqIY6x2 ktkZOQN6utJm8/JQ/jO44Bk82NVNzQgI48c7VtTyfPxpfhEGDU0KommnL gD80Bx9VYD+/bDgNCkV7RCfzp45DToMgUXB1SUZaaX3fd0a672Bt/f6Nr g==; X-IronPort-AV: E=McAfee;i="6200,9189,10255"; a="249733892" X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="249733892" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 10:39:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="527050907" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 11 Feb 2022 10:39:22 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 10:39:21 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 10:39:21 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 10:39:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOf9ID9Y9kg3b12dRs672W29PMOxyEJ03ksZ1rLVPjYRCZ2W04KKdNkYq0KTYGwz75ZkYq5wJnE6or9N7u0et6MVLnK79F3piKoDRR9uEX9JijMVL74fB33CKjXogieSa+EzCx/xoNRXhQB4YqPRq2zQlpRUgQouegPhj9N4wPjLTk51tJcB2M9JAIQMPFdnKgf2ZPx4NxjD9a7e16b0Aqvc4QFtQBiFU4ORcVl+1/l6Km5MQ5Cn+PQrHhyCuMZlmMKlTvocf47XUkfF3kb+eh6lscrJFm/lyhTFJS2sx4pygNaAnJoxnhKbbRntO5I0v7VPSw4ZJjenXpnybPreDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gINVf66yIPdCnGrJ+/p0Ju3kPVh49CgV6im7RHrkC1w=; b=FZUofJGq+YscC9NvV7d9Kr5L0OEnBIq5ARt/NlDT7nxmPCFwUJswJy+vfx6rFrDcC/QNsEldE1TdDNG96uDr3StKDStZsuMTfTjPKyc69JqAYw7k1MBXloFc2mBcaX3ABOHfdtoF0cuHllcru/Tk52huj93GkU5bmYXVgbJ08ooR+rXP1gKMmPQV4x3qaB06mzlNn8pwTzknKTm5LbOKGfchzfFqnHHW0flJAvRa9nd48ncnCiKDSlOPLACYEpt1sXoQdE0Nih0PNXl6VwsZ4WjG5wecTlOQfuG9nJ/Ew1m46cy99o0mQsuXXbDo4J89EZBQN/8q5qwxfucCNKqSnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR1101MB2356.namprd11.prod.outlook.com (2603:10b6:404:9c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 18:39:19 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 18:39:19 +0000 Message-ID: <343048ac-f104-a27e-d165-2a96cd180c1d@intel.com> Date: Fri, 11 Feb 2022 18:39:12 +0000 Subject: Re: [PATCH v3 2/2] ethdev: move driver interface functions to its own file Content-Language: en-US To: Thomas Monjalon CC: Andrew Rybchenko , Anatoly Burakov , References: <20220208194437.426143-1-ferruh.yigit@intel.com> <20220211171441.2717010-1-ferruh.yigit@intel.com> <20220211171441.2717010-2-ferruh.yigit@intel.com> <2267345.BjyWNHgNrj@thomas> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <2267345.BjyWNHgNrj@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0485.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b14b5ab6-eb1d-49e2-1925-08d9ed8dd019 X-MS-TrafficTypeDiagnostic: BN6PR1101MB2356:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ydLejJujbEqP7Sj1XYqCtLykXuRzTpR19WBffzSvbVyRlZmwrD02V26NAn+af6tS7VBIndtFL/NboXW+d3tjAC9+F9kk41o26NQ3Sf9v06CZ3PuPdUo3i6O8HPyARtQRNE3f/FLVlCz6yG51BWTLuQ8wAsdLsjrFjfVUzM3UxIulTQUgMHdNeak6LwC/pbIsBKZGD1CsSO2XV/1UUl4K3E9KaEb9Ptru3//UNG7ifjQ8ut2E0m0Yat/XAeRqdVEW+4RKDiJYptXb1yeTYsHHV9grzxLGi+Fskju4vcHqvzNX1MrRJbEGD6yXcOiXftvAy6OOkmbDtSUIsyvKK2WrozpNkuLu1H6sAEpE8KDUCUEigDSYfnk8eJ55H3XR6wejSsu409EmbfLuwHWtqstQjIE8zYKgewbe3/zL0c4YWVBCPDsdvCrg15HlmTAejHkMlrMQ/L5UxCQ9CDSQON4X5ZjUCCmA+/a7bVksQQG8fnZARHdtuG1iwhfUlU+M7pvbPCNr4RRhLlZiZTSlEa96d3IrBQwzSh4FdHy8Uy03uCUDBMR5qR+TgMSCo9kNd9M1mIw9TOsaKMfMLC6BCxEt8Khfoo7QBrW1zvHkeUHpDknSPDgLiIHCKVOjFwNH2t+BHiVENvkEGYwlMnY7sKZauYgK4rVOo39ky9y9zIF9jQmTWU6/UNbnscppvKedef8pTJKgtCJVrT0Fs89sk8Rhpw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(86362001)(316002)(31696002)(6666004)(6506007)(83380400001)(54906003)(55236004)(2906002)(82960400001)(36756003)(6916009)(53546011)(66476007)(2616005)(6512007)(4744005)(26005)(186003)(508600001)(38100700002)(44832011)(5660300002)(4326008)(6486002)(31686004)(66556008)(8676002)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGR5SVF6VVVYSWpoR1ZISjIyNEkzSE1aRkx3MzJsU3lGS1dRaXFvdTZhTTgv?= =?utf-8?B?dytGaUJncU9FNjNUWHhnOGpEVDhldTZsdElVU1pMU0taSDkzbTVRcUZFUVZH?= =?utf-8?B?UnpZb0QwK3hMdVJ2RFNjYm9vdEEwZmExK3RiTEc5eGg4aVFwc25zcFlLUjBj?= =?utf-8?B?R092NzMzdWsvbFFaOXRaUjI1Vm1zYy92bi9Yb1dzTk9PanFaQWhNWmlORjJU?= =?utf-8?B?amNRU0xMRkhhSVBIRmRWWDdpU3hwR1FOb1lpNVI4M0JTS1lPU1Q5a2MwcDhE?= =?utf-8?B?VHEwVFpzb2xWNmRPZ3k3VVg0NjBTVTZVZndON01NWUkvK3lxS1ZLYm5PVTFs?= =?utf-8?B?MFF5VWt4WWEzclVkNnlhUkIydmx6RVdsbWs3NWZ0UVhRZ1N4dmhGeUdKdU1M?= =?utf-8?B?dDdPK0d3Y3cxb3poVk5PU0E4aWNBWWN4VTBqWGNqWXpGYytYV3VXeU5Oa0k1?= =?utf-8?B?MHlSOGVieXBCZERMc0QzUjVrRW1jOWR5aXBXWEdOTXY4bjJnR1Y3TmROc1I0?= =?utf-8?B?Y3BZMlVoVmNtekt4VDRBeEpGM1dMUHNZS2NFNi9yNUVTRk5FaWtGbVJIUnRm?= =?utf-8?B?aFRmTW85NUVGSTZnMko3aUR5VzZSSDFNVXUrdmxBeXNsdmljYUgyd0t4T0t5?= =?utf-8?B?Z3d5MEdJZDQvQ1cwcHU3cDFFQVVNSnk5NGQ3SU1SbmFaeWtKaS8ybkZPdk8y?= =?utf-8?B?eUVmWjhkWXF2U3VGUmVoWndaQm41cE1PMy9uVTdTZFJQNGtVemVHeS9IblZt?= =?utf-8?B?ZWFjeFhtWTcwT0UvVGdaQSs4eDV1b2dvTVNwbU1XVVFnK2JtVWR2VkxpUEV3?= =?utf-8?B?YUdxc2lXR3Q5Q2lFZUVqSlE5NkcrZWdwR1pTVGpHcFdNT0lwKzdnVW84NFZ1?= =?utf-8?B?T3c1c05kNy9Ic0RMQ3dPaEhVNUxsSERNMmYwem40RHhWa3FJR2pYclE5aE1q?= =?utf-8?B?Q0lZZ0dPTGJuSFlubGhNOWdlbEp6Z1VqRk96T0RGMU5qNkRHRG1ESkNIZFpq?= =?utf-8?B?RW83N00rL2pxYlMzTzVvbnNWTHdjZ0t0ZlM1TEE3Q3I3SzJESTl2d0YwOWhz?= =?utf-8?B?UmlScm5mNC9kendENGhCUHEyVFcxWXVZZ1JPbE9iRWVHMkVPb0JjZlJTQ2tR?= =?utf-8?B?YjNLQ2RicWZYTHhsZzM4cXFpRDFPcHNUNCtNVE5PVzFicHpKM29taVIzN2Ey?= =?utf-8?B?eUx3WGVmWjkrT00wZ0Y1UXpuTDlJYjUzRmlKVFZUL2NGVlkvbFFWMyt0aHJH?= =?utf-8?B?Tm1QSE0wY21WSG9NVlRzQmphMGtDQ3ZQLzFFem5XbmpYekt2emxHZm1jT2pR?= =?utf-8?B?S1hFYUtQWlZwdis0WFh6NkNiRThVTmFGRk1Hejd1Q3V3TmdXTjVLWGtFRVVM?= =?utf-8?B?c3hqVngrN3RGNEZ4cWQxUXQzZzhpcGJTcHJ5Nzk1NkFTaGVRMU13b05MK2Nj?= =?utf-8?B?L1EyRDNiZCs2YWtQUVIxdE0vMmJLWUN2MFowMURiTVI4RUxHeStGOUNkeDBn?= =?utf-8?B?eUhNYUJ5SmxMdXZGZEg0b3ZTTURYWHJLT3dQaVgzcVYwSnNrNGprckducXNo?= =?utf-8?B?Uitka0ZRTU1DVUdSZmJpajQ4VHg0US9lUyswUVRzc241czR1T0EyWllRZTRV?= =?utf-8?B?dnFiM29xMm43ZmgwY29pWUR5YjlQREcvTFNLcXhLdmd2dDA5SGxGTUpsZHZo?= =?utf-8?B?WXRRR0tFbklmeVNCUW81Y1ZtMENmWnBFMjVsQWdNb1VNbHZhUFJVaEpVa3ph?= =?utf-8?B?Rk9RUitMWUtyOC9wdW9YQ09nWUpJTFB0LzRBbitJREpIbG5GVlZ0Ym5oLzRL?= =?utf-8?B?a1huOTQ0ZDBmOFNmUmFiZStOam1IK3g0Mkp3dXViTElyNlhUZ3BOUk13eHov?= =?utf-8?B?ZWQzNDZiZWYyYVYrdmx0TmJUMHVxMWNzSDFIZm54UlEvazlja1JpcGxmVjZ0?= =?utf-8?B?dUNIckZyTlF5dm1UZjVKWkpIQTFnOTkwdWhKUnBOSFViVk1sTjc4c0h0aUtP?= =?utf-8?B?R3NiL2xseTk1Y0UzTmNkdU5WV1hqTk9pQ3NPZ1A5Y3BGampTYXdCQWtQblUx?= =?utf-8?B?WE0zdC9YaHJMbks0aVFKdU1FVHNMdHlQZzRxUTRVS1QrSy9tMExGWFVQNW5V?= =?utf-8?B?OXg1ek52TzFUZTVhQityMWxKZUpIOWZBM0xvUlFNRTlvRm03T3IxakVGalhj?= =?utf-8?Q?afkh2sSfeS/iACSVKKki7TA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b14b5ab6-eb1d-49e2-1925-08d9ed8dd019 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 18:39:18.9144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GwQuTGB6DTZiVD73+TkpkX1cHZE1YmmhooabkURvo3bhM6yQEaY4iRfJmjziowVWJPTb9Px6UP6zdNNi55cKww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2356 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/11/2022 6:09 PM, Thomas Monjalon wrote: > 11/02/2022 18:14, Ferruh Yigit: >> Relevant functions moved to ethdev_driver.c. >> No functional change. >> >> Signed-off-by: Ferruh Yigit >> --- >> lib/ethdev/ethdev_driver.c | 758 ++++++++++++++++++++++++++++++ >> lib/ethdev/ethdev_private.c | 131 ++++++ >> lib/ethdev/ethdev_private.h | 36 ++ >> lib/ethdev/rte_ethdev.c | 901 ------------------------------------ >> 4 files changed, 925 insertions(+), 901 deletions(-) > > Please could you add more details in the commit log while merging? > We need to know that they are internal functions used only by drivers. > Also it would be interesting to explain the difference between > ethdev_driver.c and ethdev_private.h. > I put some more description in v4, can you please check if it is good? > With this info, > Acked-by: Thomas Monjalon > >