From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 808C91B3A9 for ; Wed, 28 Nov 2018 13:51:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4E2A48DD; Wed, 28 Nov 2018 07:51:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 28 Nov 2018 07:51:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=OX5kGjCRmmzjcnsBVCgIZKp8kYnxmkoegyRuwKaiWKY=; b=CkhY5Lmp2k8P 6z71q/bTQGYT3KmaOe9XWr8SoBBbPIoYcq1yzCZ+KoLwMerODOmeCabwZLQVBEdH OjRS5OAXAGiZJ+52ezelFYxfGaR/fZFyQ8wmZ/EV6TXyplT+ktrUtf/UQs8UW3wY 4FY5g+tmWBtr7ksHdsJeiqCS5H0rIiY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=OX5kGjCRmmzjcnsBVCgIZKp8kYnxmkoegyRuwKaiW KY=; b=d4dg6Xj8J6HvslC4QYpFaSH8f+TjDF74Aip0L8uIcaC5fpGjxMsQd72Se cC1ztoDiXGFMIi1qE7HXMlANYqkOfzc6LXkSPdyGkCiNeORmG34XZpEpsm14pqjK mnXhvXZAQfbQhvrkuZA0ilIM8mO72Nl6tjLKhppXdxiZgwBVz++tsBcKJUa8XfwA CuqdejOcR8zS1yf4Ssut435LXpuTygafuhfpH1nuHG8WALckVOWi8UPAO2/ZoD+o SQDOvTqMUkoNGzL2e7ahJmTb6vYU6HRrPywzUYcTmY3jCklo43Yiv4mYIdSEQLEU AZLxsPq/QyXwQVOCjgrJERtoDTg3w== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A16D4E405B; Wed, 28 Nov 2018 07:51:40 -0500 (EST) From: Thomas Monjalon To: Eelco Chaudron Cc: dev@dpdk.org, David Marchand , cristian.dumitrescu@intel.com Date: Wed, 28 Nov 2018 13:51:39 +0100 Message-ID: <34321981.0ZahcR99rh@xps> In-Reply-To: References: <154333204294.44971.12989297399338053044.stgit@dbuild> <3306361.jWiN20gDd9@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] lib/librte_meter: update abi to include new rfc4115 function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 12:51:43 -0000 28/11/2018 13:40, Eelco Chaudron: > > On 28 Nov 2018, at 11:09, Thomas Monjalon wrote: > > > 28/11/2018 10:27, Eelco Chaudron: > >> On 28 Nov 2018, at 9:38, David Marchand wrote: > >>> On Tue, Nov 27, 2018 at 4:22 PM Eelco Chaudron > >>> wrote: > >>>> --- a/lib/librte_meter/Makefile > >>>> +++ b/lib/librte_meter/Makefile > >>>> -LIBABIVER := 2 > >>>> +LIBABIVER := 3 > >>> > >>> As far as I understood the policy around the EXPERIMENTAL section, > >>> you > >>> don't need to bump the library version. > >> > >> Thought I would add the new function as none experimental, i.e. next > >> version, but checkpatch did not allow me to do this. > >> > >> Tried to find info on what the right process was, as these functions > >> are > >> just another meter implementation using similar existing APIs. If > >> anyone > >> has any background on this please point me to it. > > > > It is documented here: > > http://doc.dpdk.org/guides/contributing/versioning.html > > > > The case for "similar API" is not handled specifically so far. > > So you need to introduce it as experimental. > > Thanks for the clarification, will update the APIs with > __rte_experimental in the next iteration. You should also add this on top of the doxygen comment: * @warning * @b EXPERIMENTAL: this API may change without prior notice