From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F2AF61B58D for ; Tue, 18 Dec 2018 13:38:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 889972215E; Tue, 18 Dec 2018 07:38:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 18 Dec 2018 07:38:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mkIOlnBlFYMkgBtoS9hLpNFsSI18Q/13uYO0IwUv2uo=; b=DMfVSauvUodz cei1rgo1b66MsorQCwHCOOmV/ytNRvsURSQRb8YdQHa3drT5dNM4eUalNz+S4idR D2A/vxOfeCI9zQtbYYvo7Thk0zEXpJWroqSNVt5SyryZfk+LC7e6l/nZ4dqchZSO r8E16odyrYRirKDRGvH4WR/SabYxU8c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mkIOlnBlFYMkgBtoS9hLpNFsSI18Q/13uYO0IwUv2 uo=; b=PPZ96u92FSpWHdHJa9WvlvA5OyBZ2+IgPzQU4jGUCqDmPsFcgpMYSVBXS JbKGR5IIixKjomQp7m/6Z6XMOBsC0pfUxN998zBwkGmdz/WKXCS/C3haphQMgHqd UdxnJvCGxu2c7NDC3OcF1H2+ZgbcyD00F+6Mp9YTV+GHb7rxV6dpXsjCiiuOvImn DBl/RdWdyYIc9spDwgyNXoWWi3PTT0qL5F/zIn6+F718DEaJANhRholvICxBVJg5 JtMUkBLDHFclRiFogmAI5EYm4bXMLCfmGaS0aJj/3iEIPQ4svyFfpxO29YRES/Rh Vt3fySgyD5SickjxKtRdlAlTIwuNg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeijedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8901DE4384; Tue, 18 Dec 2018 07:38:13 -0500 (EST) From: Thomas Monjalon To: "Dumitrescu, Cristian" Cc: "Pattan, Reshma" , "dev@dpdk.org" , "Ananyev, Konstantin" , "jerin.jacob@caviumnetworks.com" , "Singh, Jasvinder" , "david.marchand@redhat.com" , olivier.matz@6wind.com Date: Tue, 18 Dec 2018 13:38:10 +0100 Message-ID: <34337288.XBznk5NxM7@xps> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E81658C@IRSMSX108.ger.corp.intel.com> References: <20181123165423.134922-1-jasvinder.singh@intel.com> <1646379.j0tofnCs90@xps> <3EB4FA525960D640B5BDFFD6A3D891268E81658C@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 12:38:16 -0000 18/12/2018 12:18, Dumitrescu, Cristian: > > > I replied in v3 that it should stay in rte_meter.h. > > > You can include rte_meter.h in ethdev. > > > > OK, thanks Thomas, makes sense to me as well. > > > > Thomas, > > I agree with your input, but just want to make sure we are on the same page: > > Besides including rte_meter.h in ethdev (which you are fine with), we would also need to include rte_meter.h in mbuf. > > Are you OK with this as well? Why do we need rte_meter.h in mbuf?