DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: pbhagavatula@marvell.com
Cc: dev@dpdk.org, jerinj@marvell.com,
	Phanendra Vukkisala <pvukkisala@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection
Date: Tue, 26 Nov 2019 23:55:20 +0100	[thread overview]
Message-ID: <3439238.TMZgjuWe3e@xps> (raw)
In-Reply-To: <20191102142316.750-1-pbhagavatula@marvell.com>

02/11/2019 15:23, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Some kernel modules use '-' in their name when registering through
> `pci_register_driver` and the same name  is populated in
> '/sys/bus/pci/drivers/'.
> But the kernel always populates modules names replacing '-' with '_'
> in '/sys/module/'.
> 
> Example:
> 	# ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0
> 	Error: Driver 'octeontx2-nicpf' is not loaded.
> 
> 	# ls /sys/bus/pci/drivers/octeontx2-nicpf
> 	bind  module  new_id  remove_id  uevent  unbind
> 	# ls /sys/module/octeontx2_nicpf/
> 	drivers  uevent  version
> 
> The patch addresses it by always replacing '-' with '_' when looking in
> '/sys/module/'
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied, thanks for the clear explanation.




      reply	other threads:[~2019-11-26 22:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-21 18:16 [dpdk-dev] [PATCH] " pbhagavatula
2019-10-27 20:20 ` Thomas Monjalon
2019-11-02 14:23 ` [dpdk-dev] [PATCH v2] " pbhagavatula
2019-11-26 22:55   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3439238.TMZgjuWe3e@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).