From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 00199FAEA for ; Mon, 27 Mar 2017 15:13:06 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id j90so20760394lfk.2 for ; Mon, 27 Mar 2017 06:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=IYDtDc0LfTSCFNlgdw5Dy7GAN3lM7OA6yqEGLIAj1Z4=; b=jF5aHmuNx7VBuvjq3PuxLp/aPmRAgUgL7r129Oqo8ivPWy7gHEKzR5RnmfsdXN7+Hi QLZKMIdjgkBk3Qf1K4oYmFu/KhAU1dWcIPpNl4cYLFCYu58SZHX/4vSJRYf7f2/QxMPT UY2g+4akOREBHpq/IjAc4e201FDUCN7flHegLnPQTcVuL/FfpwVfIZ053J71n7UEg5z4 uy7nJ03nCDpsaXXG2jXtXQWGKMYPSj7N9iEuwpxzXS7QbVgQ+GKFncatcKxMCFWj9bn7 38UMHvw2E6dtrB0fQ86AomsqK2zDDhLQwD4VIJ81Tp0wT0Pa0HPFG2bvz6mJlxGFtIko ZUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=IYDtDc0LfTSCFNlgdw5Dy7GAN3lM7OA6yqEGLIAj1Z4=; b=TNTOFyHSXKcqrgTYGTAEANprgeM/kUGKK/Y6DeyTSNXKZzfVqbXX4TOzLzLiIg9+FA s4Pc9rddKKL54wDKIYZ+uReAzUySPTl6uYUU++aAiKhAzaiUpyuYFdjGdyMV26OIwqFB /TEbVcMRXlIID/CiLHJWhJR1phDzImbg2PWPN9Ux+bzlsYbe8pSWtu6GDJhLhLGfbCXH tU9+ykDGIQlCoPDWJYzL+JLpb3+V3F0KZFf5RCkqVxynQ3Z4xMCsBYOey6RXwqDdYKLw CPC7F5Eq47TG2jAVbwih2zC3zFdIogM6hcd3wAaTdFebdXwgdsvUuTfPPt0trBN4PWCc +POA== X-Gm-Message-State: AFeK/H2lW6mcha9rBw8Y0cxCo2mqZvbVwK125Lo21aBtyMD2IL+s6OFQnXmL6HF2GkW7HVnl X-Received: by 10.28.170.67 with SMTP id t64mr9566447wme.18.1490620386192; Mon, 27 Mar 2017 06:13:06 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 53sm666058wrt.52.2017.03.27.06.13.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 06:13:05 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com Date: Mon, 27 Mar 2017 15:13:04 +0200 Message-ID: <3439297.P6JfIMhuDO@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170327101549.GB18148@bricha3-MOBL3.ger.corp.intel.com> References: <20170307113217.11077-1-bruce.richardson@intel.com> <2476675.J1ds0gYDs0@xps13> <20170327101549.GB18148@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 13:13:07 -0000 2017-03-27 11:15, Bruce Richardson: > On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > > 2017-03-24 17:09, Bruce Richardson: > > > The size and mask fields are duplicated in both the producer and > > > consumer data structures. Move them out of that into the top level > > > structure so they are not duplicated. > > > > > > Signed-off-by: Bruce Richardson > > > Acked-by: Olivier Matz > > > > Sorry Bruce, I encounter this error: > > > > fatal error: no member named 'size' in 'struct rte_ring_headtail' > > if (r->prod.size >= ring_size) { > > ~~~~~~~ ^ > > > Ok, I think I've found it now using git grep. I assume this is in the > crypto code which is disabled by default, right? Right, sorry for forgetting the context.