* [PATCH] vdpa/mlx5: refactor with common interrupt management API
@ 2022-07-05 13:44 Spike Du
2022-07-05 18:17 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Spike Du @ 2022-07-05 13:44 UTC (permalink / raw)
To: matan, viacheslavo, orika, thomas; +Cc: dev, rasland
Replace vdpa interrupt handle creation logic with common interrupt
management API.
Signed-off-by: Spike Du <spiked@nvidia.com>
---
drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 25 ++++---------------------
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
index ed17fb5..607e290 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
@@ -492,30 +492,13 @@
mlx5_vdpa_virtq_doorbell_setup(struct mlx5_vdpa_virtq *virtq,
struct rte_vhost_vring *vq, int index)
{
- virtq->intr_handle =
- rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
+ virtq->intr_handle = mlx5_os_interrupt_handler_create(
+ RTE_INTR_INSTANCE_F_SHARED, false,
+ vq->kickfd, mlx5_vdpa_virtq_kick_handler, virtq);
if (virtq->intr_handle == NULL) {
- DRV_LOG(ERR, "Fail to allocate intr_handle");
+ DRV_LOG(ERR, "Fail to allocate intr_handle for virtq %d.", index);
return -1;
}
- if (rte_intr_fd_set(virtq->intr_handle, vq->kickfd))
- return -1;
- if (rte_intr_fd_get(virtq->intr_handle) == -1) {
- DRV_LOG(WARNING, "Virtq %d kickfd is invalid.", index);
- } else {
- if (rte_intr_type_set(virtq->intr_handle,
- RTE_INTR_HANDLE_EXT))
- return -1;
- if (rte_intr_callback_register(virtq->intr_handle,
- mlx5_vdpa_virtq_kick_handler, virtq)) {
- (void)rte_intr_fd_set(virtq->intr_handle, -1);
- DRV_LOG(ERR, "Failed to register virtq %d interrupt.",
- index);
- return -1;
- }
- DRV_LOG(DEBUG, "Register fd %d interrupt for virtq %d.",
- rte_intr_fd_get(virtq->intr_handle), index);
- }
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vdpa/mlx5: refactor with common interrupt management API
2022-07-05 13:44 [PATCH] vdpa/mlx5: refactor with common interrupt management API Spike Du
@ 2022-07-05 18:17 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-07-05 18:17 UTC (permalink / raw)
To: Spike Du; +Cc: matan, viacheslavo, orika, dev, rasland
05/07/2022 15:44, Spike Du:
> Replace vdpa interrupt handle creation logic with common interrupt
> management API.
>
> Signed-off-by: Spike Du <spiked@nvidia.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-05 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 13:44 [PATCH] vdpa/mlx5: refactor with common interrupt management API Spike Du
2022-07-05 18:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).