From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3F71245B69;
	Fri, 18 Oct 2024 17:13:52 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0C04A4025F;
	Fri, 18 Oct 2024 17:13:52 +0200 (CEST)
Received: from fout-a8-smtp.messagingengine.com
 (fout-a8-smtp.messagingengine.com [103.168.172.151])
 by mails.dpdk.org (Postfix) with ESMTP id 1BA2D4025C
 for <dev@dpdk.org>; Fri, 18 Oct 2024 17:13:51 +0200 (CEST)
Received: from phl-compute-12.internal (phl-compute-12.phl.internal
 [10.202.2.52])
 by mailfout.phl.internal (Postfix) with ESMTP id 97EC9138038D;
 Fri, 18 Oct 2024 11:13:50 -0400 (EDT)
Received: from phl-mailfrontend-02 ([10.202.2.163])
 by phl-compute-12.internal (MEProxy); Fri, 18 Oct 2024 11:13:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm2; t=1729264430;
 x=1729350830; bh=l4WkfLcvWO8DVJSNVh9zzaUJdZPqnt1MKYpRO0g/lLo=; b=
 EAGv9WBurb3aV5jBqAq0hhP4zEL6Zj+mwyjlC/E+dh2mxabHXDEaxRAMKpCAIFMt
 4l1LenKXq08kzF/As+cDRHdolNt4283pyOHTjbBUw3sIfW/nmtFfipqQg+fAKUtE
 jZ5Fc0DxRUCrHEoN/DSat5FfBk9eXBQC9mCfy/ugs8G2LtLLIpYKmDbAO09R3gR+
 NE/u700jRlU01ZvqxvJVBSKeOwgvquyolBZfAw/eP8ZJSOM+KxKzikbvK3EOyEE2
 lQ+np8upWiw0auM8ejsm1LjU7UPglid9VktcZMcPRIInXj0xUZm6a0s41Uc48X5a
 h5Mwo7HGR5E/88nQtp7Xcw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729264430; x=
 1729350830; bh=l4WkfLcvWO8DVJSNVh9zzaUJdZPqnt1MKYpRO0g/lLo=; b=D
 1XtuJc3U2R+QKj9MTvnsB0PddpD3bDwFtYSDnpvwPqaCM7Z0IUzphmRcRhfqhMS9
 fH/+1+P61Zuw44cO7AzcvaDkaoqAPr0TBnm6GSv/I0kELx3BSSCfF1CK+zSpVm+g
 EfhZR2IAsWZh4vhwo0U6RT6J8IBNHSxlbdNARLEHAq2YLTX2o1q3X4nmRL8lHZ9z
 nIKYHvbL8knfzyo1H8N7QdqArcklSqVeB5Q9OPy0FJt4bhF1KhYor8bFO7r+bFsI
 vfDxtJyWaUfwztkijCDAsio0bnPr9rz2WyKwdJxlpZZE9XRPr5orskaUNLUbwxho
 HVE42qT/ifmVIuGSD4EgA==
X-ME-Sender: <xms:LXsSZ-8_40Yvs3Of2ytKYRzt3ykBvvZy18dt6eW9Q4iCtdzFGhUy9w>
 <xme:LXsSZ-sOfdQqLdHvF4XNwBQ2WsLCpWNK4-kvPy5uQW4YWzMkPebY2oWjh_XRXPSGn
 jLcHezaS987DXM2Jw>
X-ME-Received: <xmr:LXsSZ0DUqlbUndl-h4RAXwUntJOp7AWlpV3Pud9nsGBuWu1JpcCtjcCxHK3GRCLXryYBpRaWdW3ZGt9V2DpNxz3NTA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehfedgkeegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
 rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
 htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen
 ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg
 hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejhfejteffgfevteejueetudehtddt
 geejleduhfdtgefhleduteefgedtudfgheenucffohhmrghinheprhhftgdqvgguihhtoh
 hrrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho
 mhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepiedpmh
 houggvpehsmhhtphhouhhtpdhrtghpthhtoheprhhjrghrrhihsehrvgguhhgrthdrtgho
 mhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhopegrmhgrnhdrug
 gvvghprdhsihhnghhhsehinhhtvghlrdgtohhmpdhrtghpthhtohepshhtvghphhgvnhes
 nhgvthifohhrkhhplhhumhgsvghrrdhorhhgpdhrtghpthhtohepfhgvrhhruhhhrdihih
 hgihhtsegrmhgurdgtohhmpdhrtghpthhtohepmhgssehsmhgrrhhtshhhrghrvghshihs
 thgvmhhsrdgtohhm
X-ME-Proxy: <xmx:LXsSZ2dLUdFtf7rOFSsTNvZawAEeYKUywchZ-alc20jjLFyHXF2X2g>
 <xmx:LXsSZzNpkzpaisWD9DAg2zH3QumkPajJEFu8K-Cx8HAkdsHfjnj8eQ>
 <xmx:LXsSZwk5MheKzS1QCIGmNLYjKkX4srSLPFEQLocz7KADkWfldOTnHQ>
 <xmx:LXsSZ1vwidQGh9DyPpwhTCSzMf4y72cpmpAKXu0DnKNUAY0TdiAPSQ>
 <xmx:LnsSZ_B-7AmXyUpyiDMBOPGw1MIeNRTfBgMyv5Qo9bQKmgcGyiC_mrkY>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 18 Oct 2024 11:13:48 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Ferruh Yigit <ferruh.yigit@amd.com>,
 Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>
Subject: Re: [PATCH dpdk v2] net: add more icmp types and code
Date: Fri, 18 Oct 2024 17:13:47 +0200
Message-ID: <3439960.0oRPG1VZx4@thomas>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F7F6@smartserver.smartshare.dk>
References: <20241017083322.2166467-1-rjarry@redhat.com>
 <20241017224152.36412-2-rjarry@redhat.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F7F6@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

18/10/2024 02:39, Morten Br=C3=B8rup:
> > From: Robin Jarry [mailto:rjarry@redhat.com]
> > Sent: Friday, 18 October 2024 00.42
> >=20
> > Add more ICMP message types and codes based on RFC 792. Change the
> > namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow
> > differentiation
> > between types and codes.
> >=20
> > Do not include deprecated message types as described in RFC 6918.
> >=20
> > Link: https://www.rfc-editor.org/rfc/rfc792
> > Link: https://www.rfc-editor.org/rfc/rfc6918
> > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>=20
> Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>

Highlighted the API changes in the release notes,
and applied, thanks.