From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26E29A09E4; Fri, 29 Jan 2021 09:57:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3D71240116; Fri, 29 Jan 2021 09:57:07 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B552A40694 for ; Fri, 29 Jan 2021 09:57:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6475D5C01F2; Fri, 29 Jan 2021 03:57:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 Jan 2021 03:57:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= N62n3u3dlH/9nykvga7jYRM1vdYP7/N4AaSGY8CwOOw=; b=3pWY6kTCYTzjGF4Y zJnA2GravPj/wO9Va3dE6GuJzQAPsDbB3u1/Y5Z5aFsCqPAoVaMmA2I6DKU73uap OGACGpUUIl71jrf1XjDsgE0mJiRUHG5oPW88YvfMxN4wn/gj81rmN8if4kkKTmvw VXLccT8BEAuA2ssnCP8Q4jiB/cJ2Z1+j3ih7mdqUzGzRU5JUdk5yslMb2n2iD8do 6/3qon5jaAgVP96HVnFv30s9I09y8qocdwDozm3TFrx//wosBEWaiYt54i8C1Jlf DvG0tSwDJgY0KrnZvQnwSxSrGq0J553XhrL1+HfIxHeSsTtZrPsfzWhqJY+Jk5NM 2ioiOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=N62n3u3dlH/9nykvga7jYRM1vdYP7/N4AaSGY8CwO Ow=; b=fiYShHYidM+04BDGmfKm8tjGkH4nFUlHeFCykr/zVwFjVqBWIPNFkBcAM DX1G8V2SGg5B4GLHNsDDAW6A3uG43wtgVQdwcmptzhQtCkZt95tn1qS1HmJvDtL6 +v0bpp94DX8MveMLUX0CMtFWsuxVRwtdm9oPg/13BPCjVnguOYYlNiGqHTHPpp2c MzwzUNJrRlxrQ9KHi7cKCqEd4qp0bg8GIFejsjvGg/G31mqt4N9UY1o2pJXw513g 55u7iYKPeYsKJvuuW0M2MBS0FtIvDfnWFdw1yoL65e3Khakd2Ue97kUxczUzmRKi uiaNkPAG9WSCTSyhxTGcIfH9yzIyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedugdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DE5E21080063; Fri, 29 Jan 2021 03:57:03 -0500 (EST) From: Thomas Monjalon To: oulijun , Ferruh Yigit Cc: arybchenko@solarflare.com, dev@dpdk.org, linuxarm@openeuler.org Date: Fri, 29 Jan 2021 09:57:02 +0100 Message-ID: <3445400.gcINu9pssS@thomas> In-Reply-To: <5e75c811-c3ef-486a-471b-eeabde28bd7b@intel.com> References: <1611150232-609-1-git-send-email-oulijun@huawei.com> <117895e7-b00b-4f72-05ee-ced0d62d2aae@huawei.com> <5e75c811-c3ef-486a-471b-eeabde28bd7b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/01/2021 09:46, Ferruh Yigit: > On 1/29/2021 1:13 AM, oulijun wrote: > > =E5=9C=A8 2021/1/28 22:12, Thomas Monjalon =E5=86=99=E9=81=93: > >> 28/01/2021 13:43, Lijun Ou: > >>> The hns3 PMD add FEC features implementation in 20.11. > >>> Therefore, need to update the hns3.ini for supporting. > >>> > >>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Lijun Ou > >>> --- > >>> doc/guides/nics/features/hns3.ini | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/doc/guides/nics/features/hns3.ini=20 > >>> b/doc/guides/nics/features/hns3.ini > >>> index a467396..4ea568c 100644 > >>> --- a/doc/guides/nics/features/hns3.ini > >>> +++ b/doc/guides/nics/features/hns3.ini > >>> @@ -39,5 +39,6 @@ Stats per queue =3D Y > >>> FW version =3D Y > >>> Registers dump =3D Y > >>> Multiprocess aware =3D Y > >>> +FEC =3D Y > >> > >> Please don't use tabs but only spaces in such .ini file. > >> > > OK=EF=BC=8C I will fix it > >> Can it be squashed with the commit adding the feature in default.ini? > > Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advi= ce. >=20 > Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged. Yes please. All three patches have the same intent: add FEC to features doc= =2E