[dpdk-dev] [PATCH 1/2] rte_tailq.h: Fix compilation under FreeBSD

[dpdk-dev] [PATCH 1/2] rte_tailq.h: Fix compilation under FreeBSD

[Alan Carew]

Recent change to rte_dump_tailq, which now uses a FILE parameter
causes compilation to fail under FreeBSD and sourced to a
missing include of stdio.h

This and next patch(both small) allows to compile without error.

Signed-off-by: Alan Carew <alan.carew@intel.com>
---
 lib/librte_eal/common/include/rte_tailq.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/common/include/rte_tailq.h b/lib/librte_eal/common/include/rte_tailq.h
index 42df7d2..0ddcc11 100644
--- a/lib/librte_eal/common/include/rte_tailq.h
+++ b/lib/librte_eal/common/include/rte_tailq.h
@@ -45,6 +45,7 @@ extern "C" {
 #endif
 
 #include <sys/queue.h>
+#include <stdio.h>
 
 /** dummy structure type used by the rte_tailq APIs */
 struct rte_dummy {
-- 
1.9.3

[dpdk-dev] [PATCH 2/2] eal_pci: Fix compilation under FreeBSD

[Alan Carew]

I'm not sure why this has not caused an issue before, perhaps
missing -Werror=unused-parameter or super-set
and subsequently fixed.
This patch adds __rte_unused to
pci_unbind_kernel_driver(struct rte_pci_device *dev)

Signed-off-by: Alan Carew <alan.carew@intel.com>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 94ae461..5c4d81b 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -110,7 +110,7 @@ static struct uio_res_list *uio_res_list = NULL;
 
 /* unbind kernel driver for this device */
 static int
-pci_unbind_kernel_driver(struct rte_pci_device *dev)
+pci_unbind_kernel_driver(struct rte_pci_device *dev __rte_unused)
 {
 	RTE_LOG(ERR, EAL, "RTE_PCI_DRV_FORCE_UNBIND flag is not implemented "
 		"for BSD\n");
-- 
1.9.3

Re: [dpdk-dev] [PATCH 1/2] rte_tailq.h: Fix compilation under FreeBSD

[Cao, Waterman]

Tested-by: Waterman Cao <waterman.cao@intel.com>

This patch is to fix compilation error in the FreeBSD 10.0 like the followings:
.. /include/rte_tailq.h:177:21: error: unknown type name 'FILE' void rte_dump_tailq(FILE *f);
../include/rte_memory.h:146:30: error: unknown type name 'FILE' void rte_dump_physmem_layout(FILE *f);

After merged this patch with last dpdk.org, compilation can pass without error in FreeBSD 10.0

Re: [dpdk-dev] [PATCH 1/2] rte_tailq.h: Fix compilation under FreeBSD

[Bruce Richardson]

On Thu, Jun 05, 2014 at 05:12:07PM +0100, Alan Carew wrote:
> Recent change to rte_dump_tailq, which now uses a FILE parameter
> causes compilation to fail under FreeBSD and sourced to a
> missing include of stdio.h
> 
> This and next patch(both small) allows to compile without error.
> 
> Signed-off-by: Alan Carew <alan.carew@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH 2/2] eal_pci: Fix compilation under FreeBSD

[Bruce Richardson]

On Thu, Jun 05, 2014 at 05:12:08PM +0100, Alan Carew wrote:
> I'm not sure why this has not caused an issue before, perhaps
> missing -Werror=unused-parameter or super-set
> and subsequently fixed.
> This patch adds __rte_unused to
> pci_unbind_kernel_driver(struct rte_pci_device *dev)
> 
> Signed-off-by: Alan Carew <alan.carew@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH 2/2] eal_pci: Fix compilation under FreeBSD

[Thomas Monjalon]

2014-06-10 22:00, Bruce Richardson:
> On Thu, Jun 05, 2014 at 05:12:08PM +0100, Alan Carew wrote:
> > I'm not sure why this has not caused an issue before, perhaps
> > missing -Werror=unused-parameter or super-set
> > and subsequently fixed.
> > This patch adds __rte_unused to
> > pci_unbind_kernel_driver(struct rte_pci_device *dev)
> > 
> > Signed-off-by: Alan Carew <alan.carew@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied for version 1.7.0.

Thanks
-- 
Thomas

Re: [dpdk-dev] [PATCH 1/2] rte_tailq.h: Fix compilation under FreeBSD

[Thomas Monjalon]

> > Recent change to rte_dump_tailq, which now uses a FILE parameter
> > causes compilation to fail under FreeBSD and sourced to a
> > missing include of stdio.h
> > 
> > This and next patch(both small) allows to compile without error.
> > 
> > Signed-off-by: Alan Carew <alan.carew@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied for version 1.7.0.

Thanks
-- 
Thomas