From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 926C5A00C4; Mon, 14 Feb 2022 10:22:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 282D840DDA; Mon, 14 Feb 2022 10:22:13 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CC82740C35 for ; Mon, 14 Feb 2022 10:22:11 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 282A75C0129; Mon, 14 Feb 2022 04:22:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 14 Feb 2022 04:22:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=bZfdl5P4o9WPYr Orv9KxkNxIUGfdsNaOBhzmR/Ygrmg=; b=CBOXZpbJTmyh/rnNxMTF4LjnQ3ceN3 BjPYvRNlEndIGn0XtYbD6ppjesr3nvEjg57paux2nM7DE+GZoKgu+kd0OCgff4B3 TASsASn/TP1onnvPbgzVRTIaNoU6iDed1jMzDmf8PejiOrXVhFiwoKQOsIfXvyGX FCsVKrDQChIuOUcpwsbA8E7T1z5B0VNdA4+4eRNzj11vlcVlG3weHG9613HoSblF A6O5dCNJ8jcaVvQHwC/ImlIvhH3P/I2sJfurfYgJsqhlwV02lKALhCQVSlkhIrxR +giXaJj88Ao7mFEWgx0Yj53qPM7bfNkrcMIZIsSBs4L99MSUfYceY5yw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=bZfdl5P4o9WPYrOrv9KxkNxIUGfdsNaOBhzmR/Ygr mg=; b=dAzE4/BetMm9KEwWpkY5UpKFOMn9/ybFDiwcI5Skh4ZRplo0iKRvRo4hj 7CLEfemFyA9MJT+734N1pyDy8CQeWZ6ipfDqE4SmFvTTUPCWqPda7D7yZVP6iyLM t/6tm6ZMCb21SxvQhJDtAZ4U+VlwWKZjXHzhIVWRP26vIApie0qJSPOKqKTKT5wM +g/7zj2GVu91gYYFGl0J5xv9k97fW+PHUpfc7HIgVgZhCvEb4/svKNfN5S9M+acp lDawYNqYeGykxFfMOj/bQ9CfDNc6JXZKhGP6WSC9plF8HvxDMisC5VOU/JICF2Xu 3WSgOda80L50aO3CNxHySeNUpmWAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjedugddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Feb 2022 04:22:09 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, ocardona@microsoft.com, roretzla@microsoft.com, david.marchand@redhat.com, ferruh.yigit@intel.com, bruce.richardson@intel.com Subject: Re: out of tree driver builds broken with C++ Date: Mon, 14 Feb 2022 10:22:08 +0100 Message-ID: <3450334.eFTFzoEnKi@thomas> In-Reply-To: <20220214091350.GA2793@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20220214091350.GA2793@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/02/2022 10:13, Tyler Retzlaff: > while the driver api is "internal" we agreed some time ago that drivers > could be built external to the dpdk tree. by enabling the meson setup > option -Denable_driver_sdk=true. > > it was agreed that the driver api was internal and would attract no > binary compatibility support which was fine. this change has now > imposed a further restriction that out of tree drivers have to be > authored in C only as non-C++ compatible code will invariably leak into > the internal structures. > > you won't allow us to build C++ drivers in the dpdk tree and it seems > now you are preventing building of C++ drivers outside of the tree too. That's the problem of non-written assumptions, they are unknown or forgotten. Did we agree to support out-of-tree drivers in C++? We really need to make things clear and written in documentation. > could we please re-evaluate this. Yes we can re-evaluate. What is the list of impacted files? > commit 7a335720575507f55b723b1e10bfea7daeba1386 > Author: Thomas Monjalon > Date: Wed Sep 15 18:46:35 2021 +0200 > > lib: remove C++ include guard from private headers > > The private headers are compiled internally with a C compiler. > Thus extern "C" declaration is useless in such files. > > Signed-off-by: Thomas Monjalon