From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7635CA04AA; Fri, 7 Aug 2020 02:29:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E536F2C28; Fri, 7 Aug 2020 02:29:26 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7B50F2BF2 for ; Fri, 7 Aug 2020 02:29:25 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1C8945C014E; Thu, 6 Aug 2020 20:29:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 06 Aug 2020 20:29:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= h07fgNxo4ngWa1NnCP0bXYMDT2q48SgIKr87ZHxJYWs=; b=ctRe38xOCCsVZxbL sxp2Ht/vOq2ho/Z/PNbTg1zAshKG3yrg1vj/ntKzjT2sUEvQDBNf5HiIO/rniZNs HyEUqVN5D9VxASjFmTTX2Tbkdem/MQhapIDZWdqbD9TqmcDoVtil03GXKczzia45 xMuIsVPx9klDjcZytceSwdZiNAI1lIsE69swrEGcjVm4ZNSAz9iDfKOhKX+iKk25 8p5Qd3KB2y0uqaCxLQg2LfI5P+vus1EHX5oq8ARb15BKOuIIvocIq+MtrXn15GsT tRYMMSMD3wyhlYRCAC5pJhsXU7iG0uHClrp1uD3PWbWPTMEWKDOSEpvK79ep/9+6 YTrMiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=h07fgNxo4ngWa1NnCP0bXYMDT2q48SgIKr87ZHxJY Ws=; b=D4lULGNfo2BG9Nz8kxbiNkZP12VOpE4PsWrqPZCKzFqWUKXdGIylrYTUG /fgOwEick+j7qv0vy0JUGI0xsfILLYuMkApSx5lt8BqU1gjbahDI19HEJF8IrYYj 84MQGww1KSkW8HXUiurD6BGout9KNTEhJAgNLzckPya7Xsj37vMGzjM+6H75HPar 0wBiP7cDPw4lYqlePS/eUNKFV+cuvT/vmBnyRwmufvp0RQBKt9jD67oMwPzCsdh4 EgAuPF/pF+c31vlCuDrFWi2qjIukBX3awryHcPlVr3LGQ87ku2aL4Htu54/VEl5Y ixSsReNBTChOiDpJWDl8EZ46dvy6A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrkedugdefiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudetveeujeetheeigefgieeuieekffefhfejteeuieehhffhvddu hfehheefheenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BC67630600A6; Thu, 6 Aug 2020 20:29:22 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, stephen@networkplumber.org, jerinj@marvell.com, arybchenko@solarflare.com, david.marchand@redhat.com, ferruh.yigit@intel.com, olivier.matz@6wind.com, akhil.goyal@nxp.com Date: Fri, 07 Aug 2020 02:29:21 +0200 Message-ID: <3450700.74BcBIW3jB@thomas> In-Reply-To: <20200608164640.189755-1-bruce.richardson@intel.com> References: <20200608164640.189755-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/06/2020 18:46, Bruce Richardson: > Rather than continuing to recommend an 80-char line limit, let's take a hint > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > Signed-off-by: Bruce Richardson > --- > -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} This is my personnal settings for years. [...] > -Line length is recommended to be not more than 80 characters, including comments. > +Line length is recommended to be not more than 100 characters, including comments. I think lines of 80 characters are reasonnable, but I would not reject a patch because few lines are between 80 and 100. I would reword the doc to reflect that flexibility: " Line length is recommended to be not more than 80 characters, including comments. The hard limit is 100 characters. "