From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2AB134C74 for ; Wed, 27 Feb 2019 11:56:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9760A22245; Wed, 27 Feb 2019 05:56:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Feb 2019 05:56:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4nOUKnVsrFPg/W1bDYoh+tJy8UU9jzCJxP1rbrZnKlk=; b=NcNYmU9rIc9y Ze8jdQLoJfh/km4sF539MPEMXUDIqPqJP+bHc0Bzr2FnCglh+mbOAZ4nJsmMVjpq hsXqdjTb9aTI68jMuvkogDKYWReIzrl87nEm3BRPNlou9PSiTdQxJnJkG5viGajk /+n8fgvdim5HQ5ASNFrBcM7AyJX3cdM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4nOUKnVsrFPg/W1bDYoh+tJy8UU9jzCJxP1rbrZnK lk=; b=VxT9LPRxwxCZKcafCAPJEGMMRjF99wqWQv+lD3Dn2hooUrahXRZ4pStam eBeK0/PtY3nZQ7fBC5WoFcq8OzvnxTx6+Ih7zhnRPc9Ths+0mhhFYdSVbLc5szku pkvtIT7W0xvIkrt28MLmEekH9BVGNtukoDar4k/xXi0V3TydPFOFLDMDB0fb6QN+ nkZTgMaEHBE4Bt01aFys/tZVfbP0bN8Nu6DUEf2qz0I1hUAjqtpiwmCZPtnjY8PZ CzlpEFx3D1CpqUEoFez4w/YEWhcOnZHPZMJiEKNbH/KuCQHkKPXtwYayiiA4h8na m5E7CFiCX7pXMYGaA04/3Xg5Y3AYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvddugddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D91710319; Wed, 27 Feb 2019 05:56:35 -0500 (EST) From: Thomas Monjalon To: Luca Boccassi Cc: Bruce Richardson , dev@dpdk.org Date: Wed, 27 Feb 2019 11:56:33 +0100 Message-ID: <3452725.6pELxiebTM@xps> In-Reply-To: <30cb42a8b2e0f0de063bc783fef8e4a4d86dbc52.camel@debian.org> References: <20190103175725.5836-1-bluca@debian.org> <20190227094746.GA91912@bricha3-MOBL.ger.corp.intel.com> <30cb42a8b2e0f0de063bc783fef8e4a4d86dbc52.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 10:56:37 -0000 27/02/2019 11:50, Luca Boccassi: > On Wed, 2019-02-27 at 09:47 +0000, Bruce Richardson wrote: > > On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > > > 26/02/2019 18:49, Luca Boccassi: > > > > On Tue, 2019-02-26 at 17:46 +0000, luca.boccassi@gmail.com wrote: > > > > > From: Luca Boccassi > > > > > > > > > > pcap has historically shipped a custom pcap-config binary tool > > > > > which > > > > > does the job of pkg-config. It was never compatible with cross > > > > > compilation. > > > > > Meson uses it when using dependency(), which then means cross > > > > > compilation fails. > > > > > Set pcap-config to empty in the meson cross compilation files > > > > > so > > > > > that Meson will not use it, and add a fallback in case > > > > > dependency() fails. > > > > > libpcap 1.9.0 finally ships a pkg-config file so everything > > > > > will > > > > > work out of the box in the future. > > > > > > > > > > Signed-off-by: Luca Boccassi > > > > > --- > > > > > v8: added back pcap change separately. Tested with bootlin > > > > > cross-compilation toolchain, everything seems to work. > > > > > > > > I had some time to invest so I added back this change, in a way > > > > that > > > > works with cross compilation too. Given the series wasn't merged > > > > yet > > > > and there was a conflict I've done a v8 rather than a single > > > > separate > > > > patch, but it's independent from the rest. > > > > > > > > More testing is of course welcome! > > > > > > I still see the same error when cross-compiling: > > > > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > > > > > Can patches 1-5 be merged anyway, leaving 6 for later? > > > > /Bruce > > Yes please... Yes, sure. I am checking other patches to push them. > Thomas, could you please give me detailed instructions on how to repro? > I used the bootlin toolchain you linked me last time, and passed -- > cross-file config/arm/arm64_armv8_linuxapp_gcc to Meson, and everything > built fine both with and without an arm64 build of libpcap in the > sysroot. With the previous version that I removed it would fail. Not > sure what I'm missing! I'm running devtools/test-meson-builds.sh on my ArchLinux which has aarch64-linux-gnu-gcc 8.2.0 but no arm pcap I guess.