From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
by dpdk.org (Postfix) with ESMTP id 7F3502C68
for <dev@dpdk.org>; Sun, 20 Mar 2016 11:39:42 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id l68so119905097wml.0
for <dev@dpdk.org>; Sun, 20 Mar 2016 03:39:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=hOONTczSeFhLFGHWzOMDgtMTodLBpIIPGKtZK4EteqI=;
b=CHruGwNbtmVDf2ald5yBHlbI0KDpM1HIznTfnfOcgAk9eHuH0BaihT02qCuS4agwXX
vBgwrusD/qlNjARoSjefpIMQTPLIJAvsDEUVHGHo0kcagbrVq15EAEmgMYT+zcZBnefV
IYoisrh3MUJnARo61gL6Grutmi1GBcQnrUIhhhJtJ/YH065bG5nr838UK9QIWf1FczdY
tjGqBQgQ61Uo5aTwiYFFgXH7LQHJMW2w9MIykUsVQfUki4UrbDYd9RW/Om+KprNycHAr
2uvzr+PEN6LrZKtrDgsu1vMcfpX4Ez2ZrILtCkz7rC7eF0LCh8+WpfbsklyqvbkmTzir
AacA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding;
bh=hOONTczSeFhLFGHWzOMDgtMTodLBpIIPGKtZK4EteqI=;
b=d+I+BZT4xNkRpuawUCCPNWdj0pR8ekqIz+kg0l5c0SgTyFqEI7Cv8lY1PW9XEC+wSH
imHcNs7PVu25/F/8McBk3RPaX6ngXXsi0HgDr5u3aibxT5KJLV4ABzgrBOK+kaBFO7Gg
JTMEFbN9VnBjw8O6QHZXRr651pH67TK8X9Qspq/tYA3Vn3gtVj8j4neWNzisDv6oWYLZ
KZHIlCzkrRug64H51f1JI8PFoFvfjIVR+X4UxJmOSwvPlcPKJ5ZKcYRv4pvGUB2mwwQG
XrbMOC7hNQUzrEm6i+ixlLGg2/9szvwU4NCgKANaLXzNIdjYdyFR8+1qx0380UoTk3uu
ndjQ==
X-Gm-Message-State: AD7BkJJipdKo7m2obTH7xZEQ59Bx/vTycdA/xeA50LEqpGb9LNPtX4lX1sQHN77yUm3DUym0
X-Received: by 10.194.134.202 with SMTP id pm10mr15289168wjb.111.1458470382320;
Sun, 20 Mar 2016 03:39:42 -0700 (PDT)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
by smtp.gmail.com with ESMTPSA id w133sm7288123wmd.3.2016.03.20.03.39.41
(version=TLSv1/SSLv3 cipher=OTHER);
Sun, 20 Mar 2016 03:39:41 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>
Date: Sun, 20 Mar 2016 11:38:06 +0100
Message-ID: <3454069.DYBbouSLX4@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <9BB6961774997848B5B42BEC655768F8DD9E51@SHSMSX104.ccr.corp.intel.com>
References: <1457502180-14124-1-git-send-email-jingjing.wu@intel.com>
<21476039.orzeTHEBVW@xps13>
<9BB6961774997848B5B42BEC655768F8DD9E51@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 07/12] librte_ether: extend flow director
struct
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Mar 2016 10:39:42 -0000
2016-03-20 09:02, Wu, Jingjing:
> From: Wu, Jingjing
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2016-03-10 11:25, Jingjing Wu:
> > > > This patch changed rte_eth_fdir_flow from union to struct to
> > > > support more packets formats, for example, Vxlan and GRE tunnel
> > > > packets with IP inner frame.
> > >
> > > I think we need a lot more explanations about how it should work.
> > > From this point we should collect some acknowledgements from the
> > > maintainers of other drivers having this kind of flow steering need.
> > > Maybe that a better API, more generic, is possible.
> > >
> > > > This patch also add new RTE_FDIR_TUNNEL_TYPE_GRE enum.
> > >
> > > OK to add GRE to the existing API.
> > >
> > > > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > [...]
> > > > /**
> > > > - * An union contains the inputs for all types of flow
> > > > + * A struct contains the inputs for all types of flow
> > > > */
> > > > -union rte_eth_fdir_flow {
> > > > - struct rte_eth_l2_flow l2_flow;
> > > > - struct rte_eth_udpv4_flow udp4_flow;
> > > > - struct rte_eth_tcpv4_flow tcp4_flow;
> > > > - struct rte_eth_sctpv4_flow sctp4_flow;
> > > > - struct rte_eth_ipv4_flow ip4_flow;
> > > > - struct rte_eth_udpv6_flow udp6_flow;
> > > > - struct rte_eth_tcpv6_flow tcp6_flow;
> > > > - struct rte_eth_sctpv6_flow sctp6_flow;
> > > > - struct rte_eth_ipv6_flow ipv6_flow;
> > > > +struct rte_eth_fdir_flow {
> > > > + union {
> > > > + struct rte_eth_l2_flow l2_flow;
> > > > + struct rte_eth_udpv4_flow udp4_flow;
> > > > + struct rte_eth_tcpv4_flow tcp4_flow;
> > > > + struct rte_eth_sctpv4_flow sctp4_flow;
> > > > + struct rte_eth_ipv4_flow ip4_flow;
> > > > + struct rte_eth_udpv6_flow udp6_flow;
> > > > + struct rte_eth_tcpv6_flow tcp6_flow;
> > > > + struct rte_eth_sctpv6_flow sctp6_flow;
> > > > + struct rte_eth_ipv6_flow ipv6_flow;
> > > > + };
> > > > struct rte_eth_mac_vlan_flow mac_vlan_flow;
> > > > struct rte_eth_tunnel_flow tunnel_flow;
> > > > };
> > >
> > > Please explain somewhere how to use this API change in order to have more
> > > discussions with other maintainers.
> > >
> > > I'm sorry to comment this change only now. I took time to realize that
> > > we need more consensus about the filtering API to make it usable by
> > > more drivers.
> > >
> >
> > > For the 16.04 release, I suggest to remove this change from the series.
> > > Thanks for your understanding.
> > OK. Understand that we need to comments more on the change. And as you know, the
> > whole patch set actually contains two changes on filter API: One the change is in this patch,
> > which adds tunnel filtering using flow director, another one is the patch "[PATCH v4,05/12]
> > i40e: extend flow director to filter by IP "
> > (http://www.dpdk.org/dev/patchwork/patch/11358/ ). If you are OK to the latter one, I will
> > send another version which just contains the change and drops tunnel supporting in 16.04
> > release.
> Correct the mistake:
> The other change is "[v4,01/12] ethdev: extend flow director for input selection" http://www.dpdk.org/dev/patchwork/patch/11354/.
I'm OK with patch 01 and "RTE_FDIR_TUNNEL_TYPE_GRE" add in patch 07.
> > And let's discuss more on the filtering API in future.
Thanks