From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B13AA0540; Mon, 4 Jul 2022 16:04:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24119410E5; Mon, 4 Jul 2022 16:04:30 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id EAF8540E09 for ; Mon, 4 Jul 2022 16:04:28 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 1390832002E8; Mon, 4 Jul 2022 10:04:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 04 Jul 2022 10:04:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656943464; x= 1657029864; bh=JZwChUGl1ftH7wGMuUYzjUaryn5hzC7eKJRspCnXFUE=; b=P VjeWc2BkagGhTRHP2GPK5HZPHiBvz6QNGFiJwSbAsoNGyR7pVrUxk3PmKoKop95S tXneCxjOniDF2S3YQe88Nw623GIzyaDP36MPf4N0qzYs6e0RP1Jcy8S9OWdSXStd YPIfCm1EPxw/JzxDlT3OXrQnVM8qleBGl29twHHuFh6HH+poVc/xTw261pq6Trm4 jp33aKwQ7S1Ni47SKG8GZB7OLJy2+LslkUsphYRpNTNc0T+Xo3TVY57Adu09m3rj myzGLl5xkWJgQmXqen1dgmiRSV8Vo3JM64GvcIBoI1oD+W6FMwcHbF9a6jExDuRS 9BGpEWoFP3S4yuCy236ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656943464; x= 1657029864; bh=JZwChUGl1ftH7wGMuUYzjUaryn5hzC7eKJRspCnXFUE=; b=C mlUfEnxg/Bxo1NZB0tX/PODHD/TG6ELLwOTq9HdS5ysiuH6Ho7yWp5bEWjxfT/Tr q9j78aJw0yX2b3eTaJg4bRNZdniUFp1omqQrSvoT4Fmyud72UQ5A2KkV5k6pfNbO C48nbynXzYaa2gm/0lPOA0Jjvr4Ox953bVOuRAYFymoynjW54+YGcQSwgtNVemzw TGKp81GTFDVncooTfdwNPTJMEl2hf27af7u7Ii5+iEQPhrS/CgCMIROTnDCRi983 N6CNK6G91Gnb8dkeUIAOy8J2RhJapEXfJy2dMzPMjg1mZVyanSb2w1cwGZL7MHis TUqxTV4Dk6sbEmmFkVT9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehledgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Jul 2022 10:04:22 -0400 (EDT) From: Thomas Monjalon To: Rahul Bhansali Cc: "dev@dpdk.org" , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Jerin Jacob Kollanukkaran , Akhil Goyal , "david.marchand@redhat.com" Subject: Re: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality Date: Mon, 04 Jul 2022 16:04:21 +0200 Message-ID: <3456222.nHSHbJBgIm@thomas> In-Reply-To: References: <20220524095717.3875284-1-rbhansali@marvell.com> <7631125.c0te8JeNC1@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/07/2022 14:49, Rahul Bhansali: > From: Thomas Monjalon > > 23/06/2022 11:38, Rahul Bhansali: > > > This will make the packet grouping function common, so that other > > > examples can utilize as per need. > > > > > > For each architecture sse/neon/altivec, port group headers will be > > > created under examples/common/. > > > > > > Signed-off-by: Rahul Bhansali > > > --- > > > Changes in v3: Created common port-group headers for architectures > > > sse/neon/altivec as suggested by Konstantin. > > > > > > Changes in v2: New patch to address review comment. > > > > > > examples/common/altivec/port_group.h | 48 +++++++++ > > > examples/common/neon/port_group.h | 50 ++++++++++ > > > examples/common/pkt_group.h | 139 +++++++++++++++++++++++++++ > > > examples/common/sse/port_group.h | 47 +++++++++ > > > examples/l3fwd/Makefile | 5 +- > > > examples/l3fwd/l3fwd.h | 2 - > > > examples/l3fwd/l3fwd_altivec.h | 37 +------ > > > examples/l3fwd/l3fwd_common.h | 129 +------------------------ > > > examples/l3fwd/l3fwd_neon.h | 39 +------- > > > examples/l3fwd/l3fwd_sse.h | 36 +------ > > > examples/meson.build | 2 +- > > > > OK you move code from l3fwd to another place. > > That's probably a step in the right direction. > > What about taking the extra step of making it an EAL API? > > Thanks for the suggestion. These changes are specific to fast path and I think EAL is more focused towards control path (Correct me if I am wrong). No, EAL is just a set of basic functions. Locks, time counters, bit ops are examples of EAL functions which can be used in data path. > Instead of EAL API, we can have it in library, but currently these are very few changes to form a library. > Later in future if we can identify more such common APIs then we can form a library around these specific things, so that more examples/app/library can use it. > Please suggest if this makes sense. These are just computations, it can be a file in EAL.