From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D39A547D2 for ; Mon, 30 Jun 2014 11:29:09 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 30 Jun 2014 02:29:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,574,1400050800"; d="scan'208";a="555179902" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga001.fm.intel.com with ESMTP; 30 Jun 2014 02:29:27 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 30 Jun 2014 10:28:16 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.56]) by IRSMSX154.ger.corp.intel.com ([169.254.12.216]) with mapi id 14.03.0123.003; Mon, 30 Jun 2014 10:28:17 +0100 From: "Doherty, Declan" To: Thomas Monjalon Thread-Topic: [PATCH v11 0/5] link bonding library Thread-Index: AQHPk8J50AZ1QJt5rE+Ao0reeRBimZuJUPAAgAARPBA= Date: Mon, 30 Jun 2014 09:28:16 +0000 Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC2730631F@IRSMSX101.ger.corp.intel.com> References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com> <1404064161-26370-1-git-send-email-declan.doherty@intel.com> <13010138.0NjEKNQfRt@xps13> In-Reply-To: <13010138.0NjEKNQfRt@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v11 0/5] link bonding library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2014 09:29:10 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, June 30, 2014 10:21 AM > To: Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [PATCH v11 0/5] link bonding library >=20 > Hi Declan, >=20 > 2014-06-29 18:49, Declan Doherty: > > This patchset contains the name change fix in the link bonding library > > makefile. I have also put a change into the unit test application makef= ile > > so that the link bonding tests are not built if the library is also not > > being built. It doesn't make sense to split the bonding libraries APIs = into > > a seperate library, as they are directly coupled to with the bonding > > library implmentation >=20 > You fixed optional building but there is still an issue when building sha= red > library. > As you don't want to split the library to separate the PMD plugin from th= e > specific API, I suggest to not consider it as a plugin (unlike other PMDs= ). >=20 > I've sent some patches about these 2 topics. > If you agree, I'll apply them, merged with your serie. >=20 > Thanks > -- > Thomas Hi Thomas, I'm happy for you to apply the makefile changes you have suggested and not= =20 consider the bonding PMD as a plugin, I think this makes the most sense considering it is a purely software library.=20 Thanks Declan