From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BABC7B388 for ; Tue, 2 Sep 2014 11:19:34 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 02 Sep 2014 02:15:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="380191698" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2014 02:19:28 -0700 Received: from irsmsx109.ger.corp.intel.com (163.33.3.23) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 2 Sep 2014 10:22:32 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.194]) by IRSMSX109.ger.corp.intel.com ([169.254.13.200]) with mapi id 14.03.0195.001; Tue, 2 Sep 2014 10:22:32 +0100 From: "Doherty, Declan" To: "dev@dpdk.org" Thread-Topic: [PATCH v2 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions Thread-Index: AQHPxb8yjHa+NDtmSEWJ3xdkPx+v+Zvti0jQ Date: Tue, 2 Sep 2014 09:22:31 +0000 Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com> References: <1408456313-28812-1-git-send-email-declan.doherty@intel.com> <1409560289-29558-5-git-send-email-declan.doherty@intel.com> In-Reply-To: <1409560289-29558-5-git-send-email-declan.doherty@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 09:19:35 -0000 > -----Original Message----- > From: Doherty, Declan > Sent: Monday, September 1, 2014 9:31 AM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; rsanford@akamai.com; Doherty, Declan > Subject: [PATCH v2 4/6] bond: free mbufs if transmission fails in bonding= tx_burst > functions >=20 > Fixing a number of corner cases that if transmission failed on slave devi= ces then > this > could lead to leaked mbufs >=20 > V2 addresses behaviouraly issues in the first version and packets are no = longer > freed in > the bonding layer, except in the case of broadcast mode where in failures= happen > on > more than a single slave then mbufs will be freed in all slaves except th= e one > where > the least errors occured. Also contains new unit tests to test the transm= ission > failure case in slaves for > round-robin, balance, and broadcast modes. >=20 >=20 > Signed-off-by: Declan Doherty > --- ..... > -- > 1.7.0.7 I've just noticed that I inserted an extra character into the patch when I = was annotating this patch which will cause this a fail compilation. > + TEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -s > + TEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT); should have been=20 > + TEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE - > + TEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT); Thomas, do you want me to submit a V3 of this? Regards Declan