DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
@ 2014-10-21  6:59 Ouyang Changchun
  2014-10-21  8:04 ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Ouyang Changchun @ 2014-10-21  6:59 UTC (permalink / raw)
  To: dev

Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT is disabled.

Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
 lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
index 2236250..a0d3d78 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
@@ -541,7 +541,7 @@ ixgbe_tx_free_bufs(struct igb_tx_queue *txq)
 #ifdef RTE_MBUF_REFCNT
 			m = __rte_pktmbuf_prefree_seg(txep[i].mbuf);
 #else
-			m = txep[i]->mbuf;
+			m = txep[i].mbuf;
 #endif
 			if (likely(m != NULL)) {
 				if (likely(m->pool == free[0]->pool))
-- 
1.8.4.2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
  2014-10-21  6:59 [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd Ouyang Changchun
@ 2014-10-21  8:04 ` Thomas Monjalon
  2014-10-21  8:19   ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2014-10-21  8:04 UTC (permalink / raw)
  To: Ouyang Changchun; +Cc: dev

2014-10-21 14:59, Ouyang Changchun:
> Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT is disabled.
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
  2014-10-21  8:04 ` Thomas Monjalon
@ 2014-10-21  8:19   ` De Lara Guarch, Pablo
  2014-10-21  8:28     ` Ouyang, Changchun
  0 siblings, 1 reply; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2014-10-21  8:19 UTC (permalink / raw)
  To: Thomas Monjalon, Ouyang, Changchun; +Cc: dev

Hi Thomas,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, October 21, 2014 9:04 AM
> To: Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> 2014-10-21 14:59, Ouyang Changchun:
> > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT is
> disabled.
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Applied

I was checking this patch right now, and I come across a second compilation issue,
 because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not declared, 
and Bond PMD and IP fragmentation libraries use those functions.

I guess that it is late to NACK this :P, but we require a second patch 
to fix completely this issue.

> 
> Thanks
> --
> Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
  2014-10-21  8:19   ` De Lara Guarch, Pablo
@ 2014-10-21  8:28     ` Ouyang, Changchun
  2014-10-21  8:36       ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Ouyang, Changchun @ 2014-10-21  8:28 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, Thomas Monjalon; +Cc: dev

Hi Pablo

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, October 21, 2014 4:19 PM
> To: Thomas Monjalon; Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> Hi Thomas,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Tuesday, October 21, 2014 9:04 AM
> > To: Ouyang, Changchun
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> >
> > 2014-10-21 14:59, Ouyang Changchun:
> > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > is
> > disabled.
> > >
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> >
> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >
> > Applied
> 
> I was checking this patch right now, and I come across a second compilation
> issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> declared, and Bond PMD and IP fragmentation libraries use those functions.
> 
> I guess that it is late to NACK this :P, but we require a second patch to fix
> completely this issue.
As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)
In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
Yes, agree with you, we need another patch to fix compilation issue in other both places.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
  2014-10-21  8:28     ` Ouyang, Changchun
@ 2014-10-21  8:36       ` Thomas Monjalon
  2014-10-21 13:45         ` Doherty, Declan
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2014-10-21  8:36 UTC (permalink / raw)
  To: Ouyang, Changchun, De Lara Guarch, Pablo; +Cc: dev

2014-10-21 08:28, Ouyang, Changchun:
> From: De Lara Guarch, Pablo
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > 2014-10-21 14:59, Ouyang Changchun:
> > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > > is disabled.
> > > >
> > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > >
> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > >
> > > Applied
> > 
> > I was checking this patch right now, and I come across a second compilation
> > issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> > declared, and Bond PMD and IP fragmentation libraries use those functions.
> > 
> > I guess that it is late to NACK this :P, but we require a second patch to fix
> > completely this issue.
> 
> As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)

Exact

> In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
> Yes, agree with you, we need another patch to fix compilation issue in other both places.

Yes, I'm aware of these limitations.
Please, first explain why mbuf refcnt is needed for these features.
Then we have 2 options: remove the dependency or add more ifdefs.

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
  2014-10-21  8:36       ` Thomas Monjalon
@ 2014-10-21 13:45         ` Doherty, Declan
  0 siblings, 0 replies; 6+ messages in thread
From: Doherty, Declan @ 2014-10-21 13:45 UTC (permalink / raw)
  To: Thomas Monjalon, Ouyang, Changchun, De Lara Guarch, Pablo; +Cc: dev

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, October 21, 2014 9:36 AM
> To: Ouyang, Changchun; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> 2014-10-21 08:28, Ouyang, Changchun:
> > From: De Lara Guarch, Pablo
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > > 2014-10-21 14:59, Ouyang Changchun:
> > > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > > > is disabled.
> > > > >
> > > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > > >
> > > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > > >
> > > > Applied
> > >
> > > I was checking this patch right now, and I come across a second compilation
> > > issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> > > declared, and Bond PMD and IP fragmentation libraries use those functions.
> > >
> > > I guess that it is late to NACK this :P, but we require a second patch to fix
> > > completely this issue.
> >
> > As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)
> 
> Exact
> 
> > In my config, both BOND and IP fragment is disabled. So I don't come across your
> issues.
> > Yes, agree with you, we need another patch to fix compilation issue in other
> both places.
> 
> Yes, I'm aware of these limitations.
> Please, first explain why mbuf refcnt is needed for these features.
> Then we have 2 options: remove the dependency or add more ifdefs.
> 
> Thanks
> --
> Thomas

Thomas, 
for link bonding the refcnt is used in broadcast mode to allow the same
mbuf to be transmitted on multiple slaves. By increasing the refcnt, we 
can safely transmit the mbuf on multiple slaves without the danger of a 
mbuf being freed by one slave while in use by another. I can provide a patch to
disable the broadcast mode of operation if the bonding pmd is built with the macro 
RTE_MBUF_REFCNT disabled. I don't think there is any other option other than 
than to completely disable the library if the refcnt parameter isn't available
as we don't have access to the transmit mempool to allocate new mbufs to
make copies of the original. 

Declan

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-10-21 21:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21  6:59 [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd Ouyang Changchun
2014-10-21  8:04 ` Thomas Monjalon
2014-10-21  8:19   ` De Lara Guarch, Pablo
2014-10-21  8:28     ` Ouyang, Changchun
2014-10-21  8:36       ` Thomas Monjalon
2014-10-21 13:45         ` Doherty, Declan

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git