From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D627C7E80 for ; Tue, 21 Oct 2014 23:27:09 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 21 Oct 2014 10:36:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,762,1406617200"; d="scan'208";a="622560011" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 21 Oct 2014 06:45:37 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 21 Oct 2014 14:45:37 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.201]) by IRSMSX106.ger.corp.intel.com ([169.254.8.193]) with mapi id 14.03.0195.001; Tue, 21 Oct 2014 14:45:37 +0100 From: "Doherty, Declan" To: Thomas Monjalon , "Ouyang, Changchun" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd Thread-Index: AQHP7PyvkVQql+jJ3ECcyaHb8qOX55w6IG+AgAAEMgCAAAK2AIAAAhsAgABg40A= Date: Tue, 21 Oct 2014 13:45:37 +0000 Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC273C07F0@IRSMSX101.ger.corp.intel.com> References: <1413874756-18669-1-git-send-email-changchun.ouyang@intel.com> <1652314.f9VDNlESRS@xps13> In-Reply-To: <1652314.f9VDNlESRS@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 21:27:10 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, October 21, 2014 9:36 AM > To: Ouyang, Changchun; De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd >=20 > 2014-10-21 08:28, Ouyang, Changchun: > > From: De Lara Guarch, Pablo > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > > 2014-10-21 14:59, Ouyang Changchun: > > > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCN= T > > > > > is disabled. > > > > > > > > > > Signed-off-by: Changchun Ouyang > > > > > > > > Acked-by: Thomas Monjalon > > > > > > > > Applied > > > > > > I was checking this patch right now, and I come across a second compi= lation > > > issue, because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not > > > declared, and Bond PMD and IP fragmentation libraries use those funct= ions. > > > > > > I guess that it is late to NACK this :P, but we require a second patc= h to fix > > > completely this issue. > > > > As it fixes the compilation issue in vpmd, so no reason to NACK it, :-= ) >=20 > Exact >=20 > > In my config, both BOND and IP fragment is disabled. So I don't come ac= ross your > issues. > > Yes, agree with you, we need another patch to fix compilation issue in = other > both places. >=20 > Yes, I'm aware of these limitations. > Please, first explain why mbuf refcnt is needed for these features. > Then we have 2 options: remove the dependency or add more ifdefs. >=20 > Thanks > -- > Thomas Thomas,=20 for link bonding the refcnt is used in broadcast mode to allow the same mbuf to be transmitted on multiple slaves. By increasing the refcnt, we=20 can safely transmit the mbuf on multiple slaves without the danger of a=20 mbuf being freed by one slave while in use by another. I can provide a patc= h to disable the broadcast mode of operation if the bonding pmd is built with th= e macro=20 RTE_MBUF_REFCNT disabled. I don't think there is any other option other tha= n=20 than to completely disable the library if the refcnt parameter isn't availa= ble as we don't have access to the transmit mempool to allocate new mbufs to make copies of the original.=20 Declan