From: "Doherty, Declan" <declan.doherty@intel.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
Date: Fri, 26 Jun 2015 07:33:03 +0000 [thread overview]
Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC27F26410@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1435135845-7060-1-git-send-email-tomaszx.kulasek@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Wednesday, June 24, 2015 1:51 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
>
> On Fortville NIC, link status change interrupt callback is not executed when
> slave in bonding is (re-)started. It causes that slave's NIC is inactive even
> if its link status is up on the start.
>
> This patch invokes lsc callback, just after port's start, to check its initial
> link status and manage properly.
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 8bad2e1..277b310 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1357,6 +1357,11 @@ slave_configure(struct rte_eth_dev
> *bonded_eth_dev,
> return -1;
> }
>
> + /* If lsc interrupt is set, check initial slave's link status */
> + if (slave_eth_dev->driver->pci_drv.drv_flags & RTE_PCI_DRV_INTR_LSC)
> + bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id,
> + RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev-
> >data->port_id);
> +
> return 0;
> }
>
> --
> 1.7.9.5
Acked-by : Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2015-06-26 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 8:50 Tomasz Kulasek
2015-06-26 7:33 ` Doherty, Declan [this message]
2015-06-28 22:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345C63BAECC1AD42A2EC8C63AFFC3ADC27F26410@irsmsx105.ger.corp.intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).