DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bond: fix check initial link status of slave
@ 2015-06-24  8:50 Tomasz Kulasek
  2015-06-26  7:33 ` Doherty, Declan
  0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Kulasek @ 2015-06-24  8:50 UTC (permalink / raw)
  To: dev

On Fortville NIC, link status change interrupt callback is not executed when
slave in bonding is (re-)started. It causes that slave's NIC is inactive even
if its link status is up on the start.

This patch invokes lsc callback, just after port's start, to check its initial
link status and manage properly. 

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 8bad2e1..277b310 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1357,6 +1357,11 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
 		return -1;
 	}
 
+	/* If lsc interrupt is set, check initial slave's link status */
+	if (slave_eth_dev->driver->pci_drv.drv_flags & RTE_PCI_DRV_INTR_LSC)
+		bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id,
+				RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev->data->port_id);
+
 	return 0;
 }
 
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
  2015-06-24  8:50 [dpdk-dev] [PATCH] bond: fix check initial link status of slave Tomasz Kulasek
@ 2015-06-26  7:33 ` Doherty, Declan
  2015-06-28 22:31   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Doherty, Declan @ 2015-06-26  7:33 UTC (permalink / raw)
  To: Kulasek, TomaszX, dev

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Wednesday, June 24, 2015 1:51 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
> 
> On Fortville NIC, link status change interrupt callback is not executed when
> slave in bonding is (re-)started. It causes that slave's NIC is inactive even
> if its link status is up on the start.
> 
> This patch invokes lsc callback, just after port's start, to check its initial
> link status and manage properly.
> 
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_pmd.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 8bad2e1..277b310 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1357,6 +1357,11 @@ slave_configure(struct rte_eth_dev
> *bonded_eth_dev,
>  		return -1;
>  	}
> 
> +	/* If lsc interrupt is set, check initial slave's link status */
> +	if (slave_eth_dev->driver->pci_drv.drv_flags & RTE_PCI_DRV_INTR_LSC)
> +		bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id,
> +				RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev-
> >data->port_id);
> +
>  	return 0;
>  }
> 
> --
> 1.7.9.5

Acked-by : Declan Doherty <declan.doherty@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] bond: fix check initial link status of slave
  2015-06-26  7:33 ` Doherty, Declan
@ 2015-06-28 22:31   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-06-28 22:31 UTC (permalink / raw)
  To: Kulasek, TomaszX; +Cc: dev

> > On Fortville NIC, link status change interrupt callback is not executed when
> > slave in bonding is (re-)started. It causes that slave's NIC is inactive even
> > if its link status is up on the start.
> > 
> > This patch invokes lsc callback, just after port's start, to check its initial
> > link status and manage properly.
> > 
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> 
> Acked-by : Declan Doherty <declan.doherty@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-28 22:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-24  8:50 [dpdk-dev] [PATCH] bond: fix check initial link status of slave Tomasz Kulasek
2015-06-26  7:33 ` Doherty, Declan
2015-06-28 22:31   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).