From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA4D1A0546; Wed, 7 Apr 2021 09:11:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D834914100E; Wed, 7 Apr 2021 09:11:40 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 942B7140FF7 for ; Wed, 7 Apr 2021 09:11:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 06C495C0138; Wed, 7 Apr 2021 03:11:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 07 Apr 2021 03:11:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= yMzArJ5/xg1c9rA2kwPeZxMxz5/5Hy1YyjLqTzLRBpg=; b=37KHnp62hff9ALkU DmfnktLBDm5pp61MnHay5GM22NT1WoB/KBwW++yLiOL0apYyl/MuwnU5ywdN37wI 2Z+zULtC4DD54wxUzxKqBMBjMwiwVbha5+nz/mpFzBI6bxGpBDuu/dN9XXuVgE01 0qergN6TyBoe6jPUTxsPuq2ci//Ij1eG0z15f+CoUtv8X/w/9vtsylFg1qpo6bzT j15s1/sf0ABhPNDwDZhcFo/eNlAyBI2mkYjIO2i8rPk9LoYuU/ZxHoA/vwmc/T4O 9mvs+hdn5C0KUj3/wcK1oVhU7w1v7QqtOHsbdg935sqjQHSs4Mdnu1+rxacw2bMU msRUaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yMzArJ5/xg1c9rA2kwPeZxMxz5/5Hy1YyjLqTzLRB pg=; b=PxBFLMjSbnoUlNX68PuhwD9D1PZdNRI40wvr6lEVfjiLSQwFJ0dkWgxym SZWHe+QtnMLFLGWhkDrHqA+mAr+zFkBIw0kcPjLNkBCr8RHIi6CgTaw5j8V4tQpc uu86JYRtZ5B56xhtiXdxLmGYLIlztC6MVfEWgyUtytb5TtYnffsW8dq3+VbxyPBO Ay1cUOYSLQWItQ7p4TfRpYEdVbgLk7BwWkmjiYIqDHkkD85NjA1ksBpqoCv5SbSQ gz6vMm33wejbBeXMAXBnvZnk00qexwEhq6zgG38EzsuEQ9d3H7YftarZdMkafM9b epGvSg/cJtfS2/X9/HayF6S9+7JwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejiedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 141B624005A; Wed, 7 Apr 2021 03:11:37 -0400 (EDT) From: Thomas Monjalon To: John Hurley , Suanming Mou Cc: dev@dpdk.org, Ori Kam , "dev@dpdk.org" , Slava Ovsiienko , Matan Azrad , Raslan Darawsheh Date: Wed, 07 Apr 2021 09:11:35 +0200 Message-ID: <3465474.71KI47HSL4@thomas> In-Reply-To: References: <20210309235732.3952418-1-suanmingm@nvidia.com> <1630409.ut38131ehT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] regex/mlx5: prevent wrong calculation of free sqs in umr mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/04/2021 03:00, Suanming Mou: > From: Thomas Monjalon > > 30/03/2021 03:39, Suanming Mou: > > > From: John Hurley > > > > > > A recent change adds support for scattered mbuf and UMR support for regex. > > > Part of this commit makes the pi and ci counters of the regex_sq a > > > quarter of the length in non umr mode, effectively moving them from 16 > > > bits to 14. The new get_free method casts the difference in pi and ci > > > to a 16 bit value when calculating the free send queues, accounting > > > for any wrapping when pi has looped back to 0 but ci has not yet. > > > However, the move to 14 bits while still casting to 16 can now lead to > > > corrupted, large values returned. > > > > > > Modify the get_free function to take in the has_umr flag and, > > > accordingly, account for wrapping on either 14 or 16 bit pi/ci difference. > > > > > > Fixes: d55c9f637263 ("regex/mlx5: add data path scattered mbuf > > > process") > > > > It is fixing a patch in this series, right? > > Why not squashing them? > > Yes, this is a fix for this series. > This fix was done by John when he tested the code, so I put it as an individual one. > Should we update an new version to squash it? Yes better to squash it in a v5, thanks. > (And Thomas, the latest version of this series is v4, you comment in this old v3 version now :) ) Yes, sorry.