DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yong Wang <yongwang@vmware.com>
To: Yogev Chaimovich <yogev@cgstowernetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix
Date: Mon, 20 May 2019 17:48:54 +0000	[thread overview]
Message-ID: <3466AC44-5074-43CE-891C-3585B0F0A275@vmware.com> (raw)
In-Reply-To: <1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com>


-----Original Message-----
From: Yogev Chaimovich <yogev@cgstowernetworks.com>
Date: Thursday, May 16, 2019 at 12:10 AM
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yogev Chaimovich <yogev@cgstowernetworks.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: [PATCH] net/vmxnet3: uninitialized variable fix

    Coverity issue: 323479
    Fixes: 30f77abe net/vmxnet3: support stats reset
    Cc: stable@dpdk.org
    
    Signed-off-by: yogev ch <yogev@cgstowernetworks.com>
    ---

Acked-by: Yong Wang <yongwang@vmware.com>

     drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index f54536b..c465996 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct rte_pci_device *pci_dev)
     {
     	unsigned int i;
     	struct vmxnet3_hw *hw = dev->data->dev_private;
    -	struct UPT1_TxStats txStats;
    -	struct UPT1_RxStats rxStats;
    +	struct UPT1_TxStats txStats = {0};
    +	struct UPT1_RxStats rxStats = {0};
     
     	VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
     
    -- 
    1.9.1
    
    


  parent reply	other threads:[~2019-05-20 17:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  7:10 Yogev Chaimovich
2019-05-16  7:10 ` Yogev Chaimovich
2019-05-16  8:28 ` David Marchand
2019-05-16  8:28   ` David Marchand
2019-05-20 17:48 ` Yong Wang [this message]
2019-05-27 16:23   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3466AC44-5074-43CE-891C-3585B0F0A275@vmware.com \
    --to=yongwang@vmware.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=yogev@cgstowernetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).