* [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct
@ 2019-07-22 11:47 Marcin Zapolski
2019-07-22 12:21 ` Ananyev, Konstantin
0 siblings, 1 reply; 3+ messages in thread
From: Marcin Zapolski @ 2019-07-22 11:47 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, Marcin Zapolski
The eth_dev_info was used with content that was obsolete. Added update
of struct content prior to use.
Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device array")
Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com>
---
examples/ip_fragmentation/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index edf87a1a1..03be0c12e 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -987,6 +987,7 @@ main(int argc, char **argv)
printf("\n");
/* init one TX queue per couple (lcore,port) */
+ rte_eth_dev_info_get(portid, &dev_info);
queueid = 0;
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
if (rte_lcore_is_enabled(lcore_id) == 0)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct
2019-07-22 11:47 [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct Marcin Zapolski
@ 2019-07-22 12:21 ` Ananyev, Konstantin
2019-07-22 17:10 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ananyev, Konstantin @ 2019-07-22 12:21 UTC (permalink / raw)
To: Zapolski, MarcinX A, dev; +Cc: Richardson, Bruce, Zapolski, MarcinX A
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marcin Zapolski
> Sent: Monday, July 22, 2019 12:47 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Zapolski, MarcinX A <marcinx.a.zapolski@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct
>
> The eth_dev_info was used with content that was obsolete. Added update
> of struct content prior to use.
>
> Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device array")
>
> Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com>
> ---
> examples/ip_fragmentation/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index edf87a1a1..03be0c12e 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -987,6 +987,7 @@ main(int argc, char **argv)
> printf("\n");
>
> /* init one TX queue per couple (lcore,port) */
> + rte_eth_dev_info_get(portid, &dev_info);
> queueid = 0;
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> if (rte_lcore_is_enabled(lcore_id) == 0)
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct
2019-07-22 12:21 ` Ananyev, Konstantin
@ 2019-07-22 17:10 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-22 17:10 UTC (permalink / raw)
To: Zapolski, MarcinX A; +Cc: dev, Ananyev, Konstantin, Richardson, Bruce, stable
22/07/2019 14:21, Ananyev, Konstantin:
> From: Marcin Zapolski
> > The eth_dev_info was used with content that was obsolete. Added update
> > of struct content prior to use.
> >
> > Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device array")
Cc: stable@dpdk.org
> >
> > Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Looks like previous patch was not tested :)
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 11:47 [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct Marcin Zapolski
2019-07-22 12:21 ` Ananyev, Konstantin
2019-07-22 17:10 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).