From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id E04E79A9C
 for <dev@dpdk.org>; Tue, 14 Jun 2016 18:18:06 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id k204so130412860wmk.0
 for <dev@dpdk.org>; Tue, 14 Jun 2016 09:18:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=VAgT6PUYwUCBVlkNQ6srTmxq1uvO8c160Uwj7Ynof+s=;
 b=oYr+33o9hRbTzdYB+B3GtWWS+50DG8UweVK6SsUAowdYXcOsEAQAldDl8CpGwITcZ+
 eg561Qw2DZawI+wFPfWxkbATV+xCM2rQLVN679AQvM/yXVJnRAG5UVgODAABjYB0PSWg
 sxpSGwa5ahREVGWHbdNMRRzxx6wjU05oB6QYFyh7/RXt43TGG51INLnTTfqB3NQW9lU0
 +bAXNwE+wQMnB7Y0bbDshHCzhCQvIsmMiPPonJx0nHPU355nEwWMaDLNwtxp02pkKadk
 l9JnoTSvpC8dxRziN0h8Qc8eup/2bG8fLOzqRiTih4qta8GTO0uXoMNwuOY5SGcV2tB2
 bzNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=VAgT6PUYwUCBVlkNQ6srTmxq1uvO8c160Uwj7Ynof+s=;
 b=Bq+vgyVEusFO6AYb0fmJCasqE6/PpRhWoiMm/4WySTvuKkhhn4cVjsshKXyEPJkri1
 AQBrYTaxvvaIXBab0v2hXVU8mB3c7D0zXrLk9eXOWPGJExaVKJhRcr/YZl6QzFMPzwY7
 mxPCq00Ub7yqfDZLquAoybH5zMXz69Y60JbBNXWey9V1MsxTz7W49PmOWTsqtGrFHe9S
 lTAGEQNU0YZfb3JGaBlg7VMfr2g0N9JxfGhgL0KJxwYSgwetyj2/v/V/Ikh5bwqsyLzk
 v09wbqnoDDbb4LLugsD7k2wdcr3n8c2f71qjfTCK7j0MboHrtThe/19AesC1E1XggyMU
 rKjg==
X-Gm-Message-State: ALyK8tInFMc1SylEuQQepg2hnyHYzjyg3PSrFeg7MuoxvkkuIVn4QKoqIRFXrHf76HRILnrn
X-Received: by 10.194.175.36 with SMTP id bx4mr7001506wjc.35.1465921086670;
 Tue, 14 Jun 2016 09:18:06 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id u70sm4898415wmd.4.2016.06.14.09.18.05
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 14 Jun 2016 09:18:05 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Date: Tue, 14 Jun 2016 18:18:05 +0200
Message-ID: <3476277.NVBV5Xgfk2@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <57602A9C.2040002@intel.com>
References: <20160614100352.GA14888@bricha3-MOBL3> <2912717.PxuBxaxfu4@xps13>
 <57602A9C.2040002@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] mlx: fix icc compilation error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2016 16:18:07 -0000

2016-06-14 17:02, Ferruh Yigit:
> On 6/14/2016 4:39 PM, Thomas Monjalon wrote:
> > 2016-06-14 16:22, Ferruh Yigit:
> >> Compilation errors:
> >> mlx4:
> >>   CC mlx4.o
> >>   .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type
> >>   mixed with another type
> >>           priv->intr_handle.type = 0;
> >>                                  ^
> >>
> >> mlx5:
> >>   CC em_rxtx.o
> >> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282):
> >> error #188: enumerated type mixed with another type
> >>         enum hash_rxq_type type = 0;
> >>                                   ^
> >>
> >> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(622):
> >> error #188: enumerated type mixed with another type
> >>                 if (!priv_allow_flow_type(priv, i)) {
> >>                                                 ^
> >> more same type of error
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Please add a Fixes line.
> > We need to think about the stable branch maintainer's task ;)
> > 
> I wasn't sure to add Fixes line for this patch, because it is not so
> useful reference since patch doesn't really fixes the code, just
> compilation error and touches a few different location that is scope of
> different commits:
> 
> Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
> Fixes: 198a3c339a8f ("mlx5: handle link status interrupts")
> Fixes: 0d2186743d62 ("mlx5: manage all special flow types at once")
> Fixes: 612ad38209f7 ("mlx5: fix hash Rx queue type in RSS mode")
> Fixes: 083c2dd31776 ("mlx5: refactor special flows handling")

Indeed.
Another way to help the maintenance is to give a tag where it was working,
e.g. it has been broken after the release v2.5...