From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 6D3A658D8 for ; Fri, 13 Mar 2015 09:52:04 +0100 (CET) Received: by wggz12 with SMTP id z12so21808466wgg.0 for ; Fri, 13 Mar 2015 01:52:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0E2tdEMffBQfLPgNO3O8I4xT3vYimwS+mRhIwbAurg4=; b=D2Ag4rjuw+Yse168f8chlMgkTEoC+PBTX72YdmqcZnGyLPQR+HWDt5Q5Ce1Iq0oK4A HyYL0KWeM0OW0Z1HWaPp0RQUjzX86CNaHCKbfWUyNBj1iD2y7/zNQKWSWPR5bZM3fVyo eL+nKo6KmyWrE28oCmEYdeUm5i+YOoN71kfr5NDiC0c3yqtVVmuDvmZDTRVyIpGzOnRl sEcYvhhgivqm97R1H2bw69Bdg7B0clz2YMLhFFiBblOVMl6y3/U+8wsN48s+2/+C9fWU cDfHzIdwQsYxV3mrbkENVIYvx08sHdVv01fVwHP82T84nSnwB7mX4T8ubJNBzMFFzhFI lImQ== X-Gm-Message-State: ALoCoQnnFvIrVzzcylrhkJdovcRIh9vXlusfb9eLH81RPMPzaRKaRzB6izzXTZKUONyK5lgsr646 X-Received: by 10.180.24.233 with SMTP id x9mr24716721wif.9.1426236724250; Fri, 13 Mar 2015 01:52:04 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id hl15sm1871829wib.3.2015.03.13.01.52.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2015 01:52:03 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Fri, 13 Mar 2015 09:51:30 +0100 Message-ID: <3476916.UDqlvyfgyR@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150311193621.GA17688@hmsreliant.think-freely.org> References: <1422652596-12777-1-git-send-email-nhorman@tuxdriver.com> <20150305165727.GB27783@hmsreliant.think-freely.org> <20150311193621.GA17688@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 08:52:04 -0000 Hi Neil, 2015-03-11 15:36, Neil Horman: > On Thu, Mar 05, 2015 at 11:57:27AM -0500, Neil Horman wrote: > > On Wed, Mar 04, 2015 at 05:49:50PM +0100, Thomas Monjalon wrote: > > > 2015-03-04 11:26, Neil Horman: > > > > +#trap on ctrl-c to clean up > > > > +trap cleanup_and_exit SIGINT > > > > > > I think INT is preffered over SIGINT. > > > You may also add QUIT and TERM. > > > With QUIT, you can replace cleanup_and_exit calls by a simple exit. > > > > > > > + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD` > > > > > > May be simpler "git log -1 --format=%H" > > > > > It might be, but the above is equivalent, and --format is a more recent git-log > > feature. Older versions still require --pretty=format > > > > > > +log "INFO" "We're going to check and make sure that applications built" > > > > +log "INFO" "against DPDK DSOs from tag $TAG1 will still run when executed" > > > > +log "INFO" "against DPDK DSOs built from tag $TAG2." > > > > > > I think it may be removed as no app is run. > > > > > The above doesn't indicate that an application will be run, only that the > > purpose of this script is to ensure that older applications will still run, > > which I think is appropriate. > > > > > > +# Make sure we configure SHARED libraries > > > > +# Also turn off IGB and KNI as those require kernel headers to build > > > > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > > > > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > > > > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET > > > > > > So you prefer modifying defconfig instead of .config, right? > > > (you sent it while I was answering on v2) > > > > > Yes, correct. > > > > > > +# Checking abi compliance relies on using the dwarf information in > > > > +# The shared objects. Thats only included in the DSO's if we build > > > > +# with -g > > > > +export EXTRA_CFLAGS=-g > > > > +export EXTRA_LDFLAGS=-g > > > [...] > > > > +export EXTRA_CFLAGS=-g > > > > +export EXTRA_LDFLAGS=-g > > > > > > Already exported. > > > > > Yeah, I'll clean that up later. OK, could you send a v4 please? > > > > + OLDNAME=`basename $i | sed -e"s/1.dump/0.dump/"` > > > > > > Could be OLDNAME=$(basename $i 1.dump)0.dump > > > > > > > + LIBNAME=`basename $i | sed -e"s/-ABI-1.dump//"` > > > > > > Could be LIBNAME=$(basename $i -ABI-1.dump) > > > > > It could be, but I prefer the clarity of the sed replacement. > > > > Neil > > > > > Thanks > > > > > > > > > > Ping Thomas, is this going to make 2.0? Yes sure, waiting a v4.