From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 3923011C5 for ; Tue, 8 Dec 2015 03:29:50 +0100 (CET) Received: by wmww144 with SMTP id w144so11716053wmw.0 for ; Mon, 07 Dec 2015 18:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=6Zbzo24heR6xckTA6VQM81ZedH3uzFwFkzGEOxSQxAE=; b=1BoGoUjZhncFmf3YSlhka4VgsDmrtRh3Aw2XzZpYlRPx7WESKqw2r2bh35R+Iu8/I5 +mJzp8tqWDk04u/7+MFIonXUFuKzXZ9Q3iyQH+1iim7uhwQjiHhdicZXTeiMRqzGeHm8 F4KgI0ekaYVlXq0U5gvUmwfuCNqVnov5zx1n/z/HIHTyjZBH8VM/iDF5UWSYGaiNb8Op 3t7wijo6iRozH9c7r7tgRdLWV4CiPIsYc7sga9UZjBByqQPJDkVk/T61Wdz7AmDqoH/l hUctX7iZGS1s+C6v6JWCjl+rnDmItimlKWrXj+qDYgJDGqSUL/H6iPXywRqi0brZU/T3 gkHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=6Zbzo24heR6xckTA6VQM81ZedH3uzFwFkzGEOxSQxAE=; b=BpfXlt/hD+TTx1LgY1VfebgzvF9J83raLcWJqETdZRKU15E5cE/mG3gd90ITuxmwte v19QoYylbOddQ9rXvt9fH7hNMpN1tfDfD+qaWHl0UgIUIen+o2lgbxniWbpsd6fd6ZRL l9R2p0PdEAarXrzB1g8MiJDwG1GyQSp066QDwHF9lwEVvlPGPzplL2IcvTbTikJmKGvC 6QPsRRrTIk+9rENlCp7zmIe+HoyWaYVSzKovecIHK565y4a0yVg+S7wM1YBT1OT46uyU +tQWyRv//XTIwInguafcoxADv3c3JFb0+mEJXmjNvVGog0NXjKokaNYHqLNyZgX+bzi3 R5Og== X-Gm-Message-State: ALoCoQmbm5yTDhdC48Mrh+c5/AiHEZ960n01GlaS9C0rHd6oW/H5wPGIoBaqhq6UKolGWzytJh2RXcllTfovQLoOUlnsgDGRog== X-Received: by 10.194.200.227 with SMTP id jv3mr1021124wjc.20.1449541790052; Mon, 07 Dec 2015 18:29:50 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id t64sm19282170wmf.23.2015.12.07.18.29.49 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 18:29:49 -0800 (PST) From: Thomas Monjalon To: "Betts, Ian" Date: Tue, 08 Dec 2015 03:28:37 +0100 Message-ID: <3478154.NlCHqoNvP3@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <877C1F8553E92F43898365570816082F35C0C401@IRSMSX103.ger.corp.intel.com> References: <1449225265-14480-2-git-send-email-ian.betts@intel.com> <1915132.14VGSMCEh2@xps13> <877C1F8553E92F43898365570816082F35C0C401@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 02:29:50 -0000 2015-12-08 01:54, Betts, Ian: > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, December 8, 2015 1:36 AM > To: Betts, Ian > Cc: dev@dpdk.org; stephen@networkplumber.org; Richardson, Bruce > Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread > > > +M: Ian Betts > > +M: John McNamara > > +F: doc/guides/sample_app_ug/performance_thread.rst > > > Why doing 2 sections? > > John is already the doc maintainer. You don't need to add him here. > > I just copy most of the other examples which also do this. > I also thought it was odd. No, John is really the co-maintainer of some examples. Please talk with him, you are in the same company. > I will remove him. > > > --- a/examples/Makefile > > +++ b/examples/Makefile > > @@ -77,5 +77,9 @@ DIRS-y += vmdq > > DIRS-y += vmdq_dcb > > DIRS-$(CONFIG_RTE_LIBRTE_POWER) += vm_power_manager > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += l2fwd-crypto > > - > > +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),) > > +ifneq ($(CONFIG_RTE_ARCH_X86_64),) > > +DIRS-y += performance-thread > > +endif > > +endif > > > Matter of taste, I would prefer DIRS-$(CONFIG_RTE_ARCH_X86_64) > > I need to combine CONFIG_RTE_EXEC_ENV_LINUXAPP ( the two clauses ) +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),) +DIRS-$(CONFIG_RTE_ARCH_X86_64) += performance-thread +endif It highlights the main dependency of this code: x86