From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 341E0A0548; Fri, 23 Apr 2021 12:53:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A786C410D8; Fri, 23 Apr 2021 12:53:27 +0200 (CEST) Received: from mail-109-mta71.mxroute.com (mail-109-mta71.mxroute.com [136.175.109.71]) by mails.dpdk.org (Postfix) with ESMTP id 781F04014F for ; Fri, 23 Apr 2021 12:53:26 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta71.mxroute.com (ZoneMTA) with ESMTPSA id 178fe5ce1c20004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 23 Apr 2021 10:53:23 +0000 X-Zone-Loop: a2d0fc19ee6c0112c693a5003be677c512e42a0d8e60 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cIZDmRvKBcjK6YfS4brQzEgnRrQxz9HHxa1uiYUPOC8=; b=Y9SWKhv5pHrN2Sc6gQ71pDH4rG n7HRDm/MD2MxByQPl9HSkWcfUovOdm4tJlaFrtW3ScYFVUowaSSLckvGyDZB+bPN9PjwR+CyUGfUi kHVDuN8Ti9Z3jLm8p+llN4O2EfOj6uIdOLa8xeqCIQ7C1cf5bPtdKxYkr4ZfNg0CH7IGPwF/7JhyC mvmqif/uEPTdUW1kWgS9Cqd/hBsS4rXHt91tJ1nK83H2lzrCODnQUXiS/fC8PSVVIK+luHEoQDuHe bkhrKyOKnRP1qeC9vZDIkqG7cNSCkhclN0ydMMCCKKkx82LL4Cg5DJABVmmpjaKZ/QZ2IODFgvr+S xMqRBOBQ==; To: gakhil@marvell.com, jerinj@marvell.com, thomas@monjalon.net, dev@dpdk.org, david.marchand@redhat.com Cc: abhinandan.gujjar@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, sachin.saxena@oss.nxp.com, anoobj@marvell.com, matan@nvidia.com, roy.fan.zhang@intel.com, g.singh@nxp.com, erik.g.carrillo@intel.com, jay.jayatheerthan@intel.com, pbhagavatula@marvell.com, harry.van.haaren@intel.com, sthotton@marvell.com References: <20210415090859.1319171-1-gakhil@marvell.com> From: "Kinsella, Ray" Message-ID: <347ace77-7704-5ac4-7dd9-0cabe88dfce0@ashroe.eu> Date: Fri, 23 Apr 2021 11:53:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210415090859.1319171-1-gakhil@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] doc: announce modification in eventdev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15/04/2021 10:08, gakhil@marvell.com wrote: > From: Akhil Goyal > > A new field ``ca_enqueue`` is added in ``rte_eventdev`` > in the end to maintain ABI. It needs to be moved above > in the structure to align with other enqueue callbacks. > > Signed-off-by: Akhil Goyal > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 2afc84c39..a973de4a9 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -127,6 +127,10 @@ Deprecation Notices > values to the function ``rte_event_eth_rx_adapter_queue_add`` using > the structure ``rte_event_eth_rx_adapter_queue_add``. > > +* eventdev: The function pointer ``ca_enqueue`` in structure ``rte_eventdev`` > + will be moved after ``txa_enqueue`` so that all enqueue/dequeue > + function pointers are adjacent to each other. > + > * sched: To allow more traffic classes, flexible mapping of pipe queues to > traffic classes, and subport level configuration of pipes and queues > changes will be made to macros, data structures and API functions defined > I admire the disipline - but since you are not actually removing ca_enqueue, just moving it in memory when the new ABI is declared in anycase, this is not required. Thanks, Ray K