From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D50E12BAE for ; Wed, 14 Feb 2018 16:28:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5031620AEF; Wed, 14 Feb 2018 10:28:21 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 14 Feb 2018 10:28:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=GEmzVRun2Jagq4J17LbJooECiM jtq0N92UWi3XwVIGY=; b=I3ZD5W4G3AKjfMQ7519tZyjU8I5o2yDHF6ddK2zZF2 psO5kABgh3iEMC89dgStHZwQ+5n/8SwJYx9a87jdumf7BENaDhXHZz0/nJe8HjBy Nmm71gBCwV+t7rlImGSQKi796OGSWwgMDnKgU0p0wCnMIsz7xdtmVmivttL2gCq+ c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GEmzVR un2Jagq4J17LbJooECiMjtq0N92UWi3XwVIGY=; b=M0TtADrTAgKgVL/0IeWaMt lwa4gg9Db+0X+Y6lMnMHiK07Yi6BgcBlH++1XvjcA/DrwjQlW13jlG5HnrnxyOTE 9xZSMuqC1JAasJWwfK13+rw/sBqS2s3Uir3WiTGcZcpoVZFx/459KFJJzGNlAKHO WKZvB2C0g6+ivW/9iKV3ERZDCEZKQFG/G76TQVjv0xbTUKa38x1z780EhH8J9Tuj nR9L8vFNoLlLFrYKmnjNgfzcqqBmNOrtGtY9QoFJ+VDgdCWk32IEiYp4XPOEr0lJ W+lteDUP7/KNynQMA2kBX9NIZ3h21jXKoSek8petB4KSrIHDyqoaqgvwlJ2dw8zg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 01B9B7E168; Wed, 14 Feb 2018 10:28:21 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet Date: Wed, 14 Feb 2018 16:28:09 +0100 Message-ID: <3483039.NpOkmzl4zC@xps> In-Reply-To: <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> References: <1518562772-29823-1-git-send-email-matan@mellanox.com> <1518619646-23990-1-git-send-email-matan@mellanox.com> <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 15:28:22 -0000 14/02/2018 16:00, Ga=EBtan Rivet: > On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote: > > Fail-safe dev_start() operation can be called by both the application > > and the hot-plug alarm mechanism. > >=20 > > The installation of Rx interrupt are triggered from dev_start() in any > > time it is called while actually the Rx interrupt should be installed > > only by the application calls. > >=20 > > So, each plug-in event causes reinstallation which causes memory leak > > and spoils the fail-safe Rx interrupt mechanism. > >=20 > > Trigger the Rx interrupt installation only when it does not exist. > >=20 > > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode") > >=20 > > Signed-off-by: Matan Azrad >=20 > Acked-by: Gaetan Rivet Applied, thanks