From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36442A0548; Fri, 9 Jul 2021 17:05:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4203416AD; Fri, 9 Jul 2021 17:05:56 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id BB7F84014D; Fri, 9 Jul 2021 17:05:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 47F625C0166; Fri, 9 Jul 2021 11:05:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 09 Jul 2021 11:05:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ZdlQn6NPcHUYeOv9TFsrfjO5fJYkS4rewM4Zu3XjxNw=; b=jd8aPjQEFE3nhSW5 rlI9WWrHTqOWhz+sI/DZKQ1vDen+k6aBRrV9+F+WACrwZgV9qdfuOin5p0a+g5pz S/64GKMtpJX94LFfjVSWZEaDp/vrC20Mzm48gCjN7LZpzKXUmNm97J+/A7WQXG7u iJeuVLaebLXENXY+smQypc5ec5r3YkS9eeyeMka4EqVxYFWWKfyzSe14g5BYC3Y+ JgXXKBSvCOh3B//6YzhAs8sHI0n/42Ikw0+7mlBiaWeAPZ2+XKFFJtw3DjEv8oZo y3E+bzFBG32sVmsRrkI8u3OxCSr2aXVyIn0fbEwhuJ41a3+R1MEnbNAEYzxULddt jQBW8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZdlQn6NPcHUYeOv9TFsrfjO5fJYkS4rewM4Zu3Xjx Nw=; b=UlPX53pJa32NhzLyxf0kWadu0+HZzB/6Hl4NIHsZv9KbPyT/gK8Pqb9/l qWXN36rho9S0vxnCQuBxyqBLWMbnPEKKoj8FqyAYMbPTLvAWgPU2Hhe0ZN3L7EFu VyWXTPFHtENEQDxNvfe/DYBwqXFy05S9aJd4lTEvjRDeuc0pRMx9/POSIBN/AVM2 gXYZblEfsS2laB4jA+4Bm3V2krzM5yw2HprOwTJGfPLp0KP4y4lTLsqL76+AIL3y bv4+XmYNxYBrq406Ar64/aXLaxDwLrHwAq/fecY5zAzkO0wPmhH9px/OCmWIIoDZ 1ULP6XrB9hKZimd6CxkFJsV//uTsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdeigdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Jul 2021 11:05:51 -0400 (EDT) From: Thomas Monjalon To: Nick Connolly Cc: stable@dpdk.org, Ranjit Menon , dev@dpdk.org, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, Bruce Richardson Date: Fri, 09 Jul 2021 17:05:50 +0200 Message-ID: <3483457.HQZ5InbKmW@thomas> In-Reply-To: References: <20210401122723.23082-1-nick.connolly@mayadata.io> <20210426100733.22478-1-nick.connolly@mayadata.io> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] build: fix symlink of drivers for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/05/2021 10:19, Bruce Richardson: > On Mon, Apr 26, 2021 at 11:07:32AM +0100, Nick Connolly wrote: > > The symlink-drivers-solibs.sh script was disabled as part of 'install' > > for Windows because there is no support for shell scripts. However, > > this means that driver related DLLs are not present in the installed > > 'libdir' directory. Add a python script to perform the install and use > > it for Windows if the version of meson supports using an external > > program with add_install_script (>= 0.55.0). > > > > On Windows, symbolic links are somewhat problematic since the > > SeCreateSymbolicLinkPrivilege is required to be able to create them. > > In addition, different cross-compilation environments handle symbolic > > links differently, e.g. WSL, Msys2, Cygwin. Rather than trying to > > distinguish these scenarios, the python script will perform a file copy > > for any Windows specific names. > > > > On Windows, the shared library outputs have different names depending > > upon which toolset has been used to build them. The script currently > > handles Clang and GCC. > > > > On Linux the functionality is unchanged, but could be replaced with the > > python script once the required minimum version of meson is >= 0.55.0. > > > > Fixes: 5c7d86948764 ("build: fix install on Windows") > > Cc: stable@dpdk.org > > > > Signed-off-by: Nick Connolly > > Tested-by: Narcisa Vasile > > Acked-by: Narcisa Vasile > > --- > Reviewed-by: Bruce Richardson Added the new file in MAINTAINERS. Applied, thanks.