DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Jain, Deepak K" <deepak.k.jain@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/test: fix qat autotest failure
Date: Tue, 1 Mar 2016 17:24:36 +0000	[thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B43588F8646F@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1456851316-22234-1-git-send-email-deepak.k.jain@intel.com>



> -----Original Message-----
> From: Jain, Deepak K
> Sent: Tuesday, March 01, 2016 4:55 PM
> To: dev@dpdk.org
> Cc: Griffin, John; Trahe, Fiona; Jain, Deepak K
> Subject: [PATCH] app/test: fix qat autotest failure
> 
> This patch fix the QAT autotest failure when run for multiple times.
> it was caused as mbuf was not freed.
> 
> Fixes: 202d375c60b (app/test: add cryptodev unit and performance tests)
> 
> This patch depends on following patch:
> cryptodev API changes
> http://dpdk.org/ml/archives/dev/2016-February/034212.html
> 
> Signed-off-by: Deepak Kumar JAIN <deepak.k.jain@intel.com>
> ---
>  app/test/test_cryptodev.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 208fc14..acba98a 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -1845,6 +1845,18 @@ test_multi_session(void)
>  				sessions[i], ut_params, ts_params),
>  				"Failed to perform decrypt on request "
>  				"number %u.", i);
> +		/* free crypto operation structure */
> +		if (ut_params->op)
> +			rte_crypto_op_free(ut_params->op);
> +
> +		/*
> +		 * free mbuf - both obuf and ibuf are usually the same,
> +		 * but rte copes even if we call free twice
> +		 */
> +		if (ut_params->obuf) {
> +			rte_pktmbuf_free(ut_params->obuf);
> +			ut_params->obuf = 0;
> +		}
>  	}
> 
>  	/* Next session create should fail */
> --
> 2.1.0
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

  reply	other threads:[~2016-03-01 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 16:55 Deepak Kumar JAIN
2016-03-01 17:24 ` Trahe, Fiona [this message]
2016-03-10 20:09   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348A99DA5F5B7549AA880327E580B43588F8646F@IRSMSX101.ger.corp.intel.com \
    --to=fiona.trahe@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).