From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9DFBC37A2 for ; Thu, 10 Mar 2016 17:13:48 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 10 Mar 2016 08:13:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="63630899" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2016 08:13:46 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX109.ger.corp.intel.com ([169.254.13.174]) with mapi id 14.03.0248.002; Thu, 10 Mar 2016 16:13:45 +0000 From: "Trahe, Fiona" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v9 4/5] cryptodev: change burst API to be crypto op oriented Thread-Index: AQHReuaycJJ0jMF2IESiArfjMlwUfZ9S2Sgw Date: Thu, 10 Mar 2016 16:13:45 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43588F8EC1A@IRSMSX101.ger.corp.intel.com> References: <1457617381-8296-1-git-send-email-fiona.trahe@intel.com> <1457624473-11138-5-git-send-email-fiona.trahe@intel.com> <1546962.OW49KDJ4kE@xps13> In-Reply-To: <1546962.OW49KDJ4kE@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjdiMDc4OTgtOWExMS00ZjljLTgzOWUtZWIwZWFhN2FjMGQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdKVGE3MmlWVEt0RWRSbTgxbENMa253Rm5ORGNwNEhDQnVJbmkzcVljNEE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 4/5] cryptodev: change burst API to be crypto op oriented X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 16:13:49 -0000 HI Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, March 10, 2016 4:03 PM > To: Trahe, Fiona > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 4/5] cryptodev: change burst API to be = crypto > op oriented >=20 > 2016-03-10 15:41, Fiona Trahe: > > lib/librte_cryptodev/rte_crypto_sym.h | 374 ++++++------ >=20 > Sorry there is another issue: >=20 > rte_crypto_sym.h:622: warning: argument 'op' of command @param is not > found in the argument list of __rte_crypto_sym_op_attach_sym_session(stru= ct > rte_crypto_sym_op *sym_op, struct rte_cryptodev_sym_session *sess) > rte_crypto_sym.h:628: warning: The following parameters of > __rte_crypto_sym_op_attach_sym_session(struct rte_crypto_sym_op *sym_op, > struct rte_cryptodev_sym_session *sess) are not documented: > parameter 'sym_op' > rte_crypto_sym.h:592: warning: unable to resolve reference to > `rte_cryptodev_session_create' for \ref command >=20 > I've fixed it with the following changes: >=20 > * The length of the data pointed to by this fiel= d is > * set up for the session in the @ref > * rte_crypto_auth_xform structure as part of the= @ref > - * rte_cryptodev_session_create function call. T= his > - * length must not exceed 240 bytes. > + * rte_cryptodev_sym_session_create function call= . > + * This length must not exceed 240 bytes. >=20 > /** > * Attach a session to a symmetric crypto operation > * > - * @param op crypto operation > + * @param sym_op crypto operation > * @param sess cryptodev session > */ This is great fun :) Do you need me to respin a v10 with that fix? Or have you applied with the fix?