From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 61CD52C39 for ; Thu, 29 Sep 2016 16:13:52 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 29 Sep 2016 07:13:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,415,1470726000"; d="scan'208";a="1047483051" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga001.fm.intel.com with ESMTP; 29 Sep 2016 07:13:49 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.224]) by IRSMSX154.ger.corp.intel.com ([169.254.12.149]) with mapi id 14.03.0248.002; Thu, 29 Sep 2016 15:12:24 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "akhil.goyal@nxp.com" , "dev@dpdk.org" CC: "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev Thread-Index: AQHSF+XvbsAkTvinlUW8hbkETdxLm6CMGhuAgARoi+A= Date: Thu, 29 Sep 2016 14:12:24 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435890E9364@IRSMSX101.ger.corp.intel.com> References: <20160926163300.22990-1-akhil.goyal@nxp.com> <20160926163300.22990-2-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGIxNGE2OTctMWEzNS00NWJiLTgyNDMtMGI3YTk5MGI5YTRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlQzVkhKNGE3dFc3blpvUVJxZlBtQ3F6K1lPZm1uRkQrSlJpbjNhVGFRUjg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 14:13:52 -0000 Hi Ahkil > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, September 26, 2016 8:37 PM > To: akhil.goyal@nxp.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for > nb_queue_pairs in test_cryptodev >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of > > akhil.goyal@nxp.com > > Sent: Monday, September 26, 2016 9:33 AM > > To: dev@dpdk.org > > Cc: Akhil Goyal > > Subject: [dpdk-dev] [PATCH] app/test: Remove hard coding for > > nb_queue_pairs in test_cryptodev > > > > From: Akhil Goyal > > > > nb_queue_pairs should not be hard coded with device specific number. > > It should be retrieved from the device infos. > > Also in ut_setup, ts_params->conf.nb_queue_pairs is already set in > > testsuite_setup and we are not modifying it. > > > > Signed-off-by: Akhil Goyal >=20 > Acked-by: Pablo de Lara The above code is correct, however it exposes a bug in QAT PMD unit tests. And some cleanup needed for unnecessary qp setup code. That cleanup then exposed a bug in aesni_mb PMD which prevents re-creating = queue pairs of a different size. =20 I have a fix and cleanup patch ready.=20 Just not sure how best to push it? The original patch also needs rebasing, doesn't apply cleanly to the latest= dpdk-next-crypto Pablo should I push all as a reply to the first patch - waiting first for t= hat to be rebased? Or=20 It would save Akhil a rebase and be simpler if I can include the original c= hange in my patch and push all as a v2 superceding the original patch? Is = this possible? Or=20 should I Nack the original patch and push all instead?