* [dpdk-dev] [PATCH] crypto/zuc: fix init function names
@ 2016-10-11 1:14 Pablo de Lara
2016-10-13 17:56 ` Trahe, Fiona
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2016-10-11 1:14 UTC (permalink / raw)
To: dev; +Cc: Pablo de Lara
All init/uninit function names in the virtual devices have been renamed,
so they finish with probe or remove, so to keep consistency,
same thing should be done in this PMD.
Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/zuc/rte_zuc_pmd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zuc_pmd.c
index 457f3ca..403dca9 100644
--- a/drivers/crypto/zuc/rte_zuc_pmd.c
+++ b/drivers/crypto/zuc/rte_zuc_pmd.c
@@ -445,7 +445,7 @@ zuc_pmd_dequeue_burst(void *queue_pair,
return nb_dequeued;
}
-static int cryptodev_zuc_uninit(const char *name);
+static int cryptodev_zuc_remove(const char *name);
static int
cryptodev_zuc_create(const char *name,
@@ -499,12 +499,12 @@ cryptodev_zuc_create(const char *name,
init_error:
ZUC_LOG_ERR("driver %s: cryptodev_zuc_create failed", name);
- cryptodev_zuc_uninit(crypto_dev_name);
+ cryptodev_zuc_remove(crypto_dev_name);
return -EFAULT;
}
static int
-cryptodev_zuc_init(const char *name,
+cryptodev_zuc_probe(const char *name,
const char *input_args)
{
struct rte_crypto_vdev_init_params init_params = {
@@ -526,7 +526,7 @@ cryptodev_zuc_init(const char *name,
}
static int
-cryptodev_zuc_uninit(const char *name)
+cryptodev_zuc_remove(const char *name)
{
if (name == NULL)
return -EINVAL;
@@ -539,8 +539,8 @@ cryptodev_zuc_uninit(const char *name)
}
static struct rte_vdev_driver cryptodev_zuc_pmd_drv = {
- .probe = cryptodev_zuc_init,
- .remove = cryptodev_zuc_uninit
+ .probe = cryptodev_zuc_probe,
+ .remove = cryptodev_zuc_remove
};
DRIVER_REGISTER_VDEV(CRYPTODEV_NAME_ZUC_PMD, cryptodev_zuc_pmd_drv);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/zuc: fix init function names
2016-10-11 1:14 [dpdk-dev] [PATCH] crypto/zuc: fix init function names Pablo de Lara
@ 2016-10-13 17:56 ` Trahe, Fiona
2016-10-13 19:36 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2016-10-13 17:56 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: De Lara Guarch, Pablo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Tuesday, October 11, 2016 2:15 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] crypto/zuc: fix init function names
>
> All init/uninit function names in the virtual devices have been renamed, so
> they finish with probe or remove, so to keep consistency, same thing should be
> done in this PMD.
>
> Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/zuc: fix init function names
2016-10-13 17:56 ` Trahe, Fiona
@ 2016-10-13 19:36 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2016-10-13 19:36 UTC (permalink / raw)
To: Trahe, Fiona, dev
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, October 13, 2016 10:57 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: RE: [dpdk-dev] [PATCH] crypto/zuc: fix init function names
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Tuesday, October 11, 2016 2:15 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] crypto/zuc: fix init function names
> >
> > All init/uninit function names in the virtual devices have been renamed, so
> > they finish with probe or remove, so to keep consistency, same thing should
> be
> > done in this PMD.
> >
> > Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-11 1:14 [dpdk-dev] [PATCH] crypto/zuc: fix init function names Pablo de Lara
2016-10-13 17:56 ` Trahe, Fiona
2016-10-13 19:36 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).