* [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data
@ 2017-07-11 13:35 Arek Kusztal
2017-07-11 13:35 ` [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions Arek Kusztal
2017-07-11 13:46 ` [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data Trahe, Fiona
0 siblings, 2 replies; 5+ messages in thread
From: Arek Kusztal @ 2017-07-11 13:35 UTC (permalink / raw)
To: dev
Cc: fiona.trahe, pablo.de.lara.guarch, john.griffin, deepak.k.jain,
abhinav.singh, Arek Kusztal
Fix AES-GMAC length of the data copied to the hardware to avoid
copying more data than necessary.
Fixes: 2fa64f840d65 ("crypto/qat: add GMAC capability")
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/crypto/qat/qat_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 7e04f21..6764553 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -1363,10 +1363,10 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg,
if (!do_aead) {
qat_req->comn_mid.dst_length =
qat_req->comn_mid.src_length =
- rte_pktmbuf_data_len(op->sym->m_src);
+ op->sym->auth.data.length;
auth_param->u1.aad_adr = 0;
auth_param->auth_len = op->sym->auth.data.length;
- auth_param->auth_off = op->sym->auth.data.offset;
+ auth_param->auth_off = 0;
auth_param->u2.aad_sz = 0;
}
}
--
2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions
2017-07-11 13:35 [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data Arek Kusztal
@ 2017-07-11 13:35 ` Arek Kusztal
2017-07-11 13:44 ` Trahe, Fiona
2017-07-11 13:46 ` [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data Trahe, Fiona
1 sibling, 1 reply; 5+ messages in thread
From: Arek Kusztal @ 2017-07-11 13:35 UTC (permalink / raw)
To: dev
Cc: fiona.trahe, pablo.de.lara.guarch, john.griffin, deepak.k.jain,
abhinav.singh, Arek Kusztal
This commit removes unused ablkcipher struct and functions
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/crypto/qat/qat_adf/qat_algs.h | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/crypto/qat/qat_adf/qat_algs.h b/drivers/crypto/qat/qat_adf/qat_algs.h
index ad4b8ba..4c0a09b 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs.h
+++ b/drivers/crypto/qat/qat_adf/qat_algs.h
@@ -139,14 +139,6 @@ struct qat_session {
rte_spinlock_t lock; /* protects this struct */
};
-struct qat_alg_ablkcipher_cd {
- struct icp_qat_hw_cipher_algo_blk *cd;
- phys_addr_t cd_paddr;
- struct icp_qat_fw_la_bulk_req fw_req;
- struct qat_crypto_instance *inst;
- rte_spinlock_t lock; /* protects this struct */
-};
-
int qat_get_inter_state_size(enum icp_qat_hw_auth_algo qat_hash_alg);
int qat_alg_aead_session_create_content_desc_cipher(struct qat_session *cd,
@@ -163,14 +155,6 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
void qat_alg_init_common_hdr(struct icp_qat_fw_comn_req_hdr *header,
enum qat_crypto_proto_flag proto_flags);
-void qat_alg_ablkcipher_init_enc(struct qat_alg_ablkcipher_cd *cd,
- int alg, const uint8_t *key,
- unsigned int keylen);
-
-void qat_alg_ablkcipher_init_dec(struct qat_alg_ablkcipher_cd *cd,
- int alg, const uint8_t *key,
- unsigned int keylen);
-
int qat_alg_validate_aes_key(int key_len, enum icp_qat_hw_cipher_algo *alg);
int qat_alg_validate_aes_docsisbpi_key(int key_len,
enum icp_qat_hw_cipher_algo *alg);
--
2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions
2017-07-11 13:35 ` [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions Arek Kusztal
@ 2017-07-11 13:44 ` Trahe, Fiona
2017-07-11 14:02 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 5+ messages in thread
From: Trahe, Fiona @ 2017-07-11 13:44 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev
Cc: De Lara Guarch, Pablo, Griffin, John, Jain, Deepak K, Singh, Abhinav
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, July 11, 2017 2:36 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Singh, Abhinav
> <abhinav.singh@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: remove unused ablkcipher struct and functions
>
> This commit removes unused ablkcipher struct and functions
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data
2017-07-11 13:35 [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data Arek Kusztal
2017-07-11 13:35 ` [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions Arek Kusztal
@ 2017-07-11 13:46 ` Trahe, Fiona
1 sibling, 0 replies; 5+ messages in thread
From: Trahe, Fiona @ 2017-07-11 13:46 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev
Cc: De Lara Guarch, Pablo, Griffin, John, Jain, Deepak K, Singh, Abhinav
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, July 11, 2017 2:36 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Singh, Abhinav
> <abhinav.singh@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix AES-GMAC length of data
>
> Fix AES-GMAC length of the data copied to the hardware to avoid
> copying more data than necessary.
>
> Fixes: 2fa64f840d65 ("crypto/qat: add GMAC capability")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions
2017-07-11 13:44 ` Trahe, Fiona
@ 2017-07-11 14:02 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-11 14:02 UTC (permalink / raw)
To: Trahe, Fiona, Kusztal, ArkadiuszX, dev
Cc: Griffin, John, Jain, Deepak K, Singh, Abhinav
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, July 11, 2017 2:45 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Singh,
> Abhinav <abhinav.singh@intel.com>
> Subject: RE: [PATCH] crypto/qat: remove unused ablkcipher struct and
> functions
>
>
>
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Tuesday, July 11, 2017 2:36 PM
> > To: dev@dpdk.org
> > Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Griffin, John
> > <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> > Singh, Abhinav <abhinav.singh@intel.com>; Kusztal, ArkadiuszX
> > <arkadiuszx.kusztal@intel.com>
> > Subject: [PATCH] crypto/qat: remove unused ablkcipher struct and
> > functions
> >
> > This commit removes unused ablkcipher struct and functions
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-11 14:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 13:35 [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data Arek Kusztal
2017-07-11 13:35 ` [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions Arek Kusztal
2017-07-11 13:44 ` Trahe, Fiona
2017-07-11 14:02 ` De Lara Guarch, Pablo
2017-07-11 13:46 ` [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data Trahe, Fiona
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).